From patchwork Wed Jul 7 18:14:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Brijesh Singh X-Patchwork-Id: 12363457 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09642C07E95 for ; Wed, 7 Jul 2021 18:31:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A5EA461CBE for ; Wed, 7 Jul 2021 18:31:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5EA461CBE Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 970816B0011; Wed, 7 Jul 2021 14:31:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 947A96B005D; Wed, 7 Jul 2021 14:31:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 773B06B0070; Wed, 7 Jul 2021 14:31:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id 5313E6B0011 for ; Wed, 7 Jul 2021 14:31:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A7D9B183F68C5 for ; Wed, 7 Jul 2021 18:31:23 +0000 (UTC) X-FDA: 78336634446.22.79E4F34 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2068.outbound.protection.outlook.com [40.107.243.68]) by imf10.hostedemail.com (Postfix) with ESMTP id 59CB06001F20 for ; Wed, 7 Jul 2021 18:31:18 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YfzGshlJcesDkGbjqe2y0oKP04askys0DrXrnads//xPjaAMSXJD11GfB6kgQFSW3ZUoUV8ACVLxQIQbJI08idiGpgAeo8rvUMEZwZUn7S1PClnteknFuLU6156aqTO2Tko/v7+lIODqJaQ6/2SeTA6S6RAi0pXQAu6+D+NgaL8fVM5uust5rsnhJM2Hs+K9TzsRtq29HBfCYqpsQOPXbbPVF+GXOUndAyuySUtE15OOJzLaTGxCNCtiRldA2/4L2ba3lXbtp+SE+ZqRlY0KChWiCLgqODw7B6cHEn8hnAQPA80/PiDWHzh/9dNnJvgDFud0GxuYuH8Q+Pdag5/g6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=auJREV1mAE69GKyOzop1JjXtKKGgG6Klxx/V2yHFQ3g=; b=OYG+R6gnHDIKl8kwHZ+0i9HSrJ/gbu/2mz1qQ03bZCLgubEoen8uSGIkTAua8WXbdlW9xSM1h94Y4FgCgy5LeoLVNDgIoRE4BZPOAeyvNVixPAkkXi3Walz+f9rMK+xdixUe5gB+g/aL/hWn4pJ32RymWBFZpn4P3kSLfg2S/p4rp/aoe1+CXyiUyX9xYXER+r2qVJLEQGzzE+hlr99+CXquEXxPqXyNvaloOkgoxqflAf3VVsksj5vlAaNtDeaCxluxdicHL0s6w1oGzRv3I8erFGQviIAa2X7Fdd9+dQ/AeF5zKqEtMrBHyOc6KIagcNsmFGt/dGOA2FvSrCxEOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=auJREV1mAE69GKyOzop1JjXtKKGgG6Klxx/V2yHFQ3g=; b=HrSGsT4R0zn7wwqppwYYfywID9vfpjr0B1JNGy9f47RkLCvA2MqGFsiWkaZDkQO5E0k1DYiaYaZEgyNmwDTJ0DVuhKICr7CeAKJnA935jhzFajVSVviSq624K0chhRzXIgL5ts4yLi7OhW2B+e6fUvfZIlRH/ypcbkrpVYcaQLg= Received: from BYAPR12MB2711.namprd12.prod.outlook.com (2603:10b6:a03:63::10) by BY5PR12MB3939.namprd12.prod.outlook.com (2603:10b6:a03:1a5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.21; Wed, 7 Jul 2021 18:15:45 +0000 Received: from BYAPR12MB2711.namprd12.prod.outlook.com ([fe80::40e3:aade:9549:4bed]) by BYAPR12MB2711.namprd12.prod.outlook.com ([fe80::40e3:aade:9549:4bed%7]) with mapi id 15.20.4287.033; Wed, 7 Jul 2021 18:15:44 +0000 From: Brijesh Singh To: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , tony.luck@intel.com, npmccallum@redhat.com, brijesh.ksingh@gmail.com, Brijesh Singh Subject: [PATCH Part1 RFC v4 07/36] x86/sev: Add a helper for the PVALIDATE instruction Date: Wed, 7 Jul 2021 13:14:37 -0500 Message-Id: <20210707181506.30489-8-brijesh.singh@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210707181506.30489-1-brijesh.singh@amd.com> References: <20210707181506.30489-1-brijesh.singh@amd.com> X-ClientProxiedBy: SA0PR11CA0104.namprd11.prod.outlook.com (2603:10b6:806:d1::19) To BYAPR12MB2711.namprd12.prod.outlook.com (2603:10b6:a03:63::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR11CA0104.namprd11.prod.outlook.com (2603:10b6:806:d1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.19 via Frontend Transport; Wed, 7 Jul 2021 18:15:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3eb902a3-cd3b-4552-4c5d-08d941733caf X-MS-TrafficTypeDiagnostic: BY5PR12MB3939: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F7r/4kdHQ0rInqhvejQW7Zp8vNvNMLLfVj7/Jz/Rj+rK4G4w1NbO0Af4kRGdGETs4ZmL9XtzrO58LkZSA9Qj+ldYVUcCv04G7gPXYGG7ZwwSnvuc6xx8LaLhKXUoztdT3blUG/MWIhJxt4rIjQKTQ0yfIA8UIP8RcVti84cZcdpKA8bNeNer0I3tUWRlLvcdrqLacX15T3CcTGl09dRhynbnsFHQ+uto1yi6+q6RkbvhtJRT8IGQ7twKeN9iyH2Hu5YcCwdB+Bmc64b838v9mwID1EMzTomr1yxfPjtA+1wHN66VHZxGltiVs7nnprd6iq8FilveRbl7WAEWc3EJYz2s+wBdn5OTIZ6+Gdt1Iyej8HpXYjWpQ0MXXlww2dPZk8qGYXIHC8pLdj9sdJnIELAJdjNeJQztFuBaT5X/mEVV8U6tncGEge8zL6URcIG3BTUKBUZYOTPMBX2oOl5R6Gc0tQ0MvnnfrMLCJbp6IsGNVmpunAfeV3GVD1iMZdFbMVEVS7VGfojHWuTQ4wiv/buHQk7CnRHB8VbPlxgtFY98hqJI1G6EvouSEjCBGDSqQ7zSumAFjnuaN7D0hCrNUHWMt2sxT3xaqoc3t/sq/ocO6143JjjQtvjdZ3YmncdvACIQuZWCoFRlQdISapyD582ls0AIXQWil6kyMrp+r/NNEcSiQbftKOoVnHLVJ2xG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB2711.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(39860400002)(366004)(376002)(136003)(44832011)(66556008)(38100700002)(38350700002)(66946007)(186003)(66476007)(2906002)(1076003)(26005)(52116002)(8936002)(2616005)(6486002)(7696005)(6666004)(5660300002)(8676002)(956004)(7406005)(7416002)(478600001)(83380400001)(316002)(54906003)(86362001)(36756003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?zKsC7ogO3PKg30J3O3jNOn6jGQ5R?= =?utf-8?q?kK4iatw9J0sJouB4gyDKppNDo5Ibj6v5gQs2HIgJLmrdS6PJ2RWJgNXyZHVlpO3NZ?= =?utf-8?q?36ar7pdpJJGgxJQCIGxMJqdBZ+K8ch7KhzIloVPfkFr6zFs/nhVemIh1S+fo8ZT+/?= =?utf-8?q?4BhrrFQW0j6JNWSEp9LDoDDx2B/FdL7X52Mw62bePChVXSlKyYWoFF2tPynhcpds0?= =?utf-8?q?Pb0gJviwLCKUHQQs/hXl7SQ1Yy0mtQd2hoW1A18/jrbyFT7PbJDnG5u1EB8pqiAT9?= =?utf-8?q?JKv7/4uD+SJy0yJ2pNZj5JFU9PHzGU+PIPVeTwT1Jrpz8oeM9cMVD9t18/EBWeXUi?= =?utf-8?q?2BnPGoLD8CA1AekkiXRn1CBvbMPFBM4dDCo2l+tKQFpWdcBTF5tBMILOCMB/bBnYm?= =?utf-8?q?25SnUHl8AKB0W2NmJeyJzIf8xFC53UFSyFV6xyjzTHeKD05sNbzU+N89UEcNjGh2j?= =?utf-8?q?pcUfZCYa84gAjuTZHjPLD+Vj0jkG9oEAgeWOcnjhbJpHjnrkXAaRra/rMHpoCTW6C?= =?utf-8?q?/BFgznNPQqnrOJdtMSXKOQ049cgvn72F9+PNUJv0Ffh0Ng9mOz3uknKgrIJRVazZp?= =?utf-8?q?fIEnV+LIBz6Z3qzryrmnh8OcCfCnFfaJZSHIPuZCfdzprALTtfxPH28h1nGv4Jeuw?= =?utf-8?q?NSsM0orD6D2izKgrQHLAoGgP2Ie73tg1hEFLwHgSB+M1VLGpkLJsjv/IEDdUNtrRM?= =?utf-8?q?lOi+OvBTpdFj9N86FWNhgWibeULba9cIxMT1D/XLaHU/Y22M0N1YCMQDBuqmunLW2?= =?utf-8?q?VpAteCwX0JPJn5mAMIWaFQI0RcgJvxOT2INkocY50SFCWhq2Yw75PVDuYQQZVTd/d?= =?utf-8?q?fCWKd0gchmc3NV1wkqRqFKmcGrrdgWev9QD5ullMxtp0QWDp4NZXlWfbMviTjWvcj?= =?utf-8?q?IM2Is6jdd82/81V/L/Y243n8ABcoGaI1LcQSTr8/MW2BrfB7Bx3mG7xSN0WK6gzgm?= =?utf-8?q?EOKfVFI5O2zy2fqJWpsOuT2Oc/N5ly2ZPjLbWI+l1B7z8kJjfTHxK+jfn1bx0pzD5?= =?utf-8?q?YH/kX/5Ytbh2SGE6oklwDoGBtnXG9tNk/rk1IOsSY8/3owYCWuUdo5qHkYyx3yfgb?= =?utf-8?q?zoDznzCxWu5xdXqTDCqkYkIMPsmm36NTkoZHGldRcEgC5MLnf8tooE2KbzDCwA5QN?= =?utf-8?q?lhon2UVjMbD+K1uB6uN48kAGW1EHydu/QtK/jOp/hs95nEV2jjVx9j1KjrscsvUYS?= =?utf-8?q?oKoa6+qCkF8srYKli802q/AcOf2yvQKhygBVFmg0i5/UZoAWYPdpz/Uc0dpuhrSBb?= =?utf-8?q?28zgSVZqEFyxjh8r?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3eb902a3-cd3b-4552-4c5d-08d941733caf X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2711.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2021 18:15:44.7699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6p9PEr6RfVFDsSCfxqGsddjjtc5oD8em6bLTWmjdOC1PC6T4aITahjzBV+Jc09hEAvMPWUIHlRVlT3EFVGgKqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3939 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=HrSGsT4R; spf=pass (imf10.hostedemail.com: domain of brijesh.singh@amd.com designates 40.107.243.68 as permitted sender) smtp.mailfrom=brijesh.singh@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com X-Rspamd-Server: rspam05 X-Stat-Signature: fubr3n65utboamj4bhznuqhtsmze5zrf X-Rspamd-Queue-Id: 59CB06001F20 X-Rspam-User: nil X-HE-Tag: 1625682678-4572 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: An SNP-active guest uses the PVALIDATE instruction to validate or rescind the validation of a guest page’s RMP entry. Upon completion, a return code is stored in EAX and rFLAGS bits are set based on the return code. If the instruction completed successfully, the CF indicates if the content of the RMP were changed or not. See AMD APM Volume 3 for additional details. Signed-off-by: Brijesh Singh --- arch/x86/include/asm/sev.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h index 134a7c9d91b6..b308815a2c01 100644 --- a/arch/x86/include/asm/sev.h +++ b/arch/x86/include/asm/sev.h @@ -59,6 +59,9 @@ extern void vc_no_ghcb(void); extern void vc_boot_ghcb(void); extern bool handle_vc_boot_ghcb(struct pt_regs *regs); +/* Software defined (when rFlags.CF = 1) */ +#define PVALIDATE_FAIL_NOUPDATE 255 + #ifdef CONFIG_AMD_MEM_ENCRYPT extern struct static_key_false sev_es_enable_key; extern void __sev_es_ist_enter(struct pt_regs *regs); @@ -81,12 +84,30 @@ static __always_inline void sev_es_nmi_complete(void) __sev_es_nmi_complete(); } extern int __init sev_es_efi_map_ghcbs(pgd_t *pgd); +static inline int pvalidate(unsigned long vaddr, bool rmp_psize, bool validate) +{ + bool no_rmpupdate; + int rc; + + /* "pvalidate" mnemonic support in binutils 2.36 and newer */ + asm volatile(".byte 0xF2, 0x0F, 0x01, 0xFF\n\t" + CC_SET(c) + : CC_OUT(c) (no_rmpupdate), "=a"(rc) + : "a"(vaddr), "c"(rmp_psize), "d"(validate) + : "memory", "cc"); + + if (no_rmpupdate) + return PVALIDATE_FAIL_NOUPDATE; + + return rc; +} #else static inline void sev_es_ist_enter(struct pt_regs *regs) { } static inline void sev_es_ist_exit(void) { } static inline int sev_es_setup_ap_jump_table(struct real_mode_header *rmh) { return 0; } static inline void sev_es_nmi_complete(void) { } static inline int sev_es_efi_map_ghcbs(pgd_t *pgd) { return 0; } +static inline int pvalidate(unsigned long vaddr, bool rmp_psize, bool validate) { return 0; } #endif #endif