From patchwork Mon Jul 12 03:06:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 12370089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5922EC07E99 for ; Mon, 12 Jul 2021 04:11:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 06F1A60E09 for ; Mon, 12 Jul 2021 04:11:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06F1A60E09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2720A6B0070; Mon, 12 Jul 2021 00:11:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 248C76B0098; Mon, 12 Jul 2021 00:11:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 111166B009F; Mon, 12 Jul 2021 00:11:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id E16126B0070 for ; Mon, 12 Jul 2021 00:11:02 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0EFE08248047 for ; Mon, 12 Jul 2021 04:11:02 +0000 (UTC) X-FDA: 78352610364.13.6446000 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id B39EF5014AEC for ; Mon, 12 Jul 2021 04:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=9yhwgjtp0/wX0Hn1pGrvOzLxkSolV7oLUpxeTzzP2kI=; b=UW30sXKj7aHH30b6jbziSvy3P2 vOcl6YTGy1a3AbP98rA40xIXpkkWqFjuiJUSrtM6oPHOtYsjmMiWh2w20LsgQ/Gc4Tt5hd38CKeNg RlokuaNpngG7gjUw3YFo+2p7tYOvel7mL9DpaIa8nqYKVZsrvt5zxJTjWTk9FnZuWS88K/e6YH/ni ht/hYAWU2UuYarhxCEc1cwCdWk2+gTyBqQH4RR7xdCUA+bBlXt9uiSRgt5kfpxrYNHOm8tbLjw4cq p2NtyOi7vCcCqroULkTFRa3fUJOWCb55mqpJ0lfP0fB75C1E4KNgPCcFEHMaFnkY1IOr9yKqc/6J3 KmWfvI5w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2nGU-00GrFT-AQ; Mon, 12 Jul 2021 04:10:16 +0000 From: "Matthew Wilcox (Oracle)" To: linux-kernel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v13 120/137] mm/filemap: Remove PageHWPoison check from next_uptodate_page() Date: Mon, 12 Jul 2021 04:06:44 +0100 Message-Id: <20210712030701.4000097-121-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210712030701.4000097-1-willy@infradead.org> References: <20210712030701.4000097-1-willy@infradead.org> MIME-Version: 1.0 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UW30sXKj; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: ksc15rre5zibpc6p4mm6tjdun9hwow9d X-Rspamd-Queue-Id: B39EF5014AEC X-HE-Tag: 1626063061-111566 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Pages are individually marked as suffering from hardware poisoning. Checking that the head page is not hardware poisoned doesn't make sense; we might be after a subpage. We check each page individually before we use it, so this was an optimisation gone wrong. Signed-off-by: Matthew Wilcox (Oracle) --- mm/filemap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 9da9bac99ecd..9a6550c8b7c7 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -3127,8 +3127,6 @@ static struct page *next_uptodate_page(struct page *page, goto skip; if (!PageUptodate(page) || PageReadahead(page)) goto skip; - if (PageHWPoison(page)) - goto skip; if (!trylock_page(page)) goto skip; if (page->mapping != mapping)