From patchwork Tue Jul 13 12:33:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 12373855 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 226F0C11F67 for ; Tue, 13 Jul 2021 12:34:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C99F36115A for ; Tue, 13 Jul 2021 12:34:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C99F36115A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0C3AD6B009C; Tue, 13 Jul 2021 08:34:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A6B96B009D; Tue, 13 Jul 2021 08:34:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E08BE6B009E; Tue, 13 Jul 2021 08:34:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0234.hostedemail.com [216.40.44.234]) by kanga.kvack.org (Postfix) with ESMTP id BDB766B009C for ; Tue, 13 Jul 2021 08:34:27 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C15B6824C439 for ; Tue, 13 Jul 2021 12:34:26 +0000 (UTC) X-FDA: 78357507732.27.106CF60 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by imf24.hostedemail.com (Postfix) with ESMTP id 77B29B0000A4 for ; Tue, 13 Jul 2021 12:34:26 +0000 (UTC) Received: by mail-qv1-f48.google.com with SMTP id i4so9756441qvq.10 for ; Tue, 13 Jul 2021 05:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=29CzU2MfFBs4HO+dO2xwX2Fgs88EDaKTdZ9XTaknGkI=; b=IeOWxRo4tqNrv4YId8Eu1dbiR6YhzdOXXZzZJs5iaGGoV7aTDKfkeTJmi+/OEwJggw /k+N7bnzmP7CERbXzTbovF8OI80AZg0al219BF/iaB1LUyjEC7ZdLski3/pBW2/pKTyH wE0UKqmJjW4Z4WJBCHb5bVWlPD3kHCwtzvGrPquuKUBF+ivYHXtj7ugTsJBPzOJfqUhf 1fmTPcBEWae8TY2uidOhBJ1kapFWJOn+iTWSIhB88z5JAJznTO+SSlTbymuY5v/J+EY+ 9ijFsYGDn13TIvAoRu7pInjO3Lkiq8Lboy1bRajqAoEmwnngDdpON6pz5J49n7LN30hh SLuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=29CzU2MfFBs4HO+dO2xwX2Fgs88EDaKTdZ9XTaknGkI=; b=NTH5SUtI631hNlHyPN4UPy3CKlUmguRYSNc/mdv58PwFOxOGzGBtHoIDPkgVoIM5L9 5i9iWycv9SYWg/LHMlP++9nhlCsq6huG0Tfg+Cb0cvKm9IBxettuYIKMCnYD2UNbCGxD UP3n5deKjwbtAKVt2kWRy4ewiC7/iNjlfWkXaqsjwvTtfwOQXr+kmNv2x9NKaJjD6kik iqvuofIC5Xbs9LHF+ZGlFvkQ0w/Tck+stQzMctx0wZQxcIweeHfcc9O4uO6LXPhpx0vD UZIe4iC5Qh9fpxl2LZlXUeZlM8bcN+wLCquPI7lgRSPp8TIOwtOKq6BHPNaPyhRv+dKq 0mEQ== X-Gm-Message-State: AOAM532ywHw91Q9ebNR3deeYPKpbS1tDJcW4Y19oeuizgmOJ8gGUSBc/ m6wMOy/EwVpT3Pdz9A27+8Q= X-Google-Smtp-Source: ABdhPJyqxX0dI0ttajKo6Fh4sb0degnyLatfj//Ins/NeU6wzqtnIVZnKYZAbOu9psWnURy/ew1UHw== X-Received: by 2002:a0c:9ac7:: with SMTP id k7mr4504097qvf.49.1626179665872; Tue, 13 Jul 2021 05:34:25 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id k14sm6849327qtm.18.2021.07.13.05.34.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 05:34:25 -0700 (PDT) From: SeongJae Park To: akpm@linux-foundation.org Cc: SeongJae Park , Jonathan.Cameron@Huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com, jgowans@amazon.com, mgorman@suse.de, mheyne@amazon.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, sieberf@amazon.com, sj38.park@gmail.com, snu@zelle79.org, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v33 06/13] mm/damon: Add a tracepoint Date: Tue, 13 Jul 2021 12:33:49 +0000 Message-Id: <20210713123356.6924-7-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210713123356.6924-1-sj38.park@gmail.com> References: <20210713123356.6924-1-sj38.park@gmail.com> Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=IeOWxRo4; spf=pass (imf24.hostedemail.com: domain of sj38park@gmail.com designates 209.85.219.48 as permitted sender) smtp.mailfrom=sj38park@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam02 X-Stat-Signature: wxwkqu81oigg1z5wkj7hsnzckxddtuwj X-Rspamd-Queue-Id: 77B29B0000A4 X-HE-Tag: 1626179666-164849 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park This commit adds a tracepoint for DAMON. It traces the monitoring results of each region for each aggregation interval. Using this, DAMON can easily integrated with tracepoints supporting tools such as perf. Signed-off-by: SeongJae Park Reviewed-by: Leonard Foerster Reviewed-by: Steven Rostedt (VMware) Reviewed-by: Fernand Sieber Acked-by: Shakeel Butt --- include/trace/events/damon.h | 43 ++++++++++++++++++++++++++++++++++++ mm/damon/core.c | 7 +++++- 2 files changed, 49 insertions(+), 1 deletion(-) create mode 100644 include/trace/events/damon.h diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h new file mode 100644 index 000000000000..2f422f4f1fb9 --- /dev/null +++ b/include/trace/events/damon.h @@ -0,0 +1,43 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM damon + +#if !defined(_TRACE_DAMON_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_DAMON_H + +#include +#include +#include + +TRACE_EVENT(damon_aggregated, + + TP_PROTO(struct damon_target *t, struct damon_region *r, + unsigned int nr_regions), + + TP_ARGS(t, r, nr_regions), + + TP_STRUCT__entry( + __field(unsigned long, target_id) + __field(unsigned int, nr_regions) + __field(unsigned long, start) + __field(unsigned long, end) + __field(unsigned int, nr_accesses) + ), + + TP_fast_assign( + __entry->target_id = t->id; + __entry->nr_regions = nr_regions; + __entry->start = r->ar.start; + __entry->end = r->ar.end; + __entry->nr_accesses = r->nr_accesses; + ), + + TP_printk("target_id=%lu nr_regions=%u %lu-%lu: %u", + __entry->target_id, __entry->nr_regions, + __entry->start, __entry->end, __entry->nr_accesses) +); + +#endif /* _TRACE_DAMON_H */ + +/* This part must be outside protection */ +#include diff --git a/mm/damon/core.c b/mm/damon/core.c index 28a2c78914fa..ee24d64e8019 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -13,6 +13,9 @@ #include #include +#define CREATE_TRACE_POINTS +#include + /* Get a random number in [l, r) */ #define damon_rand(l, r) (l + prandom_u32_max(r - l)) @@ -387,8 +390,10 @@ static void kdamond_reset_aggregated(struct damon_ctx *c) damon_for_each_target(t, c) { struct damon_region *r; - damon_for_each_region(r, t) + damon_for_each_region(r, t) { + trace_damon_aggregated(t, r, damon_nr_regions(t)); r->nr_accesses = 0; + } } }