From patchwork Thu Jul 15 03:36:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 12378931 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F56C47E48 for ; Thu, 15 Jul 2021 05:16:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1AF2E60241 for ; Thu, 15 Jul 2021 05:16:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AF2E60241 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6DDFE8D007F; Thu, 15 Jul 2021 01:16:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B4CF8D0065; Thu, 15 Jul 2021 01:16:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57D608D007F; Thu, 15 Jul 2021 01:16:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id 32A5D8D0065 for ; Thu, 15 Jul 2021 01:16:34 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1E74F184B5927 for ; Thu, 15 Jul 2021 05:16:33 +0000 (UTC) X-FDA: 78363661866.18.2EF1DEE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id E1AC610072FC for ; Thu, 15 Jul 2021 05:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=E4o291CiEkirXhlNU9qhgU1unG2pTpkpRkPYhVT13Jw=; b=hMx7mTzBw8NvkBPVXiIoTms9Np Qcbuveu5Ui3/uJEgMl4C+IRrRd67cr8V6ditJNZYTAOqUujZvcxpXVXdVAdxePjvHr26aIw4zpRii IYN5LwhWPvr//u/j3SxRVl3QKX08bhslxEspnQay0FmtMHwzth3Nk/LQ8j21yrY5jooR0/mmE0UoG lFQvxptbMLAI/wlzy6LZ/zrzVueYVz862OpRj0e7Iz1CRfBIoJKr+ciR4SYWE4oRcDb7Jk9Pj4jgP zSAKaQhC3SVtizLdl9vWsDwRyvrHR3f0kYlvI/mrxrzhGE6RBK9BTtsVPIM8ToPFD6faCzIVGpBKA KQ34HDkw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3thq-0030QK-2N; Thu, 15 Jul 2021 05:14:51 +0000 From: "Matthew Wilcox (Oracle)" To: linux-kernel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v14 121/138] mm/filemap: Remove PageHWPoison check from next_uptodate_page() Date: Thu, 15 Jul 2021 04:36:47 +0100 Message-Id: <20210715033704.692967-122-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210715033704.692967-1-willy@infradead.org> References: <20210715033704.692967-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E1AC610072FC X-Stat-Signature: o5tz6fd34zqar1s7bmmxxaus7wfwonfe Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hMx7mTzB; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1626326192-871853 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Pages are individually marked as suffering from hardware poisoning. Checking that the head page is not hardware poisoned doesn't make sense; we might be after a subpage. We check each page individually before we use it, so this was an optimisation gone wrong. Signed-off-by: Matthew Wilcox (Oracle) --- mm/filemap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 8510f67dc749..717b0d262306 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -3127,8 +3127,6 @@ static struct page *next_uptodate_page(struct page *page, goto skip; if (!PageUptodate(page) || PageReadahead(page)) goto skip; - if (PageHWPoison(page)) - goto skip; if (!trylock_page(page)) goto skip; if (page->mapping != mapping)