[183/212] mm/vmscan: remove the PageDirty check after MADV_FREE pages are page_ref_freezed

Commit Message

Andrew Morton Sept. 2, 2021, 9:59 p.m. UTC

From: Miaohe Lin <[e-mail]>
Subject: mm/vmscan: remove the PageDirty check after MADV_FREE pages are page_ref_freezed

Patch series "Cleanups for vmscan", v2.

This series contains cleanups to remove unneeded return value, misleading
setting and so on.  Also this remove the PageDirty check after MADV_FREE
pages are page_ref_freezed.  More details can be found in the respective
changelogs.


This patch (of 4):

If the MADV_FREE pages are redirtied before they could be reclaimed, put
the pages back to anonymous LRU list by setting SwapBacked flag and the
pages will be reclaimed in normal swapout way.  But as Yu Zhao pointed
out, "The page has only one reference left, which is from the isolation. 
After the caller puts the page back on lru and drops the reference, the
page will be freed anyway.  It doesn't matter which lru it goes." So we
don't bother checking PageDirty here.

[Yu Zhao's comment is also quoted in the code.]

Link: https://lkml.kernel.org/r/[e-mail]
Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Miaohe Lin <[e-mail]>
Reviewed-by: Yu Zhao <[e-mail]>
Cc: Johannes Weiner <[e-mail]>
Cc: Vlastimil Babka <[e-mail]>
Cc: Michal Hocko <[e-mail]>
Cc: Jens Axboe <[e-mail]>
Cc: Joonsoo Kim <[e-mail]>
Cc: Alex Shi <[e-mail]>
Cc: Alistair Popple <[e-mail]>
Cc: Matthew Wilcox <[e-mail]>
Cc: Minchan Kim <[e-mail]>
Cc: David Hildenbrand <[e-mail]>
Cc: Shaohua Li <[e-mail]>
Cc: Hillf Danton <[e-mail]>
Cc: John Hubbard <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 mm/vmscan.c |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

Patch

--- a/mm/vmscan.c~mm-vmscan-remove-the-pagedirty-check-after-madv_free-pages-are-page_ref_freezed
+++ a/mm/vmscan.c
@@ -1732,11 +1732,14 @@  retry:
 			/* follow __remove_mapping for reference */
 			if (!page_ref_freeze(page, 1))
 				goto keep_locked;
-			if (PageDirty(page)) {
-				page_ref_unfreeze(page, 1);
-				goto keep_locked;
-			}
-
+			/*
+			 * The page has only one reference left, which is
+			 * from the isolation. After the caller puts the
+			 * page back on lru and drops the reference, the
+			 * page will be freed anyway. It doesn't matter
+			 * which lru it goes. So we don't bother checking
+			 * PageDirty here.
+			 */
 			count_vm_event(PGLAZYFREED);
 			count_memcg_page_event(page, PGLAZYFREED);
 		} else if (!mapping || !__remove_mapping(mapping, page, true,