| Message ID | 20211009071105.69544-1-ligang.bdlg@bytedance.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: mmap_lock: some improvements | expand |
On Sat, 9 Oct 2021 15:11:05 +0800 Gang Li <ligang.bdlg@bytedance.com> wrote: > Ftrace core will add "\n" automatically on print. "\n" in TP_printk > will create blank line, so remove it. > Yes, thank you! Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> -- Steve > Signed-off-by: Gang Li <ligang.bdlg@bytedance.com> > --- > include/trace/events/mmap_lock.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h > index 0abff67b96f0..5f980c92e3e9 100644 > --- a/include/trace/events/mmap_lock.h > +++ b/include/trace/events/mmap_lock.h > @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s\n", > + "mm=%p memcg_path=%s write=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false" > @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s success=%s\n", > + "mm=%p memcg_path=%s write=%s success=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false", > @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s\n", > + "mm=%p memcg_path=%s write=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false"
On 10/9/21 09:11, Gang Li wrote: > Ftrace core will add "\n" automatically on print. "\n" in TP_printk > will create blank line, so remove it. > > Signed-off-by: Gang Li <ligang.bdlg@bytedance.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> > --- > include/trace/events/mmap_lock.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h > index 0abff67b96f0..5f980c92e3e9 100644 > --- a/include/trace/events/mmap_lock.h > +++ b/include/trace/events/mmap_lock.h > @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s\n", > + "mm=%p memcg_path=%s write=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false" > @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s success=%s\n", > + "mm=%p memcg_path=%s write=%s success=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false", > @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s\n", > + "mm=%p memcg_path=%s write=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false" >
diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h index 0abff67b96f0..5f980c92e3e9 100644 --- a/include/trace/events/mmap_lock.h +++ b/include/trace/events/mmap_lock.h @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking, ), TP_printk( - "mm=%p memcg_path=%s write=%s\n", + "mm=%p memcg_path=%s write=%s", __entry->mm, __get_str(memcg_path), __entry->write ? "true" : "false" @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned, ), TP_printk( - "mm=%p memcg_path=%s write=%s success=%s\n", + "mm=%p memcg_path=%s write=%s success=%s", __entry->mm, __get_str(memcg_path), __entry->write ? "true" : "false", @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released, ), TP_printk( - "mm=%p memcg_path=%s write=%s\n", + "mm=%p memcg_path=%s write=%s", __entry->mm, __get_str(memcg_path), __entry->write ? "true" : "false"
Ftrace core will add "\n" automatically on print. "\n" in TP_printk will create blank line, so remove it. Signed-off-by: Gang Li <ligang.bdlg@bytedance.com> --- include/trace/events/mmap_lock.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)