diff mbox series

mm/mprotect.c: avoid repeated assignment in do_mprotect_pkey()

Message ID 20211012152444.4127-1-fishland@aliyun.com (mailing list archive)
State New
Headers show
Series mm/mprotect.c: avoid repeated assignment in do_mprotect_pkey() | expand

Commit Message

Liu Song Oct. 12, 2021, 3:24 p.m. UTC 
From: Liu Song <liu.song11@zte.com.cn>

After adjustment, the repeated assignment of "prev" is avoided,
and the readability of the code is improved.

Signed-off-by: Liu Song <liu.song11@zte.com.cn>
---
 mm/mprotect.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/mm/mprotect.c b/mm/mprotect.c
index 883e2cc85cad..e552f5e0ccbd 100644
--- a/mm/mprotect.c
+++ b/mm/mprotect.c
@@ -563,7 +563,7 @@  static int do_mprotect_pkey(unsigned long start, size_t len,
 	error = -ENOMEM;
 	if (!vma)
 		goto out;
-	prev = vma->vm_prev;
+
 	if (unlikely(grows & PROT_GROWSDOWN)) {
 		if (vma->vm_start >= end)
 			goto out;
@@ -581,8 +581,11 @@  static int do_mprotect_pkey(unsigned long start, size_t len,
 				goto out;
 		}
 	}
+
 	if (start > vma->vm_start)
 		prev = vma;
+	else
+		prev = vma->vm_prev;
 
 	for (nstart = start ; ; ) {
 		unsigned long mask_off_old_flags;