[101/262] lib/test_vmalloc.c: use swap() to make code cleaner

Commit Message

Andrew Morton Nov. 5, 2021, 8:39 p.m. UTC

From: Changcheng Deng <[e-mail]>
Subject: lib/test_vmalloc.c: use swap() to make code cleaner

Use swap() in order to make code cleaner. Issue found by coccinelle.

Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Changcheng Deng <[e-mail]>
Reported-by: Zeal Robot <[e-mail]>
Reviewed-by: Uladzislau Rezki (Sony) <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 lib/test_vmalloc.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Patch

--- a/lib/test_vmalloc.c~lib-test_vmallocc-use-swap-to-make-code-cleaner
+++ a/lib/test_vmalloc.c
@@ -393,7 +393,7 @@  static struct test_driver {
 static void shuffle_array(int *arr, int n)
 {
 	unsigned int rnd;
-	int i, j, x;
+	int i, j;
 
 	for (i = n - 1; i > 0; i--)  {
 		get_random_bytes(&rnd, sizeof(rnd));
@@ -402,9 +402,7 @@  static void shuffle_array(int *arr, int
 		j = rnd % i;
 
 		/* Swap indexes. */
-		x = arr[i];
-		arr[i] = arr[j];
-		arr[j] = x;
+		swap(arr[i], arr[j]);
 	}
 }