[56/87] init: make unknown command line param message clearer

Commit Message

Andrew Morton Nov. 9, 2021, 2:34 a.m. UTC

From: Andrew Halaney <[e-mail]>
Subject: init: make unknown command line param message clearer

The prior message is confusing users, which is the exact opposite of the
goal.  If the message is being seen, one of the following situations is
happening:

 1. the param is misspelled
 2. the param is not valid due to the kernel configuration
 3. the param is intended for init but isn't after the '--'
    delineator on the command line

To make that more clear to the user, explicitly mention "kernel command
line" and also note that the params are still passed to user space to
avoid causing any alarm over params intended for init.

Link: https://lkml.kernel.org/r/[e-mail]
Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters")
Signed-off-by: Andrew Halaney <[e-mail]>
Suggested-by: Steven Rostedt (VMware) <[e-mail]>
Acked-by: Randy Dunlap <[e-mail]>
Cc: Borislav Petkov <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 init/main.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patch

--- a/init/main.c~init-make-unknown-command-line-param-message-clearer
+++ a/init/main.c
@@ -924,7 +924,9 @@  static void __init print_unknown_bootopt
 	for (p = &envp_init[2]; *p; p++)
 		end += sprintf(end, " %s", *p);
 
-	pr_notice("Unknown command line parameters:%s\n", unknown_options);
+	/* Start at unknown_options[1] to skip the initial space */
+	pr_notice("Unknown kernel command line parameters \"%s\", will be passed to user space.\n",
+		&unknown_options[1]);
 	memblock_free(unknown_options, len);
 }