From patchwork Tue Nov 9 02:34:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 12609527 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD78C433EF for ; Tue, 9 Nov 2021 02:34:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2D35B61242 for ; Tue, 9 Nov 2021 02:34:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2D35B61242 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C5DB26B00DE; Mon, 8 Nov 2021 21:34:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BEA596B00DF; Mon, 8 Nov 2021 21:34:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A87616B00E0; Mon, 8 Nov 2021 21:34:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 924596B00DE for ; Mon, 8 Nov 2021 21:34:38 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5B4987CA32 for ; Tue, 9 Nov 2021 02:34:38 +0000 (UTC) X-FDA: 78787823436.21.7926298 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf05.hostedemail.com (Postfix) with ESMTP id 129CE5096AD3 for ; Tue, 9 Nov 2021 02:34:17 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 053F361207; Tue, 9 Nov 2021 02:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1636425277; bh=gLOMIN8QQZcN06BJDTzjdGTz5NM4BPZ96ixKcmC+c9s=; h=Date:From:To:Subject:In-Reply-To:From; b=Iea/4qkPMyCDl2KyFNxgiCsXD/yf+vgK59y86cqrdpToBbgbXVrmSvoDscxAKlDAt 1EHBr+X0hgug4ymzWsigHO+Hem83v0XE4cObX1oyKExDRNNX0SMMZQgzIqvnL9NQmh DuLqw49WluTN8v34AoBWmV9clpe7I6/IyRJEya1w= Date: Mon, 08 Nov 2021 18:34:36 -0800 From: Andrew Morton To: akpm@linux-foundation.org, alex.shi@linux.alibaba.com, jaharkes@cs.cmu.edu, jing.yangyang@zte.com.cn, linux-mm@kvack.org, mm-commits@vger.kernel.org, tanxin.ctf@gmail.com, torvalds@linux-foundation.org, xiyuyang19@fudan.edu.cn, zealci@zte.com.cn Subject: [patch 59/87] coda: remove err which no one care Message-ID: <20211109023436.brvXunALu%akpm@linux-foundation.org> In-Reply-To: <20211108183057.809e428e841088b657a975ec@linux-foundation.org> User-Agent: s-nail v14.8.16 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="Iea/4qkP"; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 129CE5096AD3 X-Stat-Signature: rq3rcze7ijuhsfd6kf8tm1ksftxwnfhj X-HE-Tag: 1636425257-145750 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Alex Shi Subject: coda: remove err which no one care No one care 'err' in func coda_release, so better remove it. Link: https://lkml.kernel.org/r/20210908140308.18491-4-jaharkes@cs.cmu.edu Signed-off-by: Alex Shi Signed-off-by: Jan Harkes Cc: Jing Yangyang Cc: Xin Tan Cc: Xiyu Yang Cc: Zeal Robot Signed-off-by: Andrew Morton --- fs/coda/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/coda/file.c~coda-remove-err-which-no-one-care +++ a/fs/coda/file.c @@ -238,11 +238,10 @@ int coda_release(struct inode *coda_inod struct coda_file_info *cfi; struct coda_inode_info *cii; struct inode *host_inode; - int err; cfi = coda_ftoc(coda_file); - err = venus_close(coda_inode->i_sb, coda_i2f(coda_inode), + venus_close(coda_inode->i_sb, coda_i2f(coda_inode), coda_flags, coda_file->f_cred->fsuid); host_inode = file_inode(cfi->cfi_container);