From patchwork Tue Nov 9 02:34:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 12609529 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F076C433F5 for ; Tue, 9 Nov 2021 02:34:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 519EA61242 for ; Tue, 9 Nov 2021 02:34:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 519EA61242 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E812C6B00E0; Mon, 8 Nov 2021 21:34:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E0A4D6B00E1; Mon, 8 Nov 2021 21:34:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAA0E6B00E2; Mon, 8 Nov 2021 21:34:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id B56486B00E0 for ; Mon, 8 Nov 2021 21:34:41 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 76334180E1CFD for ; Tue, 9 Nov 2021 02:34:41 +0000 (UTC) X-FDA: 78787823562.15.180573C Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf19.hostedemail.com (Postfix) with ESMTP id DAF2BB000188 for ; Tue, 9 Nov 2021 02:34:32 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 14B0461284; Tue, 9 Nov 2021 02:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1636425280; bh=ohq+xby/Q0J2Nt4hZBVMMqzXY6qRlC7jQ6DICbM7idE=; h=Date:From:To:Subject:In-Reply-To:From; b=ZLTHk9XKYTCTwdlgvBFrHNMi8CULZZaJxq08GGKwRSG5HGvnVfsaBqVyb04vFfyGg 40neHvi41tis/wCDgROSAzrpOO7UKAvPsuVuEo531pgtHEeITwp/RPJWRMqF+7HJ/p 3ExyCD9LArs/Q00f07tyaxYX7W08HB3ED9KU5YB8= Date: Mon, 08 Nov 2021 18:34:39 -0800 From: Andrew Morton To: akpm@linux-foundation.org, alex.shi@linux.alibaba.com, jaharkes@cs.cmu.edu, jing.yangyang@zte.com.cn, linux-mm@kvack.org, mm-commits@vger.kernel.org, tanxin.ctf@gmail.com, torvalds@linux-foundation.org, xiyuyang19@fudan.edu.cn, zealci@zte.com.cn Subject: [patch 60/87] coda: avoid flagging NULL inodes Message-ID: <20211109023439.Ur2PyYjGa%akpm@linux-foundation.org> In-Reply-To: <20211108183057.809e428e841088b657a975ec@linux-foundation.org> User-Agent: s-nail v14.8.16 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZLTHk9XK; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DAF2BB000188 X-Stat-Signature: g65decb4yhcjc6r6jp4qejxinbueqbiy X-HE-Tag: 1636425272-930642 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jan Harkes Subject: coda: avoid flagging NULL inodes Somehow we hit a negative dentry in coda_rename even after checking with d_really_is_positive. Maybe something raced and turned the new_dentry negative while we were fixing up directory link counts. Link: https://lkml.kernel.org/r/20210908140308.18491-5-jaharkes@cs.cmu.edu Signed-off-by: Jan Harkes Cc: Alex Shi Cc: Jing Yangyang Cc: Xin Tan Cc: Xiyu Yang Cc: Zeal Robot Signed-off-by: Andrew Morton --- fs/coda/coda_linux.h | 3 +++ 1 file changed, 3 insertions(+) --- a/fs/coda/coda_linux.h~coda-avoid-flagging-null-inodes +++ a/fs/coda/coda_linux.h @@ -83,6 +83,9 @@ static __inline__ void coda_flag_inode(s { struct coda_inode_info *cii = ITOC(inode); + if (!inode) + return; + spin_lock(&cii->c_lock); cii->c_flags |= flag; spin_unlock(&cii->c_lock);