From patchwork Tue Nov 9 02:35:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 12609547 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04982C433EF for ; Tue, 9 Nov 2021 02:35:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ADEEE61381 for ; Tue, 9 Nov 2021 02:35:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ADEEE61381 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5325E6B00F2; Mon, 8 Nov 2021 21:35:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E1B36B00F3; Mon, 8 Nov 2021 21:35:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 360E86B00F4; Mon, 8 Nov 2021 21:35:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 1E8586B00F2 for ; Mon, 8 Nov 2021 21:35:09 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DA43C7CA23 for ; Tue, 9 Nov 2021 02:35:08 +0000 (UTC) X-FDA: 78787824696.04.C4C02FA Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP id 831A3100009D for ; Tue, 9 Nov 2021 02:35:08 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 7BDB3614C8; Tue, 9 Nov 2021 02:35:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1636425307; bh=PbmavDJ6h4OooK6vu/WDTawKbOV0n+Xfiz2K+zz7EsM=; h=Date:From:To:Subject:In-Reply-To:From; b=QHZj2C+UDscpHacbTMMu2UsbcGpGfCs5Xnrm2QPJNZe+AtCM2Dg3dmcUYU2TURxCg ReZMtC+h2PhDBzwW5EhH0AFoSUfSIYbpwEPO6/Ii/4xmbJdUfTIo5xdLF55ux/jvGk yMvuJZrllK1phTuqEq3MKa7821YFJlAK4ndTCxQM= Date: Mon, 08 Nov 2021 18:35:07 -0800 From: Andrew Morton To: akpm@linux-foundation.org, bhe@redhat.com, deng.changcheng@zte.com.cn, dyoung@redhat.com, horms@kernel.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, rppt@linux.ibm.com, torvalds@linux-foundation.org, vgoyal@redhat.com, ye.guojin@zte.com.cn, zealci@zte.com.cn Subject: [patch 69/87] crash_dump: fix boolreturn.cocci warning Message-ID: <20211109023507.XV_0-EOzC%akpm@linux-foundation.org> In-Reply-To: <20211108183057.809e428e841088b657a975ec@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 831A3100009D X-Stat-Signature: qecsadkc3rhnhfy1b6dxfarm7omnirb1 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QHZj2C+U; dmarc=none; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1636425308-403368 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Changcheng Deng Subject: crash_dump: fix boolreturn.cocci warning ./include/linux/crash_dump.h: 119: 50-51: WARNING: return of 0/1 in function 'is_kdump_kernel' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Link: https://lkml.kernel.org/r/20211020083905.1037952-1-deng.changcheng@zte.com.cn Signed-off-by: Changcheng Deng Reported-by: Zeal Robot Reviewed-by: Simon Horman Acked-by: Baoquan He Cc: Dave Young Cc: Mike Rapoport Cc: Vivek Goyal Cc: Ye Guojin Signed-off-by: Andrew Morton --- include/linux/crash_dump.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/crash_dump.h~crash_dump-fix-boolreturncocci-warning +++ a/include/linux/crash_dump.h @@ -116,7 +116,7 @@ extern void register_vmcore_cb(struct vm extern void unregister_vmcore_cb(struct vmcore_cb *cb); #else /* !CONFIG_CRASH_DUMP */ -static inline bool is_kdump_kernel(void) { return 0; } +static inline bool is_kdump_kernel(void) { return false; } #endif /* CONFIG_CRASH_DUMP */ /* Device Dump information to be filled by drivers */