From patchwork Tue Nov 9 02:35:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 12609555 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A94C433F5 for ; Tue, 9 Nov 2021 02:35:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C59B16137F for ; Tue, 9 Nov 2021 02:35:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C59B16137F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 6B8846B00FA; Mon, 8 Nov 2021 21:35:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F2C46B00FB; Mon, 8 Nov 2021 21:35:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AC286B00FD; Mon, 8 Nov 2021 21:35:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 2CFF96B00FC for ; Mon, 8 Nov 2021 21:35:21 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E7F671833A4B0 for ; Tue, 9 Nov 2021 02:35:20 +0000 (UTC) X-FDA: 78787825200.31.7A143D2 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP id 8F54A60020B9 for ; Tue, 9 Nov 2021 02:35:21 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F35461360; Tue, 9 Nov 2021 02:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1636425319; bh=4m/9it/qoKLdrA83lbpAfV0YEspJ+kRur+ACqIJhMOc=; h=Date:From:To:Subject:In-Reply-To:From; b=0EPaqoaQLPdcy2dIu47ycuGpnqKyIXNjjrH5IdjCnfM4pjv54La/WKU9dxqCvCexG DDZYSel+yMPjVtfxzkQaURqPLD1P7PvHowLWUBsL4LNPhQuIj/fSv2fzR6qI8WDcie ChKRC+ji9osQioDmEVuejHxwNNR/34+aCTGjjzAQ= Date: Mon, 08 Nov 2021 18:35:19 -0800 From: Andrew Morton To: adobriyan@gmail.com, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, christian.brauner@ubuntu.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, revest@chromium.org, sfr@canb.auug.org.au, songmuchun@bytedance.com, torvalds@linux-foundation.org Subject: [patch 73/87] seq_file: fix passing wrong private data Message-ID: <20211109023519.9dvm6-aET%akpm@linux-foundation.org> In-Reply-To: <20211108183057.809e428e841088b657a975ec@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8F54A60020B9 X-Stat-Signature: zf9r98ajwq7qyd3nn95o4gfnpoo8hax1 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0EPaqoaQ; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1636425321-333059 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Muchun Song Subject: seq_file: fix passing wrong private data DEFINE_PROC_SHOW_ATTRIBUTE() is supposed to be used to define a series of functions and variables to register proc file easily. And the users can use proc_create_data() to pass their own private data and get it via seq->private in the callback. Unfortunately, the proc file system use PDE_DATA() to get private data instead of inode->i_private. So fix it. Fortunately, there only one user of it which does not pass any private data, so this bug does not break any in-tree codes. Link: https://lkml.kernel.org/r/20211029032638.84884-1-songmuchun@bytedance.com Fixes: 97a32539b956 ("proc: convert everything to "struct proc_ops"") Signed-off-by: Muchun Song Cc: Andy Shevchenko Cc: Stephen Rothwell Cc: Florent Revest Cc: Alexey Dobriyan Cc: Christian Brauner Signed-off-by: Andrew Morton --- include/linux/seq_file.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/seq_file.h~seq_file-fix-passing-wrong-private-data +++ a/include/linux/seq_file.h @@ -209,7 +209,7 @@ static const struct file_operations __na #define DEFINE_PROC_SHOW_ATTRIBUTE(__name) \ static int __name ## _open(struct inode *inode, struct file *file) \ { \ - return single_open(file, __name ## _show, inode->i_private); \ + return single_open(file, __name ## _show, PDE_DATA(inode)); \ } \ \ static const struct proc_ops __name ## _proc_ops = { \