From patchwork Wed Nov 17 01:20:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pasha Tatashin X-Patchwork-Id: 12623455 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D77C433EF for ; Wed, 17 Nov 2021 01:24:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22CCC61BFE for ; Wed, 17 Nov 2021 01:24:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 22CCC61BFE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 384156B007E; Tue, 16 Nov 2021 20:21:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 332796B0080; Tue, 16 Nov 2021 20:21:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D3606B0081; Tue, 16 Nov 2021 20:21:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id 0EC4C6B007E for ; Tue, 16 Nov 2021 20:21:18 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D2B3F182C04C0 for ; Wed, 17 Nov 2021 01:21:07 +0000 (UTC) X-FDA: 78816668574.22.C051481 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf22.hostedemail.com (Postfix) with ESMTP id 27C861916 for ; Wed, 17 Nov 2021 01:21:07 +0000 (UTC) Received: by mail-qv1-f50.google.com with SMTP id b11so860461qvm.7 for ; Tue, 16 Nov 2021 17:21:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=itHiYOWCJUb0nrp2FwmrOfYUVUksojP1AIObWh9UO1s=; b=Amxwjgr/bi/cfwPexyIKSzy+cWQQa/FPLHp93s1kSUq0trv4NSPC1wYWiQsx6H6dod osfcMRXdqSomprDLvNprMq2ZO2tfPAs6GYlmnCTVq2MtJ0iOq3gwL+h8XCvJczhjYvDf tAxz/DpFCDrWKaB/61E83dSASNK8NuApouoburnZs8adqi0b+LV/BNqEuvRHPbtkdsT6 nmTvRuC1eD0VC1m+saF2HfeCjbkaA3XJfWGslibsaaLCebExLQNcTBNNVo74MI6/da2r IALeDG9/ImWlbzeMm68HZHcuVx8M40TSq6V4CNxISpzdhadHVF2tEAjmIo7+/QEF6Rdz Ybnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=itHiYOWCJUb0nrp2FwmrOfYUVUksojP1AIObWh9UO1s=; b=OKuauZ8qMDfW/QOno24Xek4W81nJAAa6S4E8+q+w7X9C9chpIS/cPDw9ovIp/7uaxX aedsCGN/3SnsgnnxkJDio0bsU2oRiCuLpcd5cCDc03t6OJ4p1tRoiIAhWD6fcVGCFMCA Lb/NomCiVmL+woZqOFznV01Ef8M6NMsbkdftLMal0PwDaE38lVIV1X98UY2Hodmsq0Cy uEjR2knhEBjQ8KHhKyFij2llgBDBAUW12k7ULl3L52C0T6zX7iP2HY1VDQ78gSlJexEe VO41ik03dfMU7muqUE+vsSQ0fMeWKErDMRppiBnIj7beeVbp4f2CzyiEAkwNoQgkn+EK hIfw== X-Gm-Message-State: AOAM531rXI55DCvfn2Thei6oSw8IIg+9VHroXjiiiJ7AYA6r+bWNvvRe hSa6UdYbx9eIxFbe2YQBOo2siw== X-Google-Smtp-Source: ABdhPJzmFAbbdMELzTH4m6zNqKMVAm1xIDyKURFrCR6PoeYAmy5SHEKE8sKURnOBTW/Ye7sxdr9bjg== X-Received: by 2002:a05:6214:29c3:: with SMTP id gh3mr23597620qvb.30.1637112066871; Tue, 16 Nov 2021 17:21:06 -0800 (PST) Received: from soleen.c.googlers.com.com (189.216.85.34.bc.googleusercontent.com. [34.85.216.189]) by smtp.gmail.com with ESMTPSA id i6sm3482289qti.40.2021.11.16.17.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 17:21:06 -0800 (PST) From: Pasha Tatashin To: pasha.tatashin@soleen.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-m68k@lists.linux-m68k.org, anshuman.khandual@arm.com, willy@infradead.org, akpm@linux-foundation.org, william.kucharski@oracle.com, mike.kravetz@oracle.com, vbabka@suse.cz, geert@linux-m68k.org, schmitzmic@gmail.com, rostedt@goodmis.org, mingo@redhat.com, hannes@cmpxchg.org, guro@fb.com, songmuchun@bytedance.com, weixugc@google.com, gthelen@google.com, rientjes@google.com, pjt@google.com Subject: [RFC v2 06/10] mm: rename init_page_count() -> page_ref_init() Date: Wed, 17 Nov 2021 01:20:55 +0000 Message-Id: <20211117012059.141450-7-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.34.0.rc1.387.gb447b232ab-goog In-Reply-To: <20211117012059.141450-1-pasha.tatashin@soleen.com> References: <20211117012059.141450-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 27C861916 X-Stat-Signature: 695xq3pgs487bfz8r5jamewqzi44nf4e Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=soleen.com header.s=google header.b="Amxwjgr/"; spf=pass (imf22.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=none X-HE-Tag: 1637112067-159022 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Now, that set_page_count() is not called from outside anymore and about to be removed, init_page_count() is the only function that is going to be used to unconditionally set _refcount, however it is restricted to set it only to 1. Make init_page_count() aligned with the other page_ref_* functions by renaming it. Signed-off-by: Pasha Tatashin Acked-by: Geert Uytterhoeven --- arch/m68k/mm/motorola.c | 2 +- include/linux/mm.h | 2 +- include/linux/page_ref.h | 10 +++++++--- mm/page_alloc.c | 2 +- 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/arch/m68k/mm/motorola.c b/arch/m68k/mm/motorola.c index 2b05bb2bac00..e81ecafedff3 100644 --- a/arch/m68k/mm/motorola.c +++ b/arch/m68k/mm/motorola.c @@ -133,7 +133,7 @@ void __init init_pointer_table(void *table, int type) /* unreserve the page so it's possible to free that page */ __ClearPageReserved(PD_PAGE(dp)); - init_page_count(PD_PAGE(dp)); + page_ref_init(PD_PAGE(dp)); return; } diff --git a/include/linux/mm.h b/include/linux/mm.h index a7e4a9e7d807..736bf16e7104 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2506,7 +2506,7 @@ extern void reserve_bootmem_region(phys_addr_t start, phys_addr_t end); static inline void free_reserved_page(struct page *page) { ClearPageReserved(page); - init_page_count(page); + page_ref_init(page); __free_page(page); adjust_managed_page_count(page, 1); } diff --git a/include/linux/page_ref.h b/include/linux/page_ref.h index 27880aca2e2f..ff946d753df8 100644 --- a/include/linux/page_ref.h +++ b/include/linux/page_ref.h @@ -107,10 +107,14 @@ static inline void folio_set_count(struct folio *folio, int v) } /* - * Setup the page count before being freed into the page allocator for - * the first time (boot or memory hotplug) + * Setup the page refcount to one before being freed into the page allocator. + * The memory might not be initialized and therefore there cannot be any + * assumptions about the current value of page->_refcount. This call should be + * done during boot when memory is being initialized, during memory hotplug + * when new memory is added, or when a previous reserved memory is unreserved + * this is the first time kernel take control of the given memory. */ -static inline void init_page_count(struct page *page) +static inline void page_ref_init(struct page *page) { set_page_count(page, 1); } diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 217c0c9fa25b..fc828dfde4fc 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1555,7 +1555,7 @@ static void __meminit __init_single_page(struct page *page, unsigned long pfn, { mm_zero_struct_page(page); set_page_links(page, zone, nid, pfn); - init_page_count(page); + page_ref_init(page); page_mapcount_reset(page); page_cpupid_reset_last(page); page_kasan_tag_reset(page);