From patchwork Wed Dec 1 14:30:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liam R. Howlett" X-Patchwork-Id: 12650345 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A33C433F5 for ; Wed, 1 Dec 2021 16:34:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58AEA6B007E; Wed, 1 Dec 2021 11:34:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 539936B0080; Wed, 1 Dec 2021 11:34:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 366006B0081; Wed, 1 Dec 2021 11:34:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 264856B007E for ; Wed, 1 Dec 2021 11:34:20 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D17AB8249980 for ; Wed, 1 Dec 2021 16:34:09 +0000 (UTC) X-FDA: 78869772618.06.E011364 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf20.hostedemail.com (Postfix) with ESMTP id E287BD0000AB for ; Wed, 1 Dec 2021 16:34:08 +0000 (UTC) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B1EGXh6017179; Wed, 1 Dec 2021 14:30:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=d9QpDyUyCoaaHcZCJU6UAi9EaJPiZ6K/NgXkBojs5xM=; b=LhiL9NFYRVr1es+dCayuwWP+vFlXe7lzgEaFyn+Zv0uaQ4DdHyNEZslVd8K7+IdNNUyi KGwdP9gXhErHelLXeT9aZbofjMhqaowBS5dqQPDal1XNMj6sVLqGKmVe68HNtpb9XdrE 7UbdKy5JCOr2e6qgnJHY/hTA0MnV+15Z9nGNNotJDsOdF3JPluNJx15rRVS42dKipQwc m5ffrElyxXeHtJPIfyhdbIzIFtw59nOuH2CB289WUOWc4h3oUUcukIOBBdHy70zT3Mru erRAASKo9KTiagMb9W31qxe9l7r/YgfCyUdqkfhiNromBOi+j2Zwf+GkYsGeQK7oI7Ae MQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3cp7weh2x4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 01 Dec 2021 14:30:54 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1B1EBl7e109791; Wed, 1 Dec 2021 14:30:48 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2102.outbound.protection.outlook.com [104.47.70.102]) by aserp3020.oracle.com with ESMTP id 3cnhveqcc9-7 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 01 Dec 2021 14:30:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VGlp3t0cp3JzRhefCDz6vIJRE1lJifjwE0S0kUOXTBvL+MICS5yroc14RScYDu8bLLZEnkxp/BIFjWbPBIQWFOBWEvshxI3VepM2FL9SIcjwpWaMn07qGN5J9IXo+Koev8oiQj3CBbq8S1s1WgRk2JCH+SFL6OWDJ6sZ3zNJXFwZgH2OJd2VJs4gXVK3G7M9fg1Bfx9ESQ7SyZciyD7yPgp26TsMvfLJ2E3diBfzk32vg93S07yeoZsK6D8/b9RbG0EeMsMDMGH7pkUMXqgKFwOVkgZwJMzXQF1TSaojuyOpP9EPp1NiIqIo6jzpokqJYQu83zXiF8LShbvP7m3DaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d9QpDyUyCoaaHcZCJU6UAi9EaJPiZ6K/NgXkBojs5xM=; b=Z8/0PJikcBqDOfbYbDAlmVemYPNZfBKCqHBbFnq30FweLKgKozVed1oTJF7/KxuNjTMilvj2pLt67VJQ5VXlKOR8OR6H1vBiVyCj06WXqB8Um0JiPJN7FZBiDnv0DwhChl1Qtg5rEIquBv1Q0aRAAMEM6Yfunww4TFzx87oQ1hWAhUFTSxm0ejlWSMmHZJOxlbzKopDRtoQqL5MXxAEGch8RNWNzRz5wN18GduAbsJuhpVYcBNhmEZGbsEf3ZfyjliGkn8M4D8Wd9WTizijwQM1tb3YNu1Joc0a1GqodJ/fQ+WcA6hrrt/0wh1aopFgxmquiP6G4fSid6lR1m99hYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d9QpDyUyCoaaHcZCJU6UAi9EaJPiZ6K/NgXkBojs5xM=; b=Re5obKQc6Wo2NJ7S7wevJdF70XSk4KG6gV1hiQ0YyhR8aCChBAn6/ynH/oeLYuJOpu5XfgyAiuQGV4XvFQ1MHDuQYCzNcEl3H+fQK+q6Hlj/xh5VIs7vsM4sHg/kjA0Fx/rCI9ddT8qrgzlkzgQTMHrjZn2/r1C/VnT0kkjAFO8= Received: from SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) by SA2PR10MB4508.namprd10.prod.outlook.com (2603:10b6:806:11d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec 2021 14:30:39 +0000 Received: from SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::c4d0:8291:84d:ac66]) by SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::c4d0:8291:84d:ac66%7]) with mapi id 15.20.4734.027; Wed, 1 Dec 2021 14:30:39 +0000 From: Liam Howlett To: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton CC: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Peter Zijlstra , Michel Lespinasse , Jerome Glisse , Minchan Kim , Joel Fernandes , Rom Lemarchand , Liam Howlett Subject: [PATCH v4 49/66] bpf: Remove VMA linked list Thread-Topic: [PATCH v4 49/66] bpf: Remove VMA linked list Thread-Index: AQHX5r/zsqb9vHBNtU608kZJnpd2mg== Date: Wed, 1 Dec 2021 14:30:12 +0000 Message-ID: <20211201142918.921493-50-Liam.Howlett@oracle.com> References: <20211201142918.921493-1-Liam.Howlett@oracle.com> In-Reply-To: <20211201142918.921493-1-Liam.Howlett@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.30.2 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6a6c9ec5-c44f-45d3-3c2e-08d9b4d725f7 x-ms-traffictypediagnostic: SA2PR10MB4508: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QJ37/u9ZtFn+cypTfXzKV9WRuF8vObpbmERonpK9nIJHzVaC6PzRc5Pt3waea69d22p57mMdA6QNmDjTirK2JrQF3B+Q8X0STm+XHXsYvs/pYDrtKimklM4rzlfaJnhZRYoek6jMks/vh9/LJuJYCFQC5KcKZJtaFB1rCoXfZDW8H3/r4sJM5Ef+KdOt7iD6JTQsMCNzWMKIyKJF+fCYAiszJtY3YXoNg+WD1Pzo7PSAZ4TZZreeAepCyFWMy5uGqbpDMQhPjrQV9YX2GZknpS8/8nCROLBGTAElEfNrmnUejWKiiYtbg79pIHCy3zCN39ShZNb6WFQU/X9XqhJjmRtEUbRfD+Dyo53xHJJ8y5uyX5jo8QH4Maoz5FcEyLr3qWrvURpqV5z9LxM49HgbpGAqVHRImmFwWJ1H9zpjTbiys4Wzo3GK8NpKd8DjSdMpCJJ3kZZXnz0GvB13FNHDbkkUztg8iwlwEM6a7cRXPaG/NryZRG9BhZ72hE2dhpYxfSXqbV9xwEek3Ra4rrvRaz/mTv3JnXdADup8YeRmTjQddGuUAu/fBBFVjvLJk1sPCzNQCdPC9at55JFbLvXq7NHi4pKq4OLcUzQidXhUXi7rDnsoLJUKkcZISqG4ktQp0WYqhtHgzbW3OUJ9NKTb8B09JbzY61ovnZu9MUf6Zv7ZHnf2TBkvk3T6celdTEvR x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB3022.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(26005)(7416002)(1076003)(2906002)(8936002)(54906003)(83380400001)(2616005)(38100700002)(71200400001)(66946007)(86362001)(66446008)(8676002)(6506007)(38070700005)(6512007)(6666004)(122000001)(508600001)(110136005)(6486002)(64756008)(66556008)(76116006)(91956017)(107886003)(316002)(5660300002)(44832011)(36756003)(4326008)(66476007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?b0WCi0f1nakPCOkM9q0NW1f?= =?iso-8859-1?q?BgsnD35E8vityL5bZG0NRf5aLE7Bf7jiCjEYRkRjHbU09aqtllFORkAH30k4?= =?iso-8859-1?q?sntyy03KD61drpuGxY0abGHaQqlenW0dDmpEJlSbROnkPfAwCFpjkMhs/X4+?= =?iso-8859-1?q?32vJio3dH8lonNlnbv27H4I3y9yqoR+1NJPI30GXkEnKVnUHDMiKcWFKwpET?= =?iso-8859-1?q?MmUyYxBIwger7EKI2vU571UGoPcPgywDsa+crQge8eoDhE5AHYYI++seihzN?= =?iso-8859-1?q?uZlQqZqm7yDH9AJmdABKiVaJhHwVSfY4yEfBucX5PSIS5PSxnxEQTE+CegCK?= =?iso-8859-1?q?dDkoMmuDMdzG0AmvScPHSXYWFdpJCVxAiwYPJ/1idNfELpiLWkuvxgffMUOl?= =?iso-8859-1?q?TLfF2ufutYvWE0xg1pw70D9qQ6FWQLSzrtC0/3OX5BozP5BGwfC2/smAFzM7?= =?iso-8859-1?q?w70PDJhCiA0Cz9/5bjW44aSh4wM3JKVrkMdVxzmoqw3GYjMvVKa55K0qdthe?= =?iso-8859-1?q?IacSlX4mYlApkNJxIwhUH0h0vwGoBbjjcTcocbgAlhFam+d9c3bq7buWbrCP?= =?iso-8859-1?q?d+8gjFB/NsCU6x5b4YcvjWPhjcWMkc3ugQyo03vG88k8wwP0bYWEmh1GV2BY?= =?iso-8859-1?q?N8AwhD02Xf+VK5Mu3ZtYRIHP8cJ1iNlvcekG1Z1WQGZB8P5nry5bt4wnzwlW?= =?iso-8859-1?q?CDZOjijlIANFMN5VZxWKS7iFLBzDUeHo6rmTACwnVk42EILsSBmLLunMqtC/?= =?iso-8859-1?q?JMslW7WHGpHykT4RFO3WylwoFSGhMFomI4UI0PQVeuD+vxgAxq3fXCQeN7tE?= =?iso-8859-1?q?E0K523ILPlxn+F5rBm9iVup0yYqLvKt00OV11WidcMp+JonEq+CBRrSqfnBP?= =?iso-8859-1?q?0queakNiZUCfN/Q4CIKm3PA63GOwna+bF3QhVazFizteyEoiDVmYchUNHEqj?= =?iso-8859-1?q?QW/LmhkXJzczisCKCPYG5eDZo/cU/5e8UJoGk/YkoSCgWtkaSyj7wk7Z8F+R?= =?iso-8859-1?q?AJmzQeHrPz/UohlOraDdG1PQzfws7yjJ+AHRvgRPjHc8Y8LmDAVE9oHXhzRy?= =?iso-8859-1?q?xDkTnR9HselHO7BxyNJrGWR7PPZ34QRF+0qmauPu/XfMic0NQAydsZ/chEzs?= =?iso-8859-1?q?MVaHwMf3HEcJPh1bkLQvRffNjGGIzoyqMe2WvYGtO5yn42BAR6pb29EI+Lvz?= =?iso-8859-1?q?9+DULIjhkUc58QBN+1TTgZ7R/1gSrUkBeOWgp8Z5CqWH62Pt/b2bJG72uZnp?= =?iso-8859-1?q?eH7t10X9l/If9ocbXabm/1vBsRREAyt5/fua1rc9JFyQrJRGGjVfo47i+xFL?= =?iso-8859-1?q?E9xJSRxZRHJcKVHPoLt7nnpj78zqd8WYCUq7inoMgdWjgT03rUsXNg/aN7BI?= =?iso-8859-1?q?q9tB7eYtqPkSzZCq29oUj7YSkqiJmQps28+s/TNKk9JQEWAF8dDi8+dGQdO1?= =?iso-8859-1?q?UpPexVm57Lazw4wqm+aRjqpabEI4E0sz2iFzLVFD5biz3vmsDW0wDj9Huytx?= =?iso-8859-1?q?JhYGFlAP8JPjKzMziyX6MbpFNon9fiCzNW4kdlwFDxXFYx0qdlnL+3dTNsKC?= =?iso-8859-1?q?yH3EhwJ6C+fDP2vX43H+N/niFfcBWajcOElKRSTZKv8V8lvJQ+kAXXU5DcRH?= =?iso-8859-1?q?YVE2DX5PH4azQzk6EqI6zbkaRQTsRUAIvxEbXet7DjIJsPPdNuXmIaswhfis?= =?iso-8859-1?q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a6c9ec5-c44f-45d3-3c2e-08d9b4d725f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2021 14:30:12.6558 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Re0KYH+ixES+d+JcQQ/m0EkyTg1og2ISR66HoqW3KFLq7Ig8NqZkDkTGgm6cGuK69mA9+KnvbZ9E/UddDi/RPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4508 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10184 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112010081 X-Proofpoint-ORIG-GUID: f7n75AJnNdZ2TW_feURL8qBdnl1wX2Jn X-Proofpoint-GUID: f7n75AJnNdZ2TW_feURL8qBdnl1wX2Jn X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E287BD0000AB X-Stat-Signature: ywemb16xs8qyn6xwo5755a49a9p5unqg Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=LhiL9NFY; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Re5obKQc; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf20.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=liam.howlett@oracle.com X-HE-Tag: 1638376448-516101 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Liam R. Howlett" Use vma_next() and remove reference to the start of the linked list Signed-off-by: Liam R. Howlett --- kernel/bpf/task_iter.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/kernel/bpf/task_iter.c b/kernel/bpf/task_iter.c index b48750bfba5a..2d964743f1e6 100644 --- a/kernel/bpf/task_iter.c +++ b/kernel/bpf/task_iter.c @@ -299,8 +299,8 @@ struct bpf_iter_seq_task_vma_info { }; enum bpf_task_vma_iter_find_op { - task_vma_iter_first_vma, /* use mm->mmap */ - task_vma_iter_next_vma, /* use curr_vma->vm_next */ + task_vma_iter_first_vma, /* use find_vma() with addr 0 */ + task_vma_iter_next_vma, /* use vma_next() with curr_vma */ task_vma_iter_find_vma, /* use find_vma() to find next vma */ }; @@ -400,24 +400,11 @@ task_vma_seq_get_next(struct bpf_iter_seq_task_vma_info *info) switch (op) { case task_vma_iter_first_vma: - curr_vma = curr_task->mm->mmap; + curr_vma = find_vma(curr_task->mm, 0); break; case task_vma_iter_next_vma: - curr_vma = curr_vma->vm_next; - break; case task_vma_iter_find_vma: - /* We dropped mmap_lock so it is necessary to use find_vma - * to find the next vma. This is similar to the mechanism - * in show_smaps_rollup(). - */ - curr_vma = find_vma(curr_task->mm, info->prev_vm_end - 1); - /* case 1) and 4.2) above just use curr_vma */ - - /* check for case 2) or case 4.1) above */ - if (curr_vma && - curr_vma->vm_start == info->prev_vm_start && - curr_vma->vm_end == info->prev_vm_end) - curr_vma = curr_vma->vm_next; + curr_vma = find_vma(curr_task->mm, curr_vma->vm_end); break; } if (!curr_vma) {