| Message ID | 20220111010302.8864-3-richard.weiyang@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] mm/memcg: use NUMA_NO_NODE to indicate allocation from unspecified node | expand |
On Tue, Jan 11, 2022 at 9:03 AM Wei Yang <richard.weiyang@gmail.com> wrote: > > The parent we get from page_counter is correct, while this is two > different hierarchy. > > Let's retrieve the parent memcg from css.parent just like parent_cs(), > blkcg_parent(), etc. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Thanks.
On Tue 11-01-22 01:03:01, Wei Yang wrote: > The parent we get from page_counter is correct, while this is two > different hierarchy. > > Let's retrieve the parent memcg from css.parent just like parent_cs(), > blkcg_parent(), etc. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Acked-by: Michal Hocko <mhocko@suse.com> > --- > include/linux/memcontrol.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 0c5c403f4be6..12bf443f7b14 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -886,9 +886,7 @@ static inline struct mem_cgroup *lruvec_memcg(struct lruvec *lruvec) > */ > static inline struct mem_cgroup *parent_mem_cgroup(struct mem_cgroup *memcg) > { > - if (!memcg->memory.parent) > - return NULL; > - return mem_cgroup_from_counter(memcg->memory.parent, memory); > + return mem_cgroup_from_css(memcg->css.parent); > } > > static inline bool mem_cgroup_is_descendant(struct mem_cgroup *memcg, > -- > 2.33.1
On Tue, Jan 11, 2022 at 01:03:01AM +0000, Wei Yang wrote: > The parent we get from page_counter is correct, while this is two > different hierarchy. > > Let's retrieve the parent memcg from css.parent just like parent_cs(), > blkcg_parent(), etc. Does it bring any benefits except consistency? > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Reviewed-by: Roman Gushchin <guro@fb.com> Thanks!
On Tue, Jan 11, 2022 at 10:09:52AM -0800, Roman Gushchin wrote: >On Tue, Jan 11, 2022 at 01:03:01AM +0000, Wei Yang wrote: >> The parent we get from page_counter is correct, while this is two >> different hierarchy. >> >> Let's retrieve the parent memcg from css.parent just like parent_cs(), >> blkcg_parent(), etc. > >Does it bring any benefits except consistency? > I am afraid no. >> >> Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > >Reviewed-by: Roman Gushchin <guro@fb.com> > >Thanks!
On Mon, Jan 10, 2022 at 5:03 PM Wei Yang <richard.weiyang@gmail.com> wrote: > > The parent we get from page_counter is correct, while this is two > different hierarchy. > > Let's retrieve the parent memcg from css.parent just like parent_cs(), > blkcg_parent(), etc. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> Reviewed-by: Shakeel Butt <shakeelb@google.com>
diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 0c5c403f4be6..12bf443f7b14 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -886,9 +886,7 @@ static inline struct mem_cgroup *lruvec_memcg(struct lruvec *lruvec) */ static inline struct mem_cgroup *parent_mem_cgroup(struct mem_cgroup *memcg) { - if (!memcg->memory.parent) - return NULL; - return mem_cgroup_from_counter(memcg->memory.parent, memory); + return mem_cgroup_from_css(memcg->css.parent); } static inline bool mem_cgroup_is_descendant(struct mem_cgroup *memcg,
The parent we get from page_counter is correct, while this is two different hierarchy. Let's retrieve the parent memcg from css.parent just like parent_cs(), blkcg_parent(), etc. Signed-off-by: Wei Yang <richard.weiyang@gmail.com> --- include/linux/memcontrol.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)