From patchwork Sat Jan 15 14:41:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shakeel Butt X-Patchwork-Id: 12714397 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED9BAC433EF for ; Sat, 15 Jan 2022 14:42:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F5626B0073; Sat, 15 Jan 2022 09:42:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47D886B0074; Sat, 15 Jan 2022 09:42:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31E066B00CA; Sat, 15 Jan 2022 09:42:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 1B5066B0073 for ; Sat, 15 Jan 2022 09:42:07 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 93BAE8FD09 for ; Sat, 15 Jan 2022 14:42:06 +0000 (UTC) X-FDA: 79032786252.15.C8C48F9 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf07.hostedemail.com (Postfix) with ESMTP id 19E8140002 for ; Sat, 15 Jan 2022 14:42:05 +0000 (UTC) Received: by mail-pg1-f202.google.com with SMTP id j186-20020a636ec3000000b00340c5f3a0cbso3775721pgc.0 for ; Sat, 15 Jan 2022 06:42:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=vQu2YGnyaem/WDCb/1ixVe4jFBzHYp6XDPfE+l97NRQ=; b=RAFTf5fJoVhrySxFeclsltYyb9p2i1twuPM/kLWQ+AFQ0Wh4oUI+8TVolsH83OcqBj nk/EF88RqtYjKHpmjifQ5+xGMnzVLUpYZuKU0LsDwODppMPNL/NusBwFSngJ8jGgVjB4 8Hd8NAsMTlBAIYnqa2CKkW3Z7NYdyLGxFaKkHL7QAwZZWCwTrKtg/74BAqqzr5omvKpG Gcb0uEB9LaPxJouoiwL5DNLazEiRrev8MFAm+lz0ThqXFWJbtWhzyG3h14nKMnNQ6fAD BvCiWA4yTnQnwRCDXK0K2c2Ed5ebeyYF51MrZvkKWbKAx2fSFPVDfmfeAivojQxhkRo5 HlGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=vQu2YGnyaem/WDCb/1ixVe4jFBzHYp6XDPfE+l97NRQ=; b=dAUp7494UWK8+iqsMqwWz3MsuPX7X79B4OLl5a/XwKZrNl4XiImQzJoFd9ubaID+fR SDUNBchBm+97iTyd0kHmRj0EkTaFXeDZ205qRAm7PjCEEGXl3uEk7Np2Vmh7dW2h8S/C gOAyg+6EChAXMhI95zwyrDSuxsjTWroACwWfrgzwEbzrsxmGdLjijPVU7uOatRB7ZKe2 ZUC4NQ5d2+SO1Xzosiba8R0S53iaLw22crezoaBmu2fUn6N5KHBYoUyF58fwbaR/FgZg UWcQjgG72Lud8YxD+fGyeX+6VHd/9ubcyk+ZEr3ug6RgVtlG2jr0ZNXffCaVC44wjMBB U9WQ== X-Gm-Message-State: AOAM530XPorrlzwIOogxa19yLyvyA7ODfNixgzvx7oDtYb6Xqawsj7IP qDEgIDPiqi/5ip5sDUlRRfxTwpsGoUUbWA== X-Google-Smtp-Source: ABdhPJzDJ6OuCMhPiZXw84Q7hz0CXiTS8JIsrrIAXlT+ZM3uGrKf7jUah/OPOJXY4kS0xiWjZNQkDozDXW4OSw== X-Received: from shakeelb.svl.corp.google.com ([2620:15c:2cd:202:5db:c608:dd2d:a4b]) (user=shakeelb job=sendgmr) by 2002:a17:903:41c1:b0:14a:6879:9333 with SMTP id u1-20020a17090341c100b0014a68799333mr14741762ple.36.1642257724752; Sat, 15 Jan 2022 06:42:04 -0800 (PST) Date: Sat, 15 Jan 2022 06:41:50 -0800 Message-Id: <20220115144150.1195590-1-shakeelb@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.34.1.703.g22d0c6ccf7-goog Subject: [PATCH] mpage: remove ineffective __GFP_HIGH flag From: Shakeel Butt To: Alexander Viro , Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Shakeel Butt X-Rspamd-Queue-Id: 19E8140002 X-Stat-Signature: nrjxohm9s75i4rp31s3xqconeczk39h6 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RAFTf5fJ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of 3PN3iYQgKCJcJ81B55C27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--shakeelb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3PN3iYQgKCJcJ81B55C27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--shakeelb.bounces.google.com X-Rspamd-Server: rspam03 X-HE-Tag: 1642257725-272591 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since the commit 8a5c743e308dd ("mm, memcg: use consistent gfp flags during readahead") mpage_alloc is clearing all the flag bits other than bits in GFP_KERNEL internally. Simply remove __GFP_HIGH from the call to mpage_alloc as it is cleared by it. Signed-off-by: Shakeel Butt --- fs/mpage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/mpage.c b/fs/mpage.c index 87f5cfef6caa..477ccc3f3ac3 100644 --- a/fs/mpage.c +++ b/fs/mpage.c @@ -609,7 +609,7 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc, goto out; } bio = mpage_alloc(bdev, blocks[0] << (blkbits - 9), - BIO_MAX_VECS, GFP_NOFS|__GFP_HIGH); + BIO_MAX_VECS, GFP_NOFS); if (bio == NULL) goto confused;