| Message ID | 20220224115933.20154-1-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/oom_kill: remove unneeded is_memcg_oom check | expand |
On Thu, 24 Feb 2022, Miaohe Lin wrote: > oom_cpuset_eligible is always called when !is_memcg_oom. Remove this > unnecessary check. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Acked-by: David Rientjes <rientjes@google.com> This keeps oom_cpuset_eligible() only in the nodemask eligibility business and memcg criteria remains isolated in its own function.
On Thu 24-02-22 19:59:33, Miaohe Lin wrote: > oom_cpuset_eligible is always called when !is_memcg_oom. Remove this > unnecessary check. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Acked-by: Michal Hocko <mhocko@suse.com> Thanks! > --- > mm/oom_kill.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 9fea6d3c1ec7..c70a4330e548 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -122,9 +122,6 @@ static bool oom_cpuset_eligible(struct task_struct *start, > bool ret = false; > const nodemask_t *mask = oc->nodemask; > > - if (is_memcg_oom(oc)) > - return true; > - > rcu_read_lock(); > for_each_thread(start, tsk) { > if (mask) { > -- > 2.23.0
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 9fea6d3c1ec7..c70a4330e548 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -122,9 +122,6 @@ static bool oom_cpuset_eligible(struct task_struct *start, bool ret = false; const nodemask_t *mask = oc->nodemask; - if (is_memcg_oom(oc)) - return true; - rcu_read_lock(); for_each_thread(start, tsk) { if (mask) {
oom_cpuset_eligible is always called when !is_memcg_oom. Remove this unnecessary check. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/oom_kill.c | 3 --- 1 file changed, 3 deletions(-)