From patchwork Fri Mar 4 09:34:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 12768814 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60004C433EF for ; Fri, 4 Mar 2022 09:35:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7213B8D000D; Fri, 4 Mar 2022 04:35:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D0D78D0005; Fri, 4 Mar 2022 04:35:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BEEE8D000D; Fri, 4 Mar 2022 04:35:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 3A5408D0005 for ; Fri, 4 Mar 2022 04:35:10 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id EC760180FF4A4 for ; Fri, 4 Mar 2022 09:35:09 +0000 (UTC) X-FDA: 79206195138.27.2B796B9 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf18.hostedemail.com (Postfix) with ESMTP id 4F6C91C0005 for ; Fri, 4 Mar 2022 09:35:09 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4K92dX2453zbc6c; Fri, 4 Mar 2022 17:30:24 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 17:35:05 +0800 From: Miaohe Lin To: CC: , , , , , , , , , , , , , , , , , , Subject: [PATCH 10/16] mm/migration: remove PG_writeback handle in folio_migrate_flags Date: Fri, 4 Mar 2022 17:34:03 +0800 Message-ID: <20220304093409.25829-11-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220304093409.25829-1-linmiaohe@huawei.com> References: <20220304093409.25829-1-linmiaohe@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4F6C91C0005 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Stat-Signature: jb3cufotrzgrp4nmqsbwiar49ciqgtok X-HE-Tag: 1646386509-260067 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When newfolio reaches here, it's guaranteed that PG_writeback is not set because caller ensures writeback must have been completed. Remove this unneeded check and cleanup the relevant comment. Signed-off-by: Miaohe Lin --- mm/migrate.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index cb970d201147..1de5289a4af0 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -549,18 +549,6 @@ void folio_migrate_flags(struct folio *newfolio, struct folio *folio) if (!folio_test_hugetlb(folio)) folio->private = NULL; - /* - * If any waiters have accumulated on the new page then - * wake them up. - */ - if (folio_test_writeback(newfolio)) - folio_end_writeback(newfolio); - - /* - * PG_readahead shares the same bit with PG_reclaim. The above - * end_page_writeback() may clear PG_readahead mistakenly, so set the - * bit after that. - */ if (folio_test_readahead(folio)) folio_set_readahead(newfolio);