From patchwork Wed Mar 9 01:18:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Waiman Long X-Patchwork-Id: 12774579 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8212C433F5 for ; Wed, 9 Mar 2022 01:18:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 371718D0002; Tue, 8 Mar 2022 20:18:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F8598D0001; Tue, 8 Mar 2022 20:18:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1996D8D0002; Tue, 8 Mar 2022 20:18:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id 031688D0001 for ; Tue, 8 Mar 2022 20:18:44 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 95FDA1828A7E6 for ; Wed, 9 Mar 2022 01:18:43 +0000 (UTC) X-FDA: 79223088126.19.AB34234 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 35CF18000D for ; Wed, 9 Mar 2022 01:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646788722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nV4GRpStkpO5VfL46as7OZwqVIQe7oioYpcS1Mj59Gs=; b=HCWbcUcnMXCvI9ZUFVPnVxIlwMGOyDpaIohTyB2RZ0GpylyjY+yU95XUE51JcjjRwd8unk 3HggBx0N37/LF+wEani1badGJeDpxUvNENHPDHTRps6tfzzo/lsncM7HXX75rlGwl119En +HG4Ob0oy4I12gv31WqrIUYATU1xqf0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-348-h5UvBlBROUqBUVPHHfKu2w-1; Tue, 08 Mar 2022 20:18:39 -0500 X-MC-Unique: h5UvBlBROUqBUVPHHfKu2w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7224D1091DA1; Wed, 9 Mar 2022 01:18:38 +0000 (UTC) Received: from llong.com (unknown [10.22.11.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 930495D98D; Wed, 9 Mar 2022 01:18:34 +0000 (UTC) From: Waiman Long To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Roman Gushchin , Waiman Long Subject: [PATCH-mm v2] mm/list_lru: Optimize memcg_reparent_list_lru_node() Date: Tue, 8 Mar 2022 20:18:24 -0500 Message-Id: <20220309011824.1454619-1-longman@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Rspamd-Queue-Id: 35CF18000D X-Stat-Signature: sdgjje438fmm3wj1hzukboipfda1gy1r X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HCWbcUcn; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf02.hostedemail.com: domain of longman@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=longman@redhat.com X-Rspamd-Server: rspam03 X-HE-Tag: 1646788723-228740 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since commit 2c80cd57c743 ("mm/list_lru.c: fix list_lru_count_node() to be race free"), we are tracking the total number of lru entries in a list_lru_node in its nr_items field. In the case of memcg_reparent_list_lru_node(), there is nothing to be done if nr_items is 0. We don't even need to take the nlru->lock as no new lru entry could be added by a racing list_lru_add() to the draining src_idx memcg at this point. Signed-off-by: Waiman Long Reviewed-by: Roman Gushchin --- mm/list_lru.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/list_lru.c b/mm/list_lru.c index ba76428ceece..c669d87001a6 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -394,6 +394,12 @@ static void memcg_reparent_list_lru_node(struct list_lru *lru, int nid, int dst_idx = dst_memcg->kmemcg_id; struct list_lru_one *src, *dst; + /* + * If there is no lru entry in this nlru, we can skip it immediately. + */ + if (!READ_ONCE(nlru->nr_items)) + return; + /* * Since list_lru_{add,del} may be called under an IRQ-safe lock, * we have to use IRQ-safe primitives here to avoid deadlock.