From patchwork Tue Mar 22 18:22:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 12788902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDB61C433F5 for ; Tue, 22 Mar 2022 18:23:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30D096B0071; Tue, 22 Mar 2022 14:23:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BBF66B0072; Tue, 22 Mar 2022 14:23:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15D026B0074; Tue, 22 Mar 2022 14:23:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 011406B0071 for ; Tue, 22 Mar 2022 14:23:13 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BCB0F1D67 for ; Tue, 22 Mar 2022 18:23:13 +0000 (UTC) X-FDA: 79272844266.11.F3E0DDB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf05.hostedemail.com (Postfix) with ESMTP id 11AA910002E for ; Tue, 22 Mar 2022 18:23:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A8818210E9; Tue, 22 Mar 2022 18:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1647973391; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jKxuo3tSnTqh2UAPL1+VAIp6n+IcAR/qJqwZEPA/Ep0=; b=pejEAflbD21zArvB8wKtKlgVaGQeoKrHBbjaNQ+yMhdLHxpcZ5nSjgpEPiuPF3IwpPCuTN kdOtpj5t1Kj+d0NpiDAtZwrchSIQpMrEws2qmz681mePvSYG9jyO1PXoABxfa1eApIX/gQ v3p8YpFlcSdFbFKNVSoUFV6FpkRp080= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0AF82133B6; Tue, 22 Mar 2022 18:23:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sIFvAQ8UOmLwGwAAMHmgww (envelope-from ); Tue, 22 Mar 2022 18:23:11 +0000 From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Richard Palethorpe , Andrew Morton , Shakeel Butt , Roman Gushchin , Michal Hocko , Vlastimil Babka , "Matthew Wilcox (Oracle)" , Muchun Song , Johannes Weiner , Yang Shi , Suren Baghdasaryan , Tejun Heo , Chris Down Subject: [RFC PATCH] mm: memcg: Do not count memory.low reclaim if it does not happen Date: Tue, 22 Mar 2022 19:22:48 +0100 Message-Id: <20220322182248.29121-1-mkoutny@suse.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=pejEAflb; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf05.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 11AA910002E X-Stat-Signature: n5kaje9g9crnjw4ebkdzor3b5bjnn3zx X-HE-Tag: 1647973392-140412 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This was observed with memcontrol selftest/new LTP test but can be also reproduced in simplified setup of two siblings: `parent .low=50M ` s1 .low=50M .current=50M+ε ` s2 .low=0M .current=50M The expectation is that s2/memory.events:low will be zero under outer reclaimer since no protection should be given to cgroup s2 (even with memory_recursiveprot). However, this does not happen. The apparent reason is that when s1 is considered for (proportional) reclaim the scanned proportion is rounded up to SWAP_CLUSTER_MAX and slightly over-proportional amount is reclaimed. Consequently, when the effective low value of s2 is calculated, it observes unclaimed parent's protection from s1 (ε-SWAP_CLUSTER_MAX in theory) and effectively appropriates it. The effect is slightly regularized protection (workload dependent) between siblings and misreported MEMCG_LOW event when reclaiming s2 with this protection. Fix the behavior by not reporting breached memory.low in such situations. (This affects also setups where all siblings have memory.low=0, parent's memory.events:low will still be non-zero when parent's memory.low is breached but it will be reduced by the events originated in children.) Fixes: 8a931f801340 ("mm: memcontrol: recursive memory.low protection") Reported-by: Richard Palethorpe Link: https://lore.kernel.org/all/20220321101429.3703-1-rpalethorpe@suse.com/ Signed-off-by: Michal Koutný --- include/linux/memcontrol.h | 8 ++++---- mm/vmscan.c | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) Why is this RFC? 1) It changes number of events observed on parent/memory.events:low (especially for truly recursive configs where all children specify memory.low=0). IIUC past discussions about equality of all-zeros and all-infinities, those eagerly reported MEMCG_LOW events (in latter case) were deemed skewing the stats [1]. 2) The observed behavior slightly impacts distribution of parent's memory.low. Constructed example is a passive protected workload in s1 and active in s2 (active ~ counteracts the reclaim with allocations). It could strip protection from s1 one by one (one:=SWAP_CLUSTER_MAX/2^sc.priority). That may be considered both wrong (s1 should have been more protected) or correct s2 deserves protection due to its activity. I don't have (didn't collect) data for this, so I think just masking the false events is sufficient (or independent). [1] https://lore.kernel.org/r/20200221185839.GB70967@cmpxchg.org diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 0abbd685703b..99ac72e00bff 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -626,13 +626,13 @@ static inline bool mem_cgroup_supports_protection(struct mem_cgroup *memcg) } -static inline bool mem_cgroup_below_low(struct mem_cgroup *memcg) +static inline bool mem_cgroup_below_low(struct mem_cgroup *memcg, bool effective) { if (!mem_cgroup_supports_protection(memcg)) return false; - return READ_ONCE(memcg->memory.elow) >= - page_counter_read(&memcg->memory); + return page_counter_read(&memcg->memory) <= (effective ? + READ_ONCE(memcg->memory.elow) : READ_ONCE(memcg->memory.low)); } static inline bool mem_cgroup_below_min(struct mem_cgroup *memcg) @@ -1177,7 +1177,7 @@ static inline void mem_cgroup_calculate_protection(struct mem_cgroup *root, { } -static inline bool mem_cgroup_below_low(struct mem_cgroup *memcg) +static inline bool mem_cgroup_below_low(struct mem_cgroup *memcg, bool effective) { return false; } diff --git a/mm/vmscan.c b/mm/vmscan.c index 59b14e0d696c..3bdb35d6bee6 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3152,7 +3152,7 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc) * If there is no reclaimable memory, OOM. */ continue; - } else if (mem_cgroup_below_low(memcg)) { + } else if (mem_cgroup_below_low(memcg, true)) { /* * Soft protection. * Respect the protection only as long as @@ -3163,7 +3163,8 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc) sc->memcg_low_skipped = 1; continue; } - memcg_memory_event(memcg, MEMCG_LOW); + if (mem_cgroup_below_low(memcg, false)) + memcg_memory_event(memcg, MEMCG_LOW); } reclaimed = sc->nr_reclaimed;