From patchwork Mon Apr 18 20:09:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 12817081 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E68C433F5 for ; Mon, 18 Apr 2022 20:09:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 588908D001C; Mon, 18 Apr 2022 16:09:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 537F28D001A; Mon, 18 Apr 2022 16:09:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 363BB8D001C; Mon, 18 Apr 2022 16:09:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 25EE18D001A for ; Mon, 18 Apr 2022 16:09:18 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 05AFE21EA5 for ; Mon, 18 Apr 2022 20:09:17 +0000 (UTC) X-FDA: 79371089196.16.AE550C9 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by imf14.hostedemail.com (Postfix) with ESMTP id E734C10000E for ; Mon, 18 Apr 2022 20:09:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1650312555; x=1681848555; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=yhFDXspCVXCb5F4JI7NnpbnrX8FzaSIthfXgw7wdyZI=; b=J4sTUKYLoIA+VcieEggaj0m3SUzPFKkLQZr6uLZWp0SBPwEfNSxJzDqL +/XKr+UqsfGVakOVYMvEBNZcmVxe6TMbNs3brmBs8rqXVeEPG42A08Zi5 0N8udQZfOdrLIf3Qjr468Ywge9uwEE2PdiNh7XgDcO3ZxesbJY8xkUrdR k/OKKSmQidK/SrIJ9uHhyptbvstrCuLA5KFSbU2dOaG+RQQMizpK667Mp jqP12iXhs5LCWcvQQIo6TJW6sUTdjsEIE2a375JDnm6bZvju1m56b35VI 2krBnc6WJzNvm74PreHCy11t/KtDLPCmnpD04K9ypM62QyjEbzqLMX50p Q==; X-IronPort-AV: E=Sophos;i="5.90,270,1643644800"; d="scan'208";a="198197451" Received: from mail-bn8nam12lp2170.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.170]) by ob1.hgst.iphmx.com with ESMTP; 19 Apr 2022 04:09:13 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KhBiGt6y9tSazMFpfVHEtnuRaP0uyUecx5M+hJ/ljKvpDw9XYFWlPTBbgSbYXICWqLSNBLEBhGaz1uOhvcwDkum8j5NvPPRpn8z/2eeEBNHQwhgTiorjQBY13xpz5igvRY0CHZAE3oDHRg7CwjuElPfzJDFx1QwVKMuPdu3w+ty0aqFDhiffP0XJ2rd0u3bWc240C3FDiqxXYrIxeUzY9ctq3iH/ai3pOwzg1g1ijVTnCJjwYu7g7ue4643LEoCJJvw7Tdyz0XDnBW8v88EQOWWar7urVxLqADXGVrjzSYRv0f4BckwJlSoboamjgmEehl7HBg+5h/BCkdD5HstgVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HWdpgzDlX9Xj8rx8GPoMj6NCBBTnvqXrYvvH2rZoi3E=; b=GnCWJSTc1ie/u9LSdxwsI2NE9CEkeGW5AF9luazNCpe8BMFGlu1YgueABRz5EG5polRA1WkEvJ3clph4FJD5kRcW9MpieoeMbzE4TsBu5TEfSaZLmjGAJprBf6N6DIm1EGATdsySCCixJgnwy8IN0hUqFYvapWmjRI4x3+zkWPRCyso+T7PBlN0BPKap4lJoxkiDK75Tbz0gXBwN8fqQIi1EwJLUZIjWT0mkrTMACl3q8v5q3N8kZZm+QaFFXY3htMq43MQW61q6njICFsy1swESfPR7UJPhmiRjvunissum5CJuRoNJDW9wOO7yJCnUvlL75xqqlXHcMbSDKpoN5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HWdpgzDlX9Xj8rx8GPoMj6NCBBTnvqXrYvvH2rZoi3E=; b=lFCjHrBEdfG8EG8cM+vYyU4fpvXcqkNwEa25t0XThW2JI1VDEi7BVHMjIbng5TEDTNFkFdlqFTSQiUDmrufcIjKPLADcpB6U1y0TI+gfpA99fn5I0aZ8/AynRxvFb+Q1N6ObY34G6BStcMBDEv+RHjKJnObDTmvFT2Prn78RGiE= Received: from PH0PR04MB7158.namprd04.prod.outlook.com (2603:10b6:510:8::18) by MN2PR04MB7022.namprd04.prod.outlook.com (2603:10b6:208:1eb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Mon, 18 Apr 2022 20:09:12 +0000 Received: from PH0PR04MB7158.namprd04.prod.outlook.com ([fe80::995b:363e:8d1c:49af]) by PH0PR04MB7158.namprd04.prod.outlook.com ([fe80::995b:363e:8d1c:49af%8]) with mapi id 15.20.5164.025; Mon, 18 Apr 2022 20:09:12 +0000 From: Niklas Cassel To: Alexander Viro , Eric Biederman , Kees Cook CC: Greg Ungerer , Mike Frysinger , Damien Le Moal , Niklas Cassel , kernel test robot , "stable@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" Subject: [PATCH] binfmt_flat: fix sparse annotation ordering Thread-Topic: [PATCH] binfmt_flat: fix sparse annotation ordering Thread-Index: AQHYU2ArT/6GP/7pQEy2Uc+2aJ024w== Date: Mon, 18 Apr 2022 20:09:12 +0000 Message-ID: <20220418200834.1501454-1-Niklas.Cassel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.35.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f7a934cc-be16-45a8-b2a3-08da21774e76 x-ms-traffictypediagnostic: MN2PR04MB7022:EE_ x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cI4j8GQfMqevLBxbiOVJFCHc3P7Okd9cGjm2uOhJnZ+JLTmIh32wlIVi3/d+m4/UYFupYUvUoJM/aN81Zpa+popc8J2MD9GC7cX2NAdYchkFatENe/a2vxzattTLJpELrAs/cQI4kSaDp57GBcBHpd0OhXryWKFfjETWGOuQgTGYEpCVTsj+0BP8E4OUB0jUBoQbrHD8a9z2JFQaKweclRyL+pPiloGfuPBiGWUmnhopAgI8SgRlQKNJmI5gWcs3kHfnWmywFfwpTL/W6pplWQpqpvqojKiWCWbd6d29wjJW2RmPrVDNivw2/N+oNM2NYjcMTkscf79+c5iUgm5kuIGY9HipyPoC5qFLLwB6jvdQlpAJ+MPopIg50IVGJ2lnebYH8rvhjfJjTbxSOJOMkvIskUQL2+DFxPNyEcVz7WX0GRRuq63CWaMj1p63HbrNYLQMtfUEF1qimB9nGz7OoHOQdLyaGn/aunvwmT+rN12x/xQAh0gOCA8P7iXNfRmxP0TsZaGp6lAAt5mIeWWk05ZLLUdWsMQu4Bq4hvWejH1TJlcUVpoP8w+l4MN6xhN8ltBLBLp+sNojOujTifw5vsmEf/tMkRPsYujTms3zAIvXThAW7fUrhGhirpXc16b4HxKvBnFazTVc1hTfTTMKtfuUxV0UQ6m3rDjRJmlnayukvR6IJfdFcvSIHQup8CR3xoZXU3Xd6gP6iaKEIZJY2g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR04MB7158.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(110136005)(66556008)(1076003)(186003)(6506007)(2616005)(64756008)(82960400001)(91956017)(66446008)(8676002)(4326008)(38100700002)(5660300002)(36756003)(122000001)(2906002)(86362001)(54906003)(316002)(71200400001)(38070700005)(6512007)(26005)(66946007)(66476007)(6486002)(8936002)(76116006)(508600001)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?wzs6FxtnNYxqERRog1/Fzx6?= =?iso-8859-1?q?e/HozBPQfhNyElIO9m/Ej1xhXVxS1ILSkMsg5qiximkv/PfYdfaW25AVqORn?= =?iso-8859-1?q?RBYJvo2lBwMAlrFfAlXkelovHwRvg1AB9RWKGSe+QYhlj3utAZ1N0TmJ6uh/?= =?iso-8859-1?q?MuVsZG4/9ZibxSx6voK1N03e4qxRK9QcYKBeiZDF+Ue6kT0vw4MNNJCfJ9H3?= =?iso-8859-1?q?TP92Y6NBHQqE7gJYSiFx9F54L0Ok5VohPfVms6eEA5k7G+WA1fGLk2BpI4kr?= =?iso-8859-1?q?rNXXVZvC9F7zoAVYxM0eM75vvvRWAk+fC286RR+loHZAAmTLWsoq8EKT8+K+?= =?iso-8859-1?q?lt2y/79kR3H6SlFE+LPXrvAGk5N92+iL2Uy+BJJ1rw7JqE/rHUhkA9HjDUtz?= =?iso-8859-1?q?WkYJkPb5QQIlZY+aHNDjwJpmZ//BAhmjsJ3Ghq3ZziuTs1Uj2fzRjAn5ZeMB?= =?iso-8859-1?q?xrm4PE9/IfmCn/syH3jPn9JpZGUE8swhqSzN8x32wYwW8IqtEB4vAgP53D3+?= =?iso-8859-1?q?vyn3HQKMqnP7sWWbwzn8gjIgKsfoCNRQbBMeBTBZB7WwG844YReDJPJoUD2d?= =?iso-8859-1?q?aLEl1NvdZrGrDg43g0jX0EWcBIKXWg2cqDfNZ7BE/LIwvdhVqG+RASkFSYYZ?= =?iso-8859-1?q?r4fjjlVtsSaDygKuIiYfI+oOKC5updPWd3ZsbLl8I1C3fvmKOnaUi4r+G6rr?= =?iso-8859-1?q?tkhX702LRJ4OB45CeWMrd+AgyZewPDiQpnAyFXX/8e0q92TA9xUaw6nwXw0k?= =?iso-8859-1?q?5qdi47ebJ9cHGGH6e0lGLLKQUz8Ge/GT81WXqJ0tbdLiw13yAr5XhpoN4hU9?= =?iso-8859-1?q?BnEnks8spQjXlE8SNEpx/Ic7g+6JHWcnvSkebPcVJjFgRaBzKVjD44/obdtD?= =?iso-8859-1?q?hHdAKY6c/X6cQO7/HojReVzeLEer79qkptBZF7B26kI1zkUlAw/bqaatZdxv?= =?iso-8859-1?q?ulFibJ7E7R9DVHsTcd0sbbSICDGivv4peYRtsAUviiAlcdwm2RuO8KX/kvvO?= =?iso-8859-1?q?Xbf93HG5P5wUOd2h7RlszQPSvKinv6ctLQiIhjDqC6mITAqxA+dvuVqfDSpl?= =?iso-8859-1?q?U2Ck1/viIPEBM4i+fR0to9nB25gp6SQIq3fWyaJs4jz72HfEdT0l9owGoGcm?= =?iso-8859-1?q?75R4BBEH6E0QQV0ggMqUR5sDnMCEMlsIAO+8/Ngp2IaBy4eE8Lx9dijL9Tmn?= =?iso-8859-1?q?NQEMgFxF+FrAxK6BU3iyqhMd6+Frxa2kQwPdI/RsW1YguzHb2LKHJPsJdD+o?= =?iso-8859-1?q?3yBm61wEr6AZZ6SFR7lta97XULZPNUwKvh876V6Q9jooyqKkDUyEevn9F4fE?= =?iso-8859-1?q?s9DpSene4QFSK+BUbYcx8j167oe0E0p+0xBUJSzpvC4KrEwzNCStbKvZN3uD?= =?iso-8859-1?q?ZbWbuoIwWN/hQ87JnVCluWs9FfNfJIf4vuSDUSqsVyDIQ3UoD5c6D2Z9YMvR?= =?iso-8859-1?q?jQYZuYHY5JySiQiUo3TTbPyrL7nBfYVTvNvw1qNjxB5NOEMgl4SrJxFbqxUX?= =?iso-8859-1?q?6THrKiZwRseuJnhtgM6JPzWmphaVc/8eXSs5UzbpTEntc6Y4gSKb4juIPjfh?= =?iso-8859-1?q?PPT/FQzgDSdaXw6U9Z+4qVQ/nsszMqBMOI7SC/Qsu3K9RMwAOJVQN9wyyKRu?= =?iso-8859-1?q?rIdi991t9FBbAA2lu4ljFbBBfgshTnSKVgXki7ioEKCnxy5Wz7xndzIRKD6y?= =?iso-8859-1?q?1KYiixxFJGqe18wreSN2hrfsT4M5Bpmt8jgNn/p54rDFy9oj/fjsShTSGqkT?= =?iso-8859-1?q?3fA/t//jL1t1vCkviRrbU/Gs6jubpeasOrFHfxvlYfeZYpXQa+zMaYhalrYe?= =?iso-8859-1?q?zTlMJCec=3D?= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7158.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7a934cc-be16-45a8-b2a3-08da21774e76 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2022 20:09:12.6154 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sqvYWR3G/Z3PnSplhd/2XowTy69ZLxPohVnhLcRSTVcuftBUUuRtk8TN8lAxdahhFHgvTER+GoVrBkBaD+tqcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB7022 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E734C10000E X-Stat-Signature: 5iidhj9ztcc61texre6nmpo6iaebe39c Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=J4sTUKYL; dkim=pass header.d=sharedspace.onmicrosoft.com header.s=selector2-sharedspace-onmicrosoft-com header.b=lFCjHrBE; spf=none (imf14.hostedemail.com: domain of "prvs=100b1adc0=Niklas.Cassel@wdc.com" has no SPF policy when checking 216.71.153.144) smtp.mailfrom="prvs=100b1adc0=Niklas.Cassel@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com X-Rspam-User: X-HE-Tag: 1650312556-711720 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Niklas Cassel The sparse annotation ordering inside the function call is swapped. Fix the ordering so that we silence the following sparse warnings: fs/binfmt_flat.c:816:39: warning: incorrect type in argument 1 (different address spaces) fs/binfmt_flat.c:816:39: expected unsigned int [noderef] [usertype] __user *rp fs/binfmt_flat.c:816:39: got unsigned int [usertype] *[noderef] __user No functional change as sparse annotations are ignored by the compiler. Fixes: a767e6fd68d2 ("binfmt_flat: do not stop relocating GOT entries prematurely on riscv") Reported-by: kernel test robot Signed-off-by: Niklas Cassel Cc: --- Hello Kees, Sorry about this. Feel free to squash it with the existing patch if you so like. fs/binfmt_flat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index e5e2a03b39c1..dca0b6875f9c 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -813,7 +813,7 @@ static int load_flat_file(struct linux_binprm *bprm, * image. */ if (flags & FLAT_FLAG_GOTPIC) { - rp = skip_got_header((u32 * __user) datapos); + rp = skip_got_header((u32 __user *) datapos); for (; ; rp++) { u32 addr, rp_val; if (get_user(rp_val, rp))