From patchwork Thu Apr 21 07:06:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anshuman Khandual X-Patchwork-Id: 12821174 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C8BDC433EF for ; Thu, 21 Apr 2022 07:05:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4ADF6B0078; Thu, 21 Apr 2022 03:05:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFA376B007B; Thu, 21 Apr 2022 03:05:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE91B6B007D; Thu, 21 Apr 2022 03:05:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id AC1CF6B0078 for ; Thu, 21 Apr 2022 03:05:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 6BEC71206C4 for ; Thu, 21 Apr 2022 07:05:53 +0000 (UTC) X-FDA: 79380001386.23.3DDB22D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 2739B20019 for ; Thu, 21 Apr 2022 07:05:51 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 00E561477; Thu, 21 Apr 2022 00:05:52 -0700 (PDT) Received: from a077893.arm.com (unknown [10.163.40.213]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9DF153F73B; Thu, 21 Apr 2022 00:05:49 -0700 (PDT) From: Anshuman Khandual To: linux-mm@kvack.org Cc: Anshuman Khandual , Pasha Tatashin , Andrew Morton , linux-kernel@vger.kernel.org Subject: [PATCH V2] mm/page_table_check: Drop all redundant EXPORT_SYMBOL() Date: Thu, 21 Apr 2022 12:36:31 +0530 Message-Id: <20220421070631.1273879-1-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2739B20019 X-Stat-Signature: 6rrsmfx6c1de9i9raczb4qqrc8xm4jqj Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-HE-Tag: 1650524751-395812 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Function definitions need not be exported via EXPORT_SYMBOL() mechanism. In this case these functions just get called only inside their wrappers. Even __page_table_check_zero() gets called without such an export. Just drop all these redundant EXPORT_SYMBOL(). Cc: Pasha Tatashin Cc: Andrew Morton Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual Acked-by: Pasha Tatashin --- This applies on v5.18-rc3 Changes in V2: - Restored EXPORT_SYMBOL for __page_table_check_pte_set() per Pasha mm/page_table_check.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/page_table_check.c b/mm/page_table_check.c index 2458281bff89..627c5025d786 100644 --- a/mm/page_table_check.c +++ b/mm/page_table_check.c @@ -167,7 +167,6 @@ void __page_table_check_pte_clear(struct mm_struct *mm, unsigned long addr, PAGE_SIZE >> PAGE_SHIFT); } } -EXPORT_SYMBOL(__page_table_check_pte_clear); void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, pmd_t pmd) @@ -180,7 +179,6 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, PMD_PAGE_SIZE >> PAGE_SHIFT); } } -EXPORT_SYMBOL(__page_table_check_pmd_clear); void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, pud_t pud) @@ -193,7 +191,6 @@ void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, PUD_PAGE_SIZE >> PAGE_SHIFT); } } -EXPORT_SYMBOL(__page_table_check_pud_clear); void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, pte_t *ptep, pte_t pte) @@ -223,7 +220,6 @@ void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr, pmd_write(pmd)); } } -EXPORT_SYMBOL(__page_table_check_pmd_set); void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr, pud_t *pudp, pud_t pud) @@ -238,7 +234,6 @@ void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr, pud_write(pud)); } } -EXPORT_SYMBOL(__page_table_check_pud_set); void __page_table_check_pte_clear_range(struct mm_struct *mm, unsigned long addr,