From patchwork Tue May 10 20:32:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Shi X-Patchwork-Id: 12845498 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D11DDC4332F for ; Tue, 10 May 2022 20:32:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 725038D0005; Tue, 10 May 2022 16:32:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DA6B8D0002; Tue, 10 May 2022 16:32:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54C748D0005; Tue, 10 May 2022 16:32:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 44CB58D0002 for ; Tue, 10 May 2022 16:32:44 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 25CF921BBB for ; Tue, 10 May 2022 20:32:44 +0000 (UTC) X-FDA: 79450981848.21.9F0D9D8 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf22.hostedemail.com (Postfix) with ESMTP id 16F78C00A0 for ; Tue, 10 May 2022 20:32:41 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id d22so17767701plr.9 for ; Tue, 10 May 2022 13:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xGfl4tySzp7alFhccaOml+d9CvpyhEwjlT3yjUxnaGM=; b=oyecuH2qIUB2Fn7kgYRrw4VNjuLMH1LgyyzcuskJbpv8K9b50xQtbfsaLyDw3vNr8k hf15D+OK5TZyzPRGlLajNp2rk62uDJVZoJ/UjCpnCJOTFJ5anwCkL62If8oZuGpdxwbU ZXZKM8ZaedmGH2PUnAdMMvryrgVR0WMJlE3Q8flaehfjvIYFjYpHBoERbn+dzRBJhz/M aegxNq59fonJxoX8M1jRfKm4h9CmToH9D+wDA2rZW8mIeE8uWpNyunVz843kyWjA9bzh xLuQ+hcfovSLXMruI2t9LA3BXkGXshZy6KfcstL05HopjRCl9obBYfeFu+fsrSpGKKBj QtIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xGfl4tySzp7alFhccaOml+d9CvpyhEwjlT3yjUxnaGM=; b=cwG4ky5N1f4yPOfbjVj2Kt9Aa/k/XwnC8w8p8MkJAuO/FpkD2QASC5EnTDiPxUwaO7 tAMCch++2N9CtkU2I2kjfuItruibIIu0c1tRwp5BFS3dd3DJvogmd9oCgA9cgHMLNZ8M XYaPeoh7a6q9OxPfV1FCT5Y/jc5ot9bg8kajicQ/SFleGmclDb7PV0iIs6iescukgFzn DlbMozcdpS8mCaWC+bIR8t8TjmRaj/T4fr4m1xVUtgLaJ6GT1G13UC9R8SO6qDxB4TDF j/UVUmiZgviOX6mi+zBI5iqGPGDNYzyAFF4nsBpad0Fhdn8V9mK7k0nSg2pnKgQ6DtHK FZQg== X-Gm-Message-State: AOAM532T5tRqhhA128I4rlNOPI9tM1/g2NGmK8Ff6ueOcDCvE53Imy7r GSFJEBelKtnGLNabIPtGU80= X-Google-Smtp-Source: ABdhPJyViXcJ5aaAcoYE0zU3KvjlbGjVfyBwnobcIlCyWD1xAGHGjKSFQ99xQcrrqlIdbgCnn9NMRg== X-Received: by 2002:a17:90b:35cb:b0:1dc:7905:c4c1 with SMTP id nb11-20020a17090b35cb00b001dc7905c4c1mr1630769pjb.95.1652214762733; Tue, 10 May 2022 13:32:42 -0700 (PDT) Received: from localhost.localdomain (c-67-174-241-145.hsd1.ca.comcast.net. [67.174.241.145]) by smtp.gmail.com with ESMTPSA id v17-20020a1709028d9100b0015e8d4eb1d4sm58898plo.30.2022.05.10.13.32.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 13:32:42 -0700 (PDT) From: Yang Shi To: vbabka@suse.cz, kirill.shutemov@linux.intel.com, linmiaohe@huawei.com, songliubraving@fb.com, riel@surriel.com, willy@infradead.org, ziy@nvidia.com, tytso@mit.edu, akpm@linux-foundation.org Cc: shy828301@gmail.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [v4 PATCH 3/8] mm: khugepaged: skip DAX vma Date: Tue, 10 May 2022 13:32:17 -0700 Message-Id: <20220510203222.24246-4-shy828301@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20220510203222.24246-1-shy828301@gmail.com> References: <20220510203222.24246-1-shy828301@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 16F78C00A0 X-Stat-Signature: 16tuio3bir3e9u61c9qqducjzdcboadb X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oyecuH2q; spf=pass (imf22.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1652214761-171813 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The DAX vma may be seen by khugepaged when the mm has other khugepaged suitable vmas. So khugepaged may try to collapse THP for DAX vma, but it will fail due to page sanity check, for example, page is not on LRU. So it is not harmful, but it is definitely pointless to run khugepaged against DAX vma, so skip it in early check. Reviewed-by: Miaohe Lin Acked-by: Song Liu Acked-by: Vlastmil Babka Signed-off-by: Yang Shi --- mm/khugepaged.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index dc8849d9dde4..a2380d88c3ea 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -447,6 +447,10 @@ static bool hugepage_vma_check(struct vm_area_struct *vma, if (vm_flags & VM_NO_KHUGEPAGED) return false; + /* Don't run khugepaged against DAX vma */ + if (vma_is_dax(vma)) + return false; + if (vma->vm_file && !IS_ALIGNED((vma->vm_start >> PAGE_SHIFT) - vma->vm_pgoff, HPAGE_PMD_NR)) return false;