From patchwork Mon May 30 02:20:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 12864282 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 417F2C433EF for ; Mon, 30 May 2022 02:20:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 605908D0002; Sun, 29 May 2022 22:20:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B0948D0001; Sun, 29 May 2022 22:20:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A0C48D0002; Sun, 29 May 2022 22:20:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3DDFE8D0001 for ; Sun, 29 May 2022 22:20:39 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0821F209C1 for ; Mon, 30 May 2022 02:20:39 +0000 (UTC) X-FDA: 79520805798.07.345DF54 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf05.hostedemail.com (Postfix) with ESMTP id 612A0100044 for ; Mon, 30 May 2022 02:20:05 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id a10so407627pju.3 for ; Sun, 29 May 2022 19:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iSUIiTx06ZERM+GKjNo7mEfUI96cbNfNRpNUyOJxVbw=; b=S9dIeOW/SSwI/GwIi6mZhRw0z049GzAk4xXrjDc2cqWoLQTSdpxbVXfo27Q0GIqgZq cFIKJFAjhKtARCcqlnJoL8+2P/4uzOZj7N8O+6KO7jEYwmYGj0WccqEJB5lLG5fiheLw kciJw4jlRP75b514zThNHbZjytgaPa7TkCW+2RH2WhaxdXOrBmYNIj3Dt3pDKa6aMuuN 6DxUT6XV+LfRZ3/Av3ieogsztDo17h6OSV/dkUspznWWKQ3fKXNKXPL0VXpCdZwARsdX wmI47fH77ypiaOSEYqcwHBc0V9Jv3bWoJjEXfCUaSof2HQTkpb27wySM7+9DQYnqDZbj vKxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iSUIiTx06ZERM+GKjNo7mEfUI96cbNfNRpNUyOJxVbw=; b=rie1HAWHjC52njp0h2qwAY+DCWzfJ8eFaZyeqB1zUZfGsxmcK6nCKlClRZ8MxvD0RA lvp8RKp9S6pwzhNPKJauFbCvm69czlL4+CD2tKlBhQtaYZ/DDszKPPewa7cBeYz3qd0b VGfGGywfrZdjO7wEBUY74ttGlNkRi4YvmZWO+kw4wbRvdiSEOIfYjo3J6N7fDHePs/od 9sMoPqrmmIIZZyyWzNkxt4cxOngPiOuOtuzlSgMKR4XTXfjDjGeRuW94ffYY3eBFXgfV HjsaVTONMPpl23jwRzdh0G9kbKWZBBlMpQF1hJnwI3SwrdTHraC2+A8wAWcJINGf2tJB 7y6w== X-Gm-Message-State: AOAM531iNODKtzgMC7or44ennxinnXe39/Wk7iAd+k8GTbnRUphraSyX hOYLBVaHMVkGXTFbA+8XKggurA== X-Google-Smtp-Source: ABdhPJyyTTZFpomnyQsisyztLTQlc2LMObRARpACojyemYKaITviTQ0rcuZseaH8bYaoKPBMSzsmgg== X-Received: by 2002:a17:903:41cb:b0:161:dd9c:bed2 with SMTP id u11-20020a17090341cb00b00161dd9cbed2mr52765762ple.138.1653877236645; Sun, 29 May 2022 19:20:36 -0700 (PDT) Received: from C02CV1DAMD6P.bytedance.net ([139.177.225.237]) by smtp.gmail.com with ESMTPSA id g1-20020a170902868100b0015e8d4eb25fsm4235738plo.169.2022.05.29.19.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 May 2022 19:20:36 -0700 (PDT) From: Chengming Zhou To: sj@kernel.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou Subject: [PATCH] mm/damon: remove obsolete comments of kdamond_stop Date: Mon, 30 May 2022 10:20:16 +0800 Message-Id: <20220530022016.11771-1-zhouchengming@bytedance.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="S9dIeOW/"; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf05.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 612A0100044 X-Stat-Signature: 1ynqpmz3gzos8iuupa7hpjzgyy9cufdz X-HE-Tag: 1653877205-675689 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since commit 0f91d13366a4 ("mm/damon: simplify stop mechanism") delete kdamond_stop and change to use kthread stop mechanism, these obsolete comments should be removed accordingly. Signed-off-by: Chengming Zhou Reviewed-by: SeongJae Park Acked-by: Muchun Song --- include/linux/damon.h | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 7c62da31ce4b..fa1c2968b1dd 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -397,7 +397,6 @@ struct damon_callback { * detail. * * @kdamond: Kernel thread who does the monitoring. - * @kdamond_stop: Notifies whether kdamond should stop. * @kdamond_lock: Mutex for the synchronizations with @kdamond. * * For each monitoring context, one kernel thread for the monitoring is @@ -406,14 +405,14 @@ struct damon_callback { * Once started, the monitoring thread runs until explicitly required to be * terminated or every monitoring target is invalid. The validity of the * targets is checked via the &damon_operations.target_valid of @ops. The - * termination can also be explicitly requested by writing non-zero to - * @kdamond_stop. The thread sets @kdamond to NULL when it terminates. - * Therefore, users can know whether the monitoring is ongoing or terminated by - * reading @kdamond. Reads and writes to @kdamond and @kdamond_stop from - * outside of the monitoring thread must be protected by @kdamond_lock. - * - * Note that the monitoring thread protects only @kdamond and @kdamond_stop via - * @kdamond_lock. Accesses to other fields must be protected by themselves. + * termination can also be explicitly requested by calling __damon_stop(). + * The thread sets @kdamond to NULL when it terminates. Therefore, users can + * know whether the monitoring is ongoing or terminated by reading @kdamond. + * Reads and writes to @kdamond from outside of the monitoring thread must + * be protected by @kdamond_lock. + * + * Note that the monitoring thread protects only @kdamond via @kdamond_lock. + * Accesses to other fields must be protected by themselves. * * @ops: Set of monitoring operations for given use cases. * @callback: Set of callbacks for monitoring events notifications.