From patchwork Mon Jun 6 03:45:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Wandun X-Patchwork-Id: 12869907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A242DC43334 for ; Mon, 6 Jun 2022 03:25:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E38548D0003; Sun, 5 Jun 2022 23:25:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC31A8D0001; Sun, 5 Jun 2022 23:25:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5EFA8D0003; Sun, 5 Jun 2022 23:25:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B61EF8D0001 for ; Sun, 5 Jun 2022 23:25:03 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8EA502031F for ; Mon, 6 Jun 2022 03:25:03 +0000 (UTC) X-FDA: 79546369686.11.F6520DF Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf14.hostedemail.com (Postfix) with ESMTP id 34F1E10004B for ; Mon, 6 Jun 2022 03:25:02 +0000 (UTC) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LGf2K3qn5z1K9CB; Mon, 6 Jun 2022 11:23:05 +0800 (CST) Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 6 Jun 2022 11:24:51 +0800 Received: from localhost.localdomain (10.175.112.125) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 6 Jun 2022 11:24:50 +0800 From: Chen Wandun To: , , , , , , CC: Subject: [PATCH v3 1/3] mm/shmem: check return value of shmem_init_inodecache Date: Mon, 6 Jun 2022 11:45:28 +0800 Message-ID: <20220606034530.153505-2-chenwandun@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220606034530.153505-1-chenwandun@huawei.com> References: <20220606034530.153505-1-chenwandun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected X-Stat-Signature: wb8qwb4qmys5m5upbgyp9whag9cpqebt Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of chenwandun@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=chenwandun@huawei.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 34F1E10004B X-HE-Tag: 1654485902-152508 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It will result in null pointer access if shmem_init_inodecache fail, so check return value of shmem_init_inodecache Signed-off-by: Chen Wandun --- mm/shmem.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 12d45a03f7fc..7419ab219b97 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3775,11 +3775,16 @@ static void shmem_init_inode(void *foo) inode_init_once(&info->vfs_inode); } -static void shmem_init_inodecache(void) +static int shmem_init_inodecache(void) { shmem_inode_cachep = kmem_cache_create("shmem_inode_cache", sizeof(struct shmem_inode_info), 0, SLAB_PANIC|SLAB_ACCOUNT, shmem_init_inode); + + if (!shmem_inode_cachep) + return -ENOMEM; + + return 0; } static void shmem_destroy_inodecache(void) @@ -3923,7 +3928,9 @@ void __init shmem_init(void) { int error; - shmem_init_inodecache(); + error = shmem_init_inodecache(); + if (error) + goto out2; error = register_filesystem(&shmem_fs_type); if (error) {