| Message ID | 20220609040132.89192-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm, slab: fix bad alignments | expand |
On Thu, Jun 09, 2022 at 12:01:32PM +0800, Jiapeng Chong wrote: > As reported by coccicheck: > > ./mm/slab.c:3253:2-59: code aligned with following code on line 3255. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > mm/slab.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index 47151fb2b2d2..c359c0f2c897 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -3223,7 +3223,7 @@ slab_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid, size_t orig_ > } > /* ___cache_alloc_node can fall back to other nodes */ > ptr = ____cache_alloc_node(cachep, flags, nodeid); > - out: > +out: > local_irq_restore(save_flags); > ptr = cache_alloc_debugcheck_after(cachep, flags, ptr, caller); > init = slab_want_init_on_alloc(flags, cachep); > @@ -3252,7 +3252,7 @@ __do_cache_alloc(struct kmem_cache *cache, gfp_t flags) > if (!objp) > objp = ____cache_alloc_node(cache, flags, numa_mem_id()); > > - out: > +out: > return objp; > } > #else > -- > 2.20.1.7.g153144c Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
On Thu, 9 Jun 2022, Jiapeng Chong wrote: > As reported by coccicheck: > > ./mm/slab.c:3253:2-59: code aligned with following code on line 3255. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Acked-by: David Rientjes <rientjes@google.com>
On Thu, Jun 09, 2022 at 12:01:32PM +0800, Jiapeng Chong wrote: > As reported by coccicheck: > > ./mm/slab.c:3253:2-59: code aligned with following code on line 3255. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Thanks.
On 6/9/22 06:01, Jiapeng Chong wrote: > As reported by coccicheck: > > ./mm/slab.c:3253:2-59: code aligned with following code on line 3255. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Thanks, added to slab/for-5.20/trivial > --- > mm/slab.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index 47151fb2b2d2..c359c0f2c897 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -3223,7 +3223,7 @@ slab_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid, size_t orig_ > } > /* ___cache_alloc_node can fall back to other nodes */ > ptr = ____cache_alloc_node(cachep, flags, nodeid); > - out: > +out: > local_irq_restore(save_flags); > ptr = cache_alloc_debugcheck_after(cachep, flags, ptr, caller); > init = slab_want_init_on_alloc(flags, cachep); > @@ -3252,7 +3252,7 @@ __do_cache_alloc(struct kmem_cache *cache, gfp_t flags) > if (!objp) > objp = ____cache_alloc_node(cache, flags, numa_mem_id()); > > - out: > +out: > return objp; > } > #else
diff --git a/mm/slab.c b/mm/slab.c index 47151fb2b2d2..c359c0f2c897 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -3223,7 +3223,7 @@ slab_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid, size_t orig_ } /* ___cache_alloc_node can fall back to other nodes */ ptr = ____cache_alloc_node(cachep, flags, nodeid); - out: +out: local_irq_restore(save_flags); ptr = cache_alloc_debugcheck_after(cachep, flags, ptr, caller); init = slab_want_init_on_alloc(flags, cachep); @@ -3252,7 +3252,7 @@ __do_cache_alloc(struct kmem_cache *cache, gfp_t flags) if (!objp) objp = ____cache_alloc_node(cache, flags, numa_mem_id()); - out: +out: return objp; } #else
As reported by coccicheck: ./mm/slab.c:3253:2-59: code aligned with following code on line 3255. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- mm/slab.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)