From patchwork Tue Jun 28 13:28:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 12898291 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19D0CC433EF for ; Tue, 28 Jun 2022 13:28:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 866D18E0006; Tue, 28 Jun 2022 09:28:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F0138E0007; Tue, 28 Jun 2022 09:28:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CEA68E0006; Tue, 28 Jun 2022 09:28:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3E9B18E0007 for ; Tue, 28 Jun 2022 09:28:46 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 06E5A12054C for ; Tue, 28 Jun 2022 13:28:46 +0000 (UTC) X-FDA: 79627724652.09.1493B4E Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf15.hostedemail.com (Postfix) with ESMTP id 656A4A000E for ; Tue, 28 Jun 2022 13:28:45 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LXQPR5TZ2zkWy6; Tue, 28 Jun 2022 21:27:23 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 28 Jun 2022 21:28:42 +0800 From: Miaohe Lin To: CC: , , , , , , Subject: [PATCH v2 09/16] mm/huge_memory: fix comment in zap_huge_pud Date: Tue, 28 Jun 2022 21:28:28 +0800 Message-ID: <20220628132835.8925-10-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220628132835.8925-1-linmiaohe@huawei.com> References: <20220628132835.8925-1-linmiaohe@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656422925; a=rsa-sha256; cv=none; b=LwqOf8Y0/NPWmzjlgcJIUmlIYJqfnmDn+Tf7B9p05elljxgNHHGxExKW5amSUA76vMKeej W1uv1AtpYtJK2RMdeP9QmVnP7KjpukdFydJbuW7rW9MUUZvs+Sl2MsIOKlIs00O2uRtE8o RJdpf+ZiLZDXeUxe0uDLiVSdVgr6nkg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656422925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ii6YAGgldx2YHIsjkoj0tyH3l00Uc1wyqKPBff0VP58=; b=q8PozOW5k60VH++1B3u3E29W5JpVv+ts2lYIZoibnJXc/bGYj2kmvmJzqfJ2HKZDW3dmYz alVhgietrQwCsbF/IEizEJNk/X+DpcO3JDBjCn9rzE8hrsHiIcxbT0cTuF5EQTVE8yBvc2 HOCsDiZLLK5ObTxGn5VNi+W1fO3yEXg= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 656A4A000E Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Stat-Signature: 3dhmj66oek1qu5hhnzrr1dkhqj4oo566 X-HE-Tag: 1656422925-851674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The comment about deposited pgtable is borrowed from zap_huge_pmd but there's no deposited pgtable stuff for huge pud in zap_huge_pud. Remove it to avoid confusion. Signed-off-by: Miaohe Lin --- mm/huge_memory.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 7570e7681f95..b0fc3c560245 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2013,12 +2013,7 @@ int zap_huge_pud(struct mmu_gather *tlb, struct vm_area_struct *vma, ptl = __pud_trans_huge_lock(pud, vma); if (!ptl) return 0; - /* - * For architectures like ppc64 we look at deposited pgtable - * when calling pudp_huge_get_and_clear. So do the - * pgtable_trans_huge_withdraw after finishing pudp related - * operations. - */ + pudp_huge_get_and_clear_full(tlb->mm, addr, pud, tlb->fullmm); tlb_remove_pud_tlb_entry(tlb, pud, addr); if (vma_is_special_huge(vma)) {