From patchwork Tue Jun 28 13:28:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 12898299 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B130EC43334 for ; Tue, 28 Jun 2022 13:29:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 312728E000C; Tue, 28 Jun 2022 09:28:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22DE48E0010; Tue, 28 Jun 2022 09:28:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D73138E000D; Tue, 28 Jun 2022 09:28:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 98D808E000C for ; Tue, 28 Jun 2022 09:28:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 766C1606EF for ; Tue, 28 Jun 2022 13:28:49 +0000 (UTC) X-FDA: 79627724778.19.0B909F4 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf08.hostedemail.com (Postfix) with ESMTP id C4E8E16002F for ; Tue, 28 Jun 2022 13:28:48 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LXQNP5pndz1L8h8; Tue, 28 Jun 2022 21:26:29 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 28 Jun 2022 21:28:44 +0800 From: Miaohe Lin To: CC: , , , , , , Subject: [PATCH v2 13/16] mm/huge_memory: fix comment of page_deferred_list Date: Tue, 28 Jun 2022 21:28:32 +0800 Message-ID: <20220628132835.8925-14-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220628132835.8925-1-linmiaohe@huawei.com> References: <20220628132835.8925-1-linmiaohe@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656422929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sB8Nv4dJ90LSK9KQiH8MPKFX6BaimpU4TGSajNrvRNo=; b=Bnvc4CbmyBCDxTLurZ74QXFH95nuxbVAmigsP0rrNb/I6NtHKP4yERtsCpx/uF8whybofW GIg0kgVRH3dAObAaJ0UM0f/vmDvRVt7b3y7gyx2s0Vvr7bRJJh1RafGRcbnrGqdvCgs3N7 CfvzEKefof1DDTAL8PeuvWU4wXbSJaw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656422929; a=rsa-sha256; cv=none; b=sa1cisHHvAIms1NhzgkSX3eivOTpfqbyfX/D6qlBlAwMQzSqHua+IBxbwsI7ftsaeGZLua tBBkAUwuZeBBMX8RJVJv0mZ9reXvnM8d64HsYaNJjClZNyG+DHwqUuFEPi7Tp62B072Ggx 53uPKKSCw4lMUt6J4ZbVOBQuaFVtQnM= X-Stat-Signature: rd3timkih87e9wm3bcppoitjoqqxoo5c X-Rspamd-Queue-Id: C4E8E16002F X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam12 X-HE-Tag: 1656422928-452015 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The current comment is confusing because if global or memcg deferred list in the second tail page is occupied by compound_head, why we still use page[2].deferred_list here? I think it wants to say that Global or memcg deferred list in the first tail page is occupied by compound_mapcount and compound_pincount so we use the second tail page's deferred_list instead. Signed-off-by: Miaohe Lin --- include/linux/huge_mm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 12b297f9951d..37f2f11a6d7e 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -294,8 +294,8 @@ static inline bool thp_migration_supported(void) static inline struct list_head *page_deferred_list(struct page *page) { /* - * Global or memcg deferred list in the second tail pages is - * occupied by compound_head. + * See organization of tail pages of compound page in + * "struct page" definition. */ return &page[2].deferred_list; }