diff mbox series

[v2,16/16] mm/huge_memory: use helper macro IS_ERR_OR_NULL in split_huge_pages_pid

Message ID 20220628132835.8925-17-linmiaohe@huawei.com (mailing list archive)
State New
Headers show
Series A few cleanup patches for huge_memory | expand

Commit Message

Miaohe Lin June 28, 2022, 1:28 p.m. UTC 
Use helper macro IS_ERR_OR_NULL to check the validity of page to simplify
the code. Minor readability improvement.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/huge_memory.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Muchun Song June 28, 2022, 2:54 p.m. UTC | #1 
On Tue, Jun 28, 2022 at 09:28:35PM +0800, Miaohe Lin wrote:
> Use helper macro IS_ERR_OR_NULL to check the validity of page to simplify
> the code. Minor readability improvement.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.
diff mbox series

Patch

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 1d32349a95f4..b406fe08b2c9 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3057,9 +3057,7 @@  static int split_huge_pages_pid(int pid, unsigned long vaddr_start,
 		/* FOLL_DUMP to ignore special (like zero) pages */
 		page = follow_page(vma, addr, FOLL_GET | FOLL_DUMP | FOLL_LRU);
 
-		if (IS_ERR(page))
-			continue;
-		if (!page)
+		if (IS_ERR_OR_NULL(page))
 			continue;
 
 		if (!is_transparent_hugepage(page))