From patchwork Wed Jul 6 15:58:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 12908261 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2667C43334 for ; Wed, 6 Jul 2022 15:59:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4040E6B0074; Wed, 6 Jul 2022 11:59:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B3786B0075; Wed, 6 Jul 2022 11:59:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23B426B0078; Wed, 6 Jul 2022 11:59:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 045336B0074 for ; Wed, 6 Jul 2022 11:59:21 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 559326135B for ; Wed, 6 Jul 2022 15:59:20 +0000 (UTC) X-FDA: 79657134480.24.79BA582 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf06.hostedemail.com (Postfix) with ESMTP id B1D64180012 for ; Wed, 6 Jul 2022 15:59:19 +0000 (UTC) Received: by mail-pf1-f169.google.com with SMTP id t3so1576469pfq.10 for ; Wed, 06 Jul 2022 08:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qd0JB5cfMOZXju+WK3uakPtpMzOhhWDX4kTiYeCgPR4=; b=OAKYxyOapwiVgzTm0M/+5qMploaHB8Fd5AKESgyzYGNfYOJJeB4K4JP21u4y4B+vpa 7SmhZLXxe5yo2MMxjE/ynYk0boDbQo4zz1Ylxi37Xn0BNxesNVuydH+Dp2pXV/xmp3YO 5Mpi5ZLtKJSZjuu6L62q4rnJybhOqscs2qKpMIoe3JLsiE/KiSbWWzshVWpLlHy4XUgE mrXaxZFJ7Uh+lZzGOSxqIK1UQdt/crDSYob98tIgK2bdqqQ03tWrE/+swKSPLZseezfA hzBrRwcV3v290BchZUMphrqpIF7zdD7w5gFs5cnNBqTAU7R7c/l7n7r59Tj6khJXHtD1 qeTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qd0JB5cfMOZXju+WK3uakPtpMzOhhWDX4kTiYeCgPR4=; b=naJWI9ax2xj2ID0H8tKbXoWaDohXu7i2E9/f8dLnOrYbs99/ZtTXyuQeCQJ28J2JB0 u6HLJx6XBt927gA2FcI3lOrP1o7paZBX4V0AGVNClKzkfBMrQJprxm6IR9mcV8SHMu/c fNmf/wjkgKpeMaWJGWoyVQs1bPOERRXrfzgZUmDjTi2abs9MobOZgcnAMMFH6kt5LMKh neCk9+TmnroYXH0vfZd4GRd1Qtvaoo/K8hNgr3qj/1yyd1vdTk/WRKPTkQ/qsIvbi+p6 de1bhauhpRZGNAUYQ0DH5+LYCf2hcCX1P1MlTllZdFNvJYTM/lbzarSigLl+RhxolkeV RpXw== X-Gm-Message-State: AJIora+cJi4574W8w926QeNKM09XfxaH9aTTJqFhZBN/Mo0XLjA49oLM M+H8dsWcgNd5y6VsaolLmfQ= X-Google-Smtp-Source: AGRyM1s0QPfTexu7TomygDyRXf/v2uhg7XcmyHXydM9+PAvA7Sj9ccBGowg/XIFXrGeFsdCBeUiHBg== X-Received: by 2002:a63:d94a:0:b0:412:6e04:dc26 with SMTP id e10-20020a63d94a000000b004126e04dc26mr9511132pgj.539.1657123158640; Wed, 06 Jul 2022 08:59:18 -0700 (PDT) Received: from vultr.guest ([2001:19f0:6001:3e22:5400:4ff:fe0f:2b20]) by smtp.gmail.com with ESMTPSA id n17-20020a056a0007d100b0051bada81bc7sm25000125pfu.161.2022.07.06.08.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 08:59:17 -0700 (PDT) From: Yafang Shao To: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, quentin@isovalent.com, roman.gushchin@linux.dev, haoluo@google.com Cc: bpf@vger.kernel.org, linux-mm@kvack.org, Yafang Shao Subject: [PATCH bpf-next v2 2/2] bpf: Warn on non-preallocated case for missed trace types Date: Wed, 6 Jul 2022 15:58:48 +0000 Message-Id: <20220706155848.4939-3-laoar.shao@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220706155848.4939-1-laoar.shao@gmail.com> References: <20220706155848.4939-1-laoar.shao@gmail.com> MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657123159; a=rsa-sha256; cv=none; b=nIE9ENvbKl5mKemQUnz6xJ0eyeCQY5NZlGu+GdfzTEtBGYMUy2ih3z7V99ZuBxMdRoQQUK buosIaV6c0cKcw4J/IambmsKlUwBCLu5Cwjuee3nDIvkNeaA7CeYz581wVCM+z0DJ2JPYL mSntfdjLRwWAftxMbItO90ZRvsg/HfE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=OAKYxyOa; spf=pass (imf06.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657123159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qd0JB5cfMOZXju+WK3uakPtpMzOhhWDX4kTiYeCgPR4=; b=pMuGEtZy36SmSChuJtXWZ4oCJWMGLRAq40O3J14Ji+2vnOyi4bOmVvCOCr8QDpPsjGfixU xrLUQHlIqY/1ztlEk0M4mUZxIE/d+856eHJMW/nP8xk6UCGNSm0Wvqd0487tD6foXDHHIV YrU7PuC9ruDBj9/NR/hki+OUHZ1ebz4= Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=OAKYxyOa; spf=pass (imf06.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 5nft8tq883sa7cdxog853fs5h6g8qp87 X-Rspamd-Queue-Id: B1D64180012 X-HE-Tag: 1657123159-771611 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000093, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE and BPF_PROG_TYPE_TRACING are trace type as well, which may also cause unexpected memory allocation if we set BPF_F_NO_PREALLOC. Let's also warn on both of them. Signed-off-by: Yafang Shao --- kernel/bpf/verifier.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index df3ec6b05f05..f9c0f4889a3a 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -12570,6 +12570,8 @@ static bool is_tracing_prog_type(enum bpf_prog_type type) case BPF_PROG_TYPE_TRACEPOINT: case BPF_PROG_TYPE_PERF_EVENT: case BPF_PROG_TYPE_RAW_TRACEPOINT: + case BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE: + case BPF_PROG_TYPE_TRACING: return true; default: return false;