From patchwork Tue Jul 26 23:02:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Collingbourne X-Patchwork-Id: 12929904 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D90C00144 for ; Tue, 26 Jul 2022 23:03:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BD908E0001; Tue, 26 Jul 2022 19:03:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96D8B6B0072; Tue, 26 Jul 2022 19:03:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85C488E0001; Tue, 26 Jul 2022 19:03:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7689E6B0071 for ; Tue, 26 Jul 2022 19:03:01 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4D6D0120B02 for ; Tue, 26 Jul 2022 23:03:01 +0000 (UTC) X-FDA: 79730778162.21.678DA2E Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf03.hostedemail.com (Postfix) with ESMTP id A8ECE200AF for ; Tue, 26 Jul 2022 23:02:49 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-31f49eea05fso22911007b3.15 for ; Tue, 26 Jul 2022 16:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=v35GRn0zvDL2zuEbUqMrLtilXAspyGM63ZeEqZ8QDmg=; b=OP77iKXmrLhzVFTPiPrlUacZaykc4RXyHfK0/vzLj7Bp94V3TPkG7/YQwQ+7twgLRG HSBXTY9RLK7j+2RjEHFyb1yzZ4i+ahyx1CSpKk17D9r1ncp3Kxdg3gKDMa/pKUbyvKxh EV5bm2LTT0y/gkvgDbUJ2mZwNGIRZ65sb/XWBmFaM6nF9bbDQx8DxvLZ4ApYccS65OcE szfaxpHjgvQeGpiqylZsA67Pi4AtObGZLnSigHp1lQuNUlBpYXwKRMCEsU2dma9u14QB Z5mylSMkQEk+secy2tv5tw5BRvqqXUUEyTl1OPFp8sLLBpKOjptyOfad0wjqxWW6ZihI JveA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=v35GRn0zvDL2zuEbUqMrLtilXAspyGM63ZeEqZ8QDmg=; b=GjnzGA75MWtTC2QYtAQ3BuMCmnrmmk1DNSC54POfbQnJdS5VSBJ6Et/WIdhUvX7rlJ 0ggDh4s63C6KXCmc6tGtX+w1d93NUcLmknID6Hz756nd6/xFHSWycjBQjIqpzZYIrwfs nq3ljcp7dLh9dXXjVmxq7VUVpE+Xb4mq2k2A62t2scQpY6H8nhPYBNG3F45HKNv6riak obkIHHUfQf3C0A0msf0lmK1DVhdHhcGQGBEAlviklYprWKwPreVG/Ps/aA/flHgRaeyS lhaZfOcUwTwg+XnJ59LRe31idRCRu/WVKc5uvL7w0l2Wvujxaf+febZEWrW82ZqTvtE6 RCxA== X-Gm-Message-State: AJIora/GFsg2vm3ik4HazSNQjd9/406VifU2U52Cfghlw8KK5TAnZV5K Vke8Vgt8W0Ms2yaQEG/4h+1DrlY= X-Google-Smtp-Source: AGRyM1u4ckeiReh6RjmBWmrb1wYImuRfgb5zE0QMfvVb8w9SNwArNn6S4Byn0t5cUuOSglUqai2vvIk= X-Received: from pcc-desktop.svl.corp.google.com ([2620:15c:2ce:200:2e88:92fc:be22:6bb1]) (user=pcc job=sendgmr) by 2002:a81:8746:0:b0:31d:c5a6:ad8f with SMTP id x67-20020a818746000000b0031dc5a6ad8fmr17064868ywf.206.1658876568946; Tue, 26 Jul 2022 16:02:48 -0700 (PDT) Date: Tue, 26 Jul 2022 16:02:41 -0700 Message-Id: <20220726230241.3770532-1-pcc@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.1.455.g008518b4e5-goog Subject: [PATCH] mm: add more BUILD_BUG_ONs to gfp_migratetype() From: Peter Collingbourne To: Andrew Morton Cc: Peter Collingbourne , linux-mm@kvack.org, linux-kernel@vger.kernel.org X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A8ECE200AF Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=OP77iKXm; spf=temperror (imf03.hostedemail.com: error in processing during lookup of 3mHLgYgMKCB0I559HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--pcc.bounces.google.com: DNS error) smtp.mailfrom=3mHLgYgMKCB0I559HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--pcc.bounces.google.com X-Stat-Signature: tirfix61rkhqc4dhg3iyzar57nc8o9gy X-Rspam-User: X-HE-Tag: 1658876569-739539 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: gfp_migratetype() also expects GFP_RECLAIMABLE and GFP_MOVABLE|GFP_RECLAIMABLE to be shiftable into MIGRATE_* enum values, so add some more BUILD_BUG_ONs to reflect this assumption. Link: https://linux-review.googlesource.com/id/Iae64e2182f75c3aca776a486b71a72571d66d83e Signed-off-by: Peter Collingbourne --- include/linux/gfp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/gfp.h b/include/linux/gfp.h index f314be58fa77..ea6cb9399152 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -18,6 +18,9 @@ static inline int gfp_migratetype(const gfp_t gfp_flags) VM_WARN_ON((gfp_flags & GFP_MOVABLE_MASK) == GFP_MOVABLE_MASK); BUILD_BUG_ON((1UL << GFP_MOVABLE_SHIFT) != ___GFP_MOVABLE); BUILD_BUG_ON((___GFP_MOVABLE >> GFP_MOVABLE_SHIFT) != MIGRATE_MOVABLE); + BUILD_BUG_ON((___GFP_RECLAIMABLE >> GFP_MOVABLE_SHIFT) != MIGRATE_RECLAIMABLE); + BUILD_BUG_ON(((___GFP_MOVABLE | ___GFP_RECLAIMABLE) >> + GFP_MOVABLE_SHIFT) != MIGRATE_HIGHATOMIC); if (unlikely(page_group_by_mobility_disabled)) return MIGRATE_UNMOVABLE;