diff mbox series

[linux-next] mm: memcontrol: Fix typos in comment Fix a spelling mistake in comment.

Message ID 20220815061208.65945-1-xu.panda@zte.com.cn (mailing list archive)
State New
Headers show
Series [linux-next] mm: memcontrol: Fix typos in comment Fix a spelling mistake in comment. | expand

Commit Message

CGEL Aug. 15, 2022, 6:12 a.m. UTC 
From: xupanda <xu.panda@zte.com.cn>

Reported-by: Zeal Robot <zealic@zte.com.cn>
Signed-off-by: xupanda <xu.panda@zte.com.cn>
Thanks-to: Yang Yang <yang.yang29@zte.com.cn>

---
 mm/memcontrol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Muchun Song Aug. 15, 2022, 6:45 a.m. UTC | #1 
> On Aug 15, 2022, at 14:12, cgel.zte@gmail.com wrote:
> 
> From: xupanda <xu.panda@zte.com.cn>

1. Your subject seems to have redundant description.
   “Fix typos in comment” vs “Fix a spelling mistake in comment"
2. It is better to clarify what you have changed here. Like:

Fix a spelling mistake on “cgruop1”.

With this:

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.
diff mbox series

Patch

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index b69979c9ced5..4dddd8be320a 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1143,7 +1143,7 @@  static void invalidate_reclaim_iterators(struct mem_cgroup *dead_memcg)
 	} while ((memcg = parent_mem_cgroup(memcg)));
 
 	/*
-	 * When cgruop1 non-hierarchy mode is used,
+	 * When cgroup1 non-hierarchy mode is used,
 	 * parent_mem_cgroup() does not walk all the way up to the
 	 * cgroup root (root_mem_cgroup). So we have to handle
 	 * dead_memcg from cgroup root separately.