From patchwork Wed Aug 24 07:07:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: CGEL X-Patchwork-Id: 12952985 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47562C00140 for ; Wed, 24 Aug 2022 07:07:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B13256B0078; Wed, 24 Aug 2022 03:07:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC1786B0075; Wed, 24 Aug 2022 03:07:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96258940007; Wed, 24 Aug 2022 03:07:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 87D486B0074 for ; Wed, 24 Aug 2022 03:07:50 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 59942120831 for ; Wed, 24 Aug 2022 07:07:50 +0000 (UTC) X-FDA: 79833606300.30.737183E Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf14.hostedemail.com (Postfix) with ESMTP id 13927100010 for ; Wed, 24 Aug 2022 07:07:49 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id f21so16190467pjt.2 for ; Wed, 24 Aug 2022 00:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=PXafh5f+pigI8lTygHH0lurdqVrGUMub4Gos5atZnOQ=; b=HsdOV6X0ITgH2yGuQ3b98iiy8QNVcOLPz8ObGnZUz5a7ATRlrUzRTDHNLfsUrNG+qY OP3oKeKkjbewVjarYo1XUABAuOR+w9ye8pTUiHS8fCbP1GZv4J+DJw3HDWOij9WEXSID 1WeLvvlf+oerfF8O8Iu1t/8mHftJVnGAceyjfudLCbcNHuidZJJCa0P9na4ZbABt6DGM WcIB0nGznps1CxEY3SbcdpH6vggWfQCKu+Rh41HIXsDoKAMYyiwHCW4xElaRqIqEXTMB Nuhfuo7VF6KOQqv4cCInEQCUZJP9g2Hjk4QYFxIRRasmj2jD/lQN5nYmfzynHEypu+W+ FWBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=PXafh5f+pigI8lTygHH0lurdqVrGUMub4Gos5atZnOQ=; b=pgJXfR4kXo8FJBbaqd3WEQ2KLMqy1DQC4agIlL6DDyu7eV16dS/ruOZ9JS7tYBdpV2 TQmuKnZUNfjxVMkjrvlqYZOGnyVt0mGeJCDwt16UsQmfS7kv7bA/vU/66IQsX+iSspDV LPdREbNPvZAUviIYPOcalG6RfLMb8FFicwy5CZrsrzYB8MCSRR6mQ7n5o/Q1ncbloBYV rCpOcsG63mNoOWVn3+9Kbf0jz6uSCW7tMsd4EBAYLCvSm99LjnJ7y7NF9amIygvYIdcq yQcz7wzuidejZuGuulSEV5aO5VcrA2F356JRFtcQ0jZqN2Dw5BvsP+I0piSTuD/1S6UZ EjjQ== X-Gm-Message-State: ACgBeo3SkAKlfL/VdbKReUScgnJCjew22At/g/Ft4cGidMEnZSoixM/J QHUGMt8KVsgOaImCQxrzJr0= X-Google-Smtp-Source: AA6agR4pw6w0HuTOmjtqzCYa/gYOpKO0DzmiYndqTYq3H/EuqbX7SSXSaG7zatYXeRMMNAu1UX7Kpg== X-Received: by 2002:a17:90b:3149:b0:1fb:71ad:256b with SMTP id ip9-20020a17090b314900b001fb71ad256bmr4679326pjb.18.1661324869038; Wed, 24 Aug 2022 00:07:49 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id z12-20020aa7948c000000b00535c4b7f1eesm12118187pfk.87.2022.08.24.00.07.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 00:07:48 -0700 (PDT) From: xu xin X-Google-Original-From: xu xin To: akpm@linux-foundation.org, corbet@lwn.net Cc: bagasdotme@gmail.com, adobriyan@gmail.com, willy@infradead.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, xu xin , Xiaokai Ran , Yang Yang , CGEL ZTE Subject: [PATCH v3 1/2] ksm: count allocated ksm rmap_items for each process Date: Wed, 24 Aug 2022 07:07:38 +0000 Message-Id: <20220824070738.220038-1-xu.xin16@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220824070559.219977-1-xu.xin16@zte.com.cn> References: <20220824070559.219977-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661324870; a=rsa-sha256; cv=none; b=4n6tyqLVPni213+M2eej4FVlpinhMiqYJNDfvSu5KY+gfeGpxFAUft2AdPo7uUMsDy0HXk EIltpB5kqrmMDZyM5dP+4oGTTIwcnNNkv5LF1wIO1yStIiegw37MGp7PtrfOriGdFT2CFR Ls8yi1B5gPrqkX7KTlBxnopGm6BAJFU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HsdOV6X0; spf=pass (imf14.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661324870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PXafh5f+pigI8lTygHH0lurdqVrGUMub4Gos5atZnOQ=; b=zz2HcOwmTwhIE7eFrf4WQWPqmNOw6/s9pDuCZaAUS7qXgE78k8MIIxoZQetlW2i9MiUrHN 3V/9FUEshfGlfHe2qon4vNp1tv8/NH9tq70+AeSuD0bd+KAEk2QhQVgURKtrzA9tzFfHyj eGkCbxF3TxqHNQJyaNylv868rBY01s4= X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 13927100010 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HsdOV6X0; spf=pass (imf14.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: cbnxxokb9fh8oq74rjti3ebdfnxgdnd9 X-HE-Tag: 1661324869-154817 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: KSM can save memory by merging identical pages, but also can consume additional memory, because it needs to generate rmap_items to save each scanned page's brief rmap information. Some of these pages may be merged, but some may not be abled to be merged after being checked several times, which are unprofitable memory consumed. The information about whether KSM save memory or consume memory in system-wide range can be determined by the comprehensive calculation of pages_sharing, pages_shared, pages_unshared and pages_volatile. A simple approximate calculation: profit =~ pages_sharing * sizeof(page) - (all_rmap_items) * sizeof(rmap_item); where all_rmap_items equals to the sum of pages_sharing, pages_shared, pages_unshared and pages_volatile. But we cannot calculate this kind of ksm profit inner single-process wide because the information of ksm rmap_item's number of a process is lacked. For user applications, if this kind of information could be obtained, it helps upper users know how beneficial the ksm-policy (like madvise) they are using brings, and then optimize their app code. For example, one application madvise 1000 pages as MERGEABLE, while only a few pages are really merged, then it's not cost-efficient. So we add a new interface /proc//ksm_rmp_items for each process to indicate the total allocated ksm rmap_items of this process. Similarly, we can calculate the ksm profit approximately for a single-process by: profit =~ ksm_merging_pages * sizeof(page) - ksm_rmp_items * sizeof(rmap_item); where ksm_merging_pages and ksm_rmp_items are both under /proc//. Signed-off-by: xu xin Reviewed-by: Xiaokai Ran Reviewed-by: Yang Yang Signed-off-by: CGEL ZTE --- fs/proc/base.c | 15 +++++++++++++++ include/linux/mm_types.h | 5 +++++ mm/ksm.c | 2 ++ 3 files changed, 22 insertions(+) diff --git a/fs/proc/base.c b/fs/proc/base.c index 4ead8cf654e4..9977e17885c2 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -3199,6 +3199,19 @@ static int proc_pid_ksm_merging_pages(struct seq_file *m, struct pid_namespace * return 0; } +static int proc_pid_ksm_rmp_items(struct seq_file *m, struct pid_namespace *ns, + struct pid *pid, struct task_struct *task) +{ + struct mm_struct *mm; + + mm = get_task_mm(task); + if (mm) { + seq_printf(m, "%lu\n", mm->ksm_rmp_items); + mmput(mm); + } + + return 0; +} #endif /* CONFIG_KSM */ #ifdef CONFIG_STACKLEAK_METRICS @@ -3334,6 +3347,7 @@ static const struct pid_entry tgid_base_stuff[] = { #endif #ifdef CONFIG_KSM ONE("ksm_merging_pages", S_IRUSR, proc_pid_ksm_merging_pages), + ONE("ksm_rmp_items", S_IRUSR, proc_pid_ksm_rmp_items), #endif }; @@ -3671,6 +3685,7 @@ static const struct pid_entry tid_base_stuff[] = { #endif #ifdef CONFIG_KSM ONE("ksm_merging_pages", S_IRUSR, proc_pid_ksm_merging_pages), + ONE("ksm_rmp_items", S_IRUSR, proc_pid_ksm_rmp_items), #endif }; diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index d6ec33438dc1..a2a8da1ccb31 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -656,6 +656,11 @@ struct mm_struct { * merging. */ unsigned long ksm_merging_pages; + /* + * Represent how many pages are checked for ksm merging + * including merged and not merged. + */ + unsigned long ksm_rmp_items; #endif #ifdef CONFIG_LRU_GEN struct { diff --git a/mm/ksm.c b/mm/ksm.c index a98bc3beb874..66d686039010 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -387,6 +387,7 @@ static inline struct rmap_item *alloc_rmap_item(void) static inline void free_rmap_item(struct rmap_item *rmap_item) { ksm_rmap_items--; + rmap_item->mm->ksm_rmp_items--; rmap_item->mm = NULL; /* debug safety */ kmem_cache_free(rmap_item_cache, rmap_item); } @@ -2231,6 +2232,7 @@ static struct rmap_item *get_next_rmap_item(struct mm_slot *mm_slot, if (rmap_item) { /* It has already been zeroed */ rmap_item->mm = mm_slot->mm; + rmap_item->mm->ksm_rmp_items++; rmap_item->address = addr; rmap_item->rmap_list = *rmap_list; *rmap_list = rmap_item;