From patchwork Wed Aug 24 12:46:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: CGEL X-Patchwork-Id: 12953478 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88DBBC00140 for ; Wed, 24 Aug 2022 12:46:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B7D8940008; Wed, 24 Aug 2022 08:46:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29786940007; Wed, 24 Aug 2022 08:46:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15701940008; Wed, 24 Aug 2022 08:46:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 067A1940007 for ; Wed, 24 Aug 2022 08:46:23 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D1CB1C06F8 for ; Wed, 24 Aug 2022 12:46:22 +0000 (UTC) X-FDA: 79834459404.28.4AD3396 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 79D721C0017 for ; Wed, 24 Aug 2022 12:46:22 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id s206so14938226pgs.3 for ; Wed, 24 Aug 2022 05:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=3ofBEgoOVULXRx9YcQITS6kJlSwXHxOcRDY8bmuQ+uo=; b=NYC0P+VvC3h/qTsakz1cthPNN6d0FSa/CYEhKgFHhMVQFz5I0VHJw5acQMB+cJxtdg nnU/tDqXG6W2Y0nMwoO00ADoUZDT2fX7FJdTXFMHlhVsvg7iZFacy3t2TV5/FjURCLzo HylQLQN259LAegfiak5+uqCcTPMABKgl3yBrMJ3UFKZEwEpqi4AszeZODfyApIV4pimQ ++ROAvmiK0Uw7LuoQMle0VTrFC9XJCHu5ATLXebq9z+I+qLHqNSuNToy/mGdlZNFqbnN fY2WhXGJn+7WmztHZUhW1rLBf8akcWKn6nDTf60IkUBdSvMA3wJrarhuuFbB9i9pNvfk 1Bug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=3ofBEgoOVULXRx9YcQITS6kJlSwXHxOcRDY8bmuQ+uo=; b=b//X+sylpj5BFfo1tdhkAOOab1AMZbvhBd353d1v39iR7GxEtIn//T8qCqiNIeuG5W zp4hVUVODFf8xh+Nwgk1teCCtNlNO3F8JMDmgTQuHUl9WjYjPTvGXZqxOvjERMB3uv9o wqSlskdXMVhMFatvInxjXyaNt8QHnOLPP47vqGuZj1j8U+/L6/c/KS/R5/8v39i8T5hG YXVTEg2hsLx3CuDR6kEYqT800XIMJP+BcVnyc4Iibu4rV0A0nNjS/vFnmpnbvNIFOS19 kWaAh4IK5iEimhA9e0BLb6dgRkRLWaIM4hFXs8Jx5mj6Ytnldx0w2aRvG1sgNvsYrc7U ZjJA== X-Gm-Message-State: ACgBeo1NEZdS7GV4KRrwyWarQmNT9Ur01Yol+Kwu7SyHvIaHpEQVIwZ4 2TcFffqf1W2yE3utWd9qshU= X-Google-Smtp-Source: AA6agR7CoO2D9s/3qmn9/iCPy26WOtaYDVN7fIrc2I5o2V7sIFjhhRlUaQG/0F3Z41g231kvMm6D+w== X-Received: by 2002:a63:8a4b:0:b0:42a:5144:a44 with SMTP id y72-20020a638a4b000000b0042a51440a44mr18608141pgd.164.1661345181365; Wed, 24 Aug 2022 05:46:21 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id rw13-20020a17090b2c4d00b001fb3522d53asm1271613pjb.34.2022.08.24.05.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 05:46:21 -0700 (PDT) From: xu xin X-Google-Original-From: xu xin To: akpm@linux-foundation.org, corbet@lwn.net Cc: bagasdotme@gmail.com, adobriyan@gmail.com, willy@infradead.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, xu xin , Xiaokai Ran , Yang Yang , CGEL ZTE Subject: [PATCH v4 1/2] ksm: count allocated ksm rmap_items for each process Date: Wed, 24 Aug 2022 12:46:15 +0000 Message-Id: <20220824124615.223158-1-xu.xin16@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220824124512.223103-1-xu.xin16@zte.com.cn> References: <20220824124512.223103-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661345182; a=rsa-sha256; cv=none; b=DcqoTc3sutiRl5ZpGk0MMSgJNwdTGki+n4KNydMJVYQQ2TNczeN4N7W/GonznUiDQ/SEdy zlJAJ87ezing6DZ6bkd+m8FVu4oiyQ/uRRwhmIf45ACr4IZLdZkGQESQ4EozIi4rNeH+8z 6RpTXnVSZ9KH7Lj9ymJRD4rf5LebIo0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NYC0P+Vv; spf=pass (imf18.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661345182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3ofBEgoOVULXRx9YcQITS6kJlSwXHxOcRDY8bmuQ+uo=; b=EoQBGzmoLGNAkDZITzJu+pEDHdg5TmPmn/GmcmWIumU2GOwxYIL4c9zalcfZ9Eo+XO5V/U cFmDg+5vnzP6dDdH+yaNSpI6sJiw9GlGjPfeky6v+J8iSZIOdhUkiKBawRLS1tcjpA0nQ6 pg4bONYE5bEkzZ5EOPDK4BDt1eOvD7g= X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 79D721C0017 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NYC0P+Vv; spf=pass (imf18.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: oyznepjzi5dp65kjejys865zj6j5tioe X-HE-Tag: 1661345182-61380 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: KSM can save memory by merging identical pages, but also can consume additional memory, because it needs to generate rmap_items to save each scanned page's brief rmap information. Some of these pages may be merged, but some may not be abled to be merged after being checked several times, which are unprofitable memory consumed. The information about whether KSM save memory or consume memory in system-wide range can be determined by the comprehensive calculation of pages_sharing, pages_shared, pages_unshared and pages_volatile. A simple approximate calculation: profit =~ pages_sharing * sizeof(page) - (all_rmap_items) * sizeof(rmap_item); where all_rmap_items equals to the sum of pages_sharing, pages_shared, pages_unshared and pages_volatile. But we cannot calculate this kind of ksm profit inner single-process wide because the information of ksm rmap_item's number of a process is lacked. For user applications, if this kind of information could be obtained, it helps upper users know how beneficial the ksm-policy (like madvise) they are using brings, and then optimize their app code. For example, one application madvise 1000 pages as MERGEABLE, while only a few pages are really merged, then it's not cost-efficient. So we add a new interface /proc//ksm_rmp_items for each process to indicate the total allocated ksm rmap_items of this process. Similarly, we can calculate the ksm profit approximately for a single-process by: profit =~ ksm_merging_pages * sizeof(page) - ksm_rmp_items * sizeof(rmap_item); where ksm_merging_pages and ksm_rmp_items are both under /proc//. Signed-off-by: xu xin Reviewed-by: Xiaokai Ran Reviewed-by: Yang Yang Signed-off-by: CGEL ZTE --- fs/proc/base.c | 15 +++++++++++++++ include/linux/mm_types.h | 5 +++++ mm/ksm.c | 2 ++ 3 files changed, 22 insertions(+) base-commit: 68a00424bf69036970ced7930f9e4d709b4a6423 diff --git a/fs/proc/base.c b/fs/proc/base.c index 4ead8cf654e4..9977e17885c2 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -3199,6 +3199,19 @@ static int proc_pid_ksm_merging_pages(struct seq_file *m, struct pid_namespace * return 0; } +static int proc_pid_ksm_rmp_items(struct seq_file *m, struct pid_namespace *ns, + struct pid *pid, struct task_struct *task) +{ + struct mm_struct *mm; + + mm = get_task_mm(task); + if (mm) { + seq_printf(m, "%lu\n", mm->ksm_rmp_items); + mmput(mm); + } + + return 0; +} #endif /* CONFIG_KSM */ #ifdef CONFIG_STACKLEAK_METRICS @@ -3334,6 +3347,7 @@ static const struct pid_entry tgid_base_stuff[] = { #endif #ifdef CONFIG_KSM ONE("ksm_merging_pages", S_IRUSR, proc_pid_ksm_merging_pages), + ONE("ksm_rmp_items", S_IRUSR, proc_pid_ksm_rmp_items), #endif }; @@ -3671,6 +3685,7 @@ static const struct pid_entry tid_base_stuff[] = { #endif #ifdef CONFIG_KSM ONE("ksm_merging_pages", S_IRUSR, proc_pid_ksm_merging_pages), + ONE("ksm_rmp_items", S_IRUSR, proc_pid_ksm_rmp_items), #endif }; diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index d6ec33438dc1..a2a8da1ccb31 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -656,6 +656,11 @@ struct mm_struct { * merging. */ unsigned long ksm_merging_pages; + /* + * Represent how many pages are checked for ksm merging + * including merged and not merged. + */ + unsigned long ksm_rmp_items; #endif #ifdef CONFIG_LRU_GEN struct { diff --git a/mm/ksm.c b/mm/ksm.c index a98bc3beb874..66d686039010 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -387,6 +387,7 @@ static inline struct rmap_item *alloc_rmap_item(void) static inline void free_rmap_item(struct rmap_item *rmap_item) { ksm_rmap_items--; + rmap_item->mm->ksm_rmp_items--; rmap_item->mm = NULL; /* debug safety */ kmem_cache_free(rmap_item_cache, rmap_item); } @@ -2231,6 +2232,7 @@ static struct rmap_item *get_next_rmap_item(struct mm_slot *mm_slot, if (rmap_item) { /* It has already been zeroed */ rmap_item->mm = mm_slot->mm; + rmap_item->mm->ksm_rmp_items++; rmap_item->address = addr; rmap_item->rmap_list = *rmap_list; *rmap_list = rmap_item;