From patchwork Fri Aug 26 15:07:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Potapenko X-Patchwork-Id: 12956189 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B856ECAAD5 for ; Fri, 26 Aug 2022 15:09:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 970F5940009; Fri, 26 Aug 2022 11:08:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AA25940007; Fri, 26 Aug 2022 11:08:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FC64940009; Fri, 26 Aug 2022 11:08:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5DE3F940007 for ; Fri, 26 Aug 2022 11:08:59 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3B7021C183E for ; Fri, 26 Aug 2022 15:08:59 +0000 (UTC) X-FDA: 79842076398.31.3A7A567 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf06.hostedemail.com (Postfix) with ESMTP id DA916180013 for ; Fri, 26 Aug 2022 15:08:58 +0000 (UTC) Received: by mail-wm1-f74.google.com with SMTP id r131-20020a1c4489000000b003a7b679981cso803120wma.6 for ; Fri, 26 Aug 2022 08:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc; bh=Oj/n9T6llj5wDAAKfJeFunm60o607TLggj1MRB6CXqU=; b=PxLdCUrn0I9r2KhoyjcHAgRjabnegFod8IN6xz54blzpZh/1HZMNwSAgdShD0YvvTh Zxa5m/TO4KXMsG3OReoI+v+75UBjGjQZGLkWHPGtaoCFJKvIQldeDs2TPHJBt92k+HBR GqPmBiuONAM/IYWYOjJo+NjVJdkfYt9fsorrmjsf8jhWXVxxLXlhRRcVPT7xJPiq3MGR sOERai0/gwO4NtaVb2+CTxwQIjtjIGirbBBqxUONp9htYRv0TtzY3VfMqWDgDmyiC71n pI0ppgM4t9DRD3K6ZENiNPm8eVLb/eKuoAsYeEkEZa3aYmpCTXb/EK1nCWbE6o9dPH2L xa+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc; bh=Oj/n9T6llj5wDAAKfJeFunm60o607TLggj1MRB6CXqU=; b=JxPGhjXjQbwwRq/qMlzDzOFA6imgvf3/hGpfAnMU/CBdTwdw1ehCj1kK0xFONtlGGf XrFpP366owc0HpgWvjotMz94F4ifIDtiZOZnJqUQU2EkNeqZychVvJGRUPeXWrK8FXBz O7fmeyC5e3mEJK2gJraYAEQ8mOfMuTyWvOS42ck/Ae7CQQxwdMJ7TnQkVKTicjAgMok3 mnM+frEWhax0sqaemKUnG2SyHSlSn2j9G2CFboGlz9iadHB/XYwE0YE/SZuXVPk8X9H0 T+TqcQQBdHXEUNOXxjGb6qvbfsH1ehbnK+QZkWgGDzvXryTHEmuFvIkDL8HxlI+PpG/s k0gg== X-Gm-Message-State: ACgBeo2tzJUFTWAElt1/qkayPcxGNm0JQlpyHIDNYvw740KiBe2hDJij YrCCWAbFt+U8Xnv2LSWMWMbQlmKtI7U= X-Google-Smtp-Source: AA6agR5rvjq/H6vV+DBU+cdF375w+nJz6Qf5RMmSw4joFRAU0pGVVVqBSQBGZeHf42N72d45iOUQjmMAIWY= X-Received: from glider.muc.corp.google.com ([2a00:79e0:9c:201:5207:ac36:fdd3:502d]) (user=glider job=sendgmr) by 2002:a5d:6483:0:b0:225:7fb7:f163 with SMTP id o3-20020a5d6483000000b002257fb7f163mr49905wri.391.1661526537522; Fri, 26 Aug 2022 08:08:57 -0700 (PDT) Date: Fri, 26 Aug 2022 17:07:39 +0200 In-Reply-To: <20220826150807.723137-1-glider@google.com> Mime-Version: 1.0 References: <20220826150807.723137-1-glider@google.com> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog Message-ID: <20220826150807.723137-17-glider@google.com> Subject: [PATCH v5 16/44] kmsan: handle task creation and exiting From: Alexander Potapenko To: glider@google.com Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Marco Elver , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661526538; a=rsa-sha256; cv=none; b=6D2IgE78b1M68G3juioFf6E3fK6RHPiaxFqV+aODysNkZpPeUPqYChAJYuenQZ90J4u6jJ 3fLABwtuL3nHHmmrTZTvg6ybe+av+5bNfwlmENhbyP0RhTqKVXRa0BYJ0Gq0pkPnWlvmYG NutaqAbLdyHUE/Dxq9D03HFzLARiBS0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PxLdCUrn; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3CeIIYwYKCBAw1ytu7w44w1u.s421y3AD-220Bqs0.47w@flex--glider.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3CeIIYwYKCBAw1ytu7w44w1u.s421y3AD-220Bqs0.47w@flex--glider.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661526538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Oj/n9T6llj5wDAAKfJeFunm60o607TLggj1MRB6CXqU=; b=o39INJy2NLR/8dmcDHe6kdzb/koNbiYzGOfxddIhdKnbXxq2+y3KT025if4/pQYfLiqOwV UyxVfHbU7ZGwXk2pk9bQZBXvY5FvtFw/rTCoDDTUqJAYIX0UUiHMoMjkNkUWLL9TQgASNy Er53YHy2e6dZqoNWcEP3YDpV/nu+KqI= Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PxLdCUrn; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3CeIIYwYKCBAw1ytu7w44w1u.s421y3AD-220Bqs0.47w@flex--glider.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3CeIIYwYKCBAw1ytu7w44w1u.s421y3AD-220Bqs0.47w@flex--glider.bounces.google.com X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: wr99bjdarjq1gz7iy8dhid416z4b9w3f X-Rspamd-Queue-Id: DA916180013 X-HE-Tag: 1661526538-596626 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Tell KMSAN that a new task is created, so the tool creates a backing metadata structure for that task. Signed-off-by: Alexander Potapenko --- v2: -- move implementation of kmsan_task_create() and kmsan_task_exit() here v4: -- change sizeof(type) to sizeof(*ptr) v5: -- do not export KMSAN hooks that are not called from modules -- minor comment fix Link: https://linux-review.googlesource.com/id/I0f41c3a1c7d66f7e14aabcfdfc7c69addb945805 --- include/linux/kmsan.h | 21 +++++++++++++++++++++ kernel/exit.c | 2 ++ kernel/fork.c | 2 ++ mm/kmsan/core.c | 10 ++++++++++ mm/kmsan/hooks.c | 17 +++++++++++++++++ mm/kmsan/kmsan.h | 2 ++ 6 files changed, 54 insertions(+) diff --git a/include/linux/kmsan.h b/include/linux/kmsan.h index fd76cea338878..5ec056380a43b 100644 --- a/include/linux/kmsan.h +++ b/include/linux/kmsan.h @@ -16,6 +16,7 @@ struct page; struct kmem_cache; +struct task_struct; #ifdef CONFIG_KMSAN @@ -42,6 +43,18 @@ struct kmsan_ctx { bool allow_reporting; }; +/** + * kmsan_task_create() - Initialize KMSAN state for the task. + * @task: task to initialize. + */ +void kmsan_task_create(struct task_struct *task); + +/** + * kmsan_task_exit() - Notify KMSAN that a task has exited. + * @task: task about to finish. + */ +void kmsan_task_exit(struct task_struct *task); + /** * kmsan_alloc_page() - Notify KMSAN about an alloc_pages() call. * @page: struct page pointer returned by alloc_pages(). @@ -163,6 +176,14 @@ void kmsan_iounmap_page_range(unsigned long start, unsigned long end); #else +static inline void kmsan_task_create(struct task_struct *task) +{ +} + +static inline void kmsan_task_exit(struct task_struct *task) +{ +} + static inline int kmsan_alloc_page(struct page *page, unsigned int order, gfp_t flags) { diff --git a/kernel/exit.c b/kernel/exit.c index 84021b24f79e3..f5d620c315662 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -60,6 +60,7 @@ #include #include #include +#include #include #include #include @@ -741,6 +742,7 @@ void __noreturn do_exit(long code) WARN_ON(tsk->plug); kcov_task_exit(tsk); + kmsan_task_exit(tsk); coredump_task_exit(tsk); ptrace_event(PTRACE_EVENT_EXIT, code); diff --git a/kernel/fork.c b/kernel/fork.c index 90c85b17bf698..7cf3eea01ceef 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include #include @@ -1026,6 +1027,7 @@ static struct task_struct *dup_task_struct(struct task_struct *orig, int node) tsk->worker_private = NULL; kcov_task_init(tsk); + kmsan_task_create(tsk); kmap_local_fork(tsk); #ifdef CONFIG_FAULT_INJECTION diff --git a/mm/kmsan/core.c b/mm/kmsan/core.c index a5dec6e62b4ef..a640e0cccbb64 100644 --- a/mm/kmsan/core.c +++ b/mm/kmsan/core.c @@ -44,6 +44,16 @@ bool kmsan_enabled __read_mostly; */ DEFINE_PER_CPU(struct kmsan_ctx, kmsan_percpu_ctx); +void kmsan_internal_task_create(struct task_struct *task) +{ + struct kmsan_ctx *ctx = &task->kmsan_ctx; + struct thread_info *info = current_thread_info(); + + __memset(ctx, 0, sizeof(*ctx)); + ctx->allow_reporting = true; + kmsan_internal_unpoison_memory(info, sizeof(*info), false); +} + void kmsan_internal_poison_memory(void *address, size_t size, gfp_t flags, unsigned int poison_flags) { diff --git a/mm/kmsan/hooks.c b/mm/kmsan/hooks.c index 519a7a1dcb4aa..4ab8c629acd0c 100644 --- a/mm/kmsan/hooks.c +++ b/mm/kmsan/hooks.c @@ -26,6 +26,23 @@ * skipping effects of functions like memset() inside instrumented code. */ +void kmsan_task_create(struct task_struct *task) +{ + kmsan_enter_runtime(); + kmsan_internal_task_create(task); + kmsan_leave_runtime(); +} + +void kmsan_task_exit(struct task_struct *task) +{ + struct kmsan_ctx *ctx = &task->kmsan_ctx; + + if (!kmsan_enabled || kmsan_in_runtime()) + return; + + ctx->allow_reporting = false; +} + void kmsan_slab_alloc(struct kmem_cache *s, void *object, gfp_t flags) { if (unlikely(object == NULL)) diff --git a/mm/kmsan/kmsan.h b/mm/kmsan/kmsan.h index 6b9deee3b7f32..04954b83c5d65 100644 --- a/mm/kmsan/kmsan.h +++ b/mm/kmsan/kmsan.h @@ -179,6 +179,8 @@ void kmsan_internal_set_shadow_origin(void *address, size_t size, int b, u32 origin, bool checked); depot_stack_handle_t kmsan_internal_chain_origin(depot_stack_handle_t id); +void kmsan_internal_task_create(struct task_struct *task); + bool kmsan_metadata_is_contiguous(void *addr, size_t size); void kmsan_internal_check_memory(void *addr, size_t size, const void *user_addr, int reason);