From patchwork Tue Aug 30 14:10:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chao Yu X-Patchwork-Id: 12959406 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B60AAECAAD1 for ; Tue, 30 Aug 2022 14:10:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2339940007; Tue, 30 Aug 2022 10:10:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCEDB6B0075; Tue, 30 Aug 2022 10:10:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C96DE940007; Tue, 30 Aug 2022 10:10:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B48C66B0074 for ; Tue, 30 Aug 2022 10:10:21 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8C58FA13DA for ; Tue, 30 Aug 2022 14:10:21 +0000 (UTC) X-FDA: 79856443842.19.6216051 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 141A940028 for ; Tue, 30 Aug 2022 14:10:19 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1451E614D5; Tue, 30 Aug 2022 14:10:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50062C433D6; Tue, 30 Aug 2022 14:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661868618; bh=9jvmfxVkEDEXTF+mMxMl1gFBBTusiLQ4TP5tx3/ow2U=; h=From:To:Cc:Subject:Date:From; b=LL8l90mImhJxlaekcy63LJKtXNiuQGiW07yMVKoDLBIxRsgypBjk4hR8aa68GeNqW JL2J643sZgxkKO+YA4QXeeAfI6bpib4bt+KBbQDaYV/PsYEaazCt0aHe0U7Tnp9NTz KKT/LyE1kHkdyxbsj0xqX6d4rvVUY+l+dVBHwnz+UyUyud9W6wPFX5iZkQFo+HqLGC KdDQVWp+yUk4niFGNfQM+O9Tosd4sGX1izEVdjH0MHSkEz0F9XSr9aeVrXqc5Ybni0 ckdggUJDG5WTnT4B5GYA0qtEI1rzVdyMimGz2fMu1lEC6hCHebBSJNsLq4veI+dqmm bl9gtp0ry5YTQ== From: Chao Yu To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, chao@kernel.org, jaegeuk@kernel.org, Chao Yu , stable@kernel.org, syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com Subject: [PATCH] mm/slub: fix to return errno if kmalloc() fails Date: Tue, 30 Aug 2022 22:10:09 +0800 Message-Id: <20220830141009.150075-1-chao@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LL8l90mI; spf=pass (imf04.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661868620; a=rsa-sha256; cv=none; b=tieqOZ0Seo4S9Ge6nk5jpYrbQw4wYMeNp9iwSaaDqXIZsiaUSd6luOZwQXsgVlSPNcnLVO 4PlX8fYpq0OLGfVLOmBuZ9eOkSIT6sBhdZpCfFbYvV0LNTtjEzujQnOPu59hwmzT+IgHI0 2e/VxwkkybOOCpritepuL2gqyNOFq+I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661868620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=mV1O7t3VsT8jVLinZA7JBulPJVP+1rMmzSnCSMrKk/8=; b=w8TtZordGwzgc5i0tv0gGia5XjHWRvjxL1hpqlDGM5w1poG8w3afNEvqyDMPPq5D+FTxhi n1urB+mP1nnE2tgDEdDzbPnZOFOSycmidlNhzTkwg4qrw+LSlNzbW+5ilU57wmeE6TZYxR SNOmOV2JCJhD36AOz1c7uv1sYhT1TQ4= X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LL8l90mI; spf=pass (imf04.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam02 X-Stat-Signature: q8bz5cnxmxm9gw6zyp4zzexwq35o1s5h X-Rspamd-Queue-Id: 141A940028 X-HE-Tag: 1661868619-657557 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Chao Yu In create_unique_id(), kmalloc(, GFP_KERNEL) can fail due to out-of-memory, if it fails, return errno correctly rather than triggering panic via BUG_ON(); kernel BUG at mm/slub.c:5893! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP Call trace: sysfs_slab_add+0x258/0x260 mm/slub.c:5973 __kmem_cache_create+0x60/0x118 mm/slub.c:4899 create_cache mm/slab_common.c:229 [inline] kmem_cache_create_usercopy+0x19c/0x31c mm/slab_common.c:335 kmem_cache_create+0x1c/0x28 mm/slab_common.c:390 f2fs_kmem_cache_create fs/f2fs/f2fs.h:2766 [inline] f2fs_init_xattr_caches+0x78/0xb4 fs/f2fs/xattr.c:808 f2fs_fill_super+0x1050/0x1e0c fs/f2fs/super.c:4149 mount_bdev+0x1b8/0x210 fs/super.c:1400 f2fs_mount+0x44/0x58 fs/f2fs/super.c:4512 legacy_get_tree+0x30/0x74 fs/fs_context.c:610 vfs_get_tree+0x40/0x140 fs/super.c:1530 do_new_mount+0x1dc/0x4e4 fs/namespace.c:3040 path_mount+0x358/0x914 fs/namespace.c:3370 do_mount fs/namespace.c:3383 [inline] __do_sys_mount fs/namespace.c:3591 [inline] __se_sys_mount fs/namespace.c:3568 [inline] __arm64_sys_mount+0x2f8/0x408 fs/namespace.c:3568 Cc: Reported-by: syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com Signed-off-by: Chao Yu Reviewed-by: Muchun Song Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Acked-by: David Rientjes --- mm/slub.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 862dbd9af4f5..e6f3727b9ad2 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5890,7 +5890,8 @@ static char *create_unique_id(struct kmem_cache *s) char *name = kmalloc(ID_STR_LENGTH, GFP_KERNEL); char *p = name; - BUG_ON(!name); + if (!name) + return ERR_PTR(-ENOMEM); *p++ = ':'; /* @@ -5948,6 +5949,8 @@ static int sysfs_slab_add(struct kmem_cache *s) * for the symlinks. */ name = create_unique_id(s); + if (IS_ERR(name)) + return PTR_ERR(name); } s->kobj.kset = kset;