From patchwork Thu Sep 8 10:43:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Bulwahn X-Patchwork-Id: 12969921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF1FECAAD5 for ; Thu, 8 Sep 2022 10:43:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24C106B0078; Thu, 8 Sep 2022 06:43:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FDD36B007B; Thu, 8 Sep 2022 06:43:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09D336B007D; Thu, 8 Sep 2022 06:43:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EAC156B0078 for ; Thu, 8 Sep 2022 06:43:55 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C61A71C6A6E for ; Thu, 8 Sep 2022 10:43:55 +0000 (UTC) X-FDA: 79888582830.09.FAE09D8 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf16.hostedemail.com (Postfix) with ESMTP id 7393F180078 for ; Thu, 8 Sep 2022 10:43:55 +0000 (UTC) Received: by mail-wr1-f44.google.com with SMTP id d2so8240927wrn.1 for ; Thu, 08 Sep 2022 03:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date; bh=DAvW/j/5PxDjN0idhO6jbr+d99JWnLewou5/uVrgjpw=; b=BjftNcUlKNzBBVcZwF15+1/SUUs6ojyiGx+bmwJqOwI5zKTtIVhoNVvdW8TIaVaAps aFmzTJUK0Ef6cg7zBmV6LX/dGZoPVKPVveNp1rNUaW++nGkfDSyUmRTu68aOk96Ga0kb fSRCjPZQ3DYljHvB7IJp1AYr6FdAu44RzyJZFwdMk6cECanW5F4IsNN8672rXQmOhGgT w5Q43+vhG98S2dBXQrlNbW2OC34mTsABkWOS4wxUoD2d1eAAAGk1Qotds/77Bze+3n9P EXcygbRWdDU5R1rHXmu76wKLlz4ntHJmGuu2+SKMsGn0qkR8sbyLSpyCEz6H6QMxjmAq pTUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=DAvW/j/5PxDjN0idhO6jbr+d99JWnLewou5/uVrgjpw=; b=KR2cd4oAVnEBwJib+70L4sFJ07FMPvpgNEY+gpBQMuF85/e5oeo0phd5xmWbNvZ4d7 2kbQ3uURu4QYwc42amT0rcjnghpDRffeCR2qSeedI7oOD763hKWmu6qw8qvoZvVBrb2/ TIBPtRE+QTD4IR80Nbx3vuA100HojtiwDdVxSFsafKvGo0wj16Biue3jefCyJy492jjS YMxWAMUiB6xAhIdsr/KDtbC0BJFqifWPScewCvsXW6gdXK6fRJWG7/1HX0Ln3AW+NGf2 VR/VRh6HIu2LrxOapnjAVDV/IB+w6E+whJ+g/bg2FE0BMohpEqKwRbwugdS9hiFu/ddR Lvgg== X-Gm-Message-State: ACgBeo2rZqW9FDyJLIH/K8wj5JvuLcz4ghwvS37i/75pv+eURp2oeV8O e/xnq5ByYNMtnw097aAbzpM= X-Google-Smtp-Source: AA6agR5QOaqvtIoVx5Bin2x+wiRcH4moEJJlXrbG8Yn8LK7Igv7M/jtpddN3oejEBKPK9FGt4HnrHg== X-Received: by 2002:a5d:6802:0:b0:228:d6e9:6dd8 with SMTP id w2-20020a5d6802000000b00228d6e96dd8mr4963144wru.710.1662633834261; Thu, 08 Sep 2022 03:43:54 -0700 (PDT) Received: from felia.fritz.box (200116b826f77600d0640cc051af4288.dip.versatel-1u1.de. [2001:16b8:26f7:7600:d064:cc0:51af:4288]) by smtp.gmail.com with ESMTPSA id bu3-20020a056000078300b0022863395912sm17227486wrb.53.2022.09.08.03.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 03:43:53 -0700 (PDT) From: Lukas Bulwahn To: Russell King , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, Peter Chen , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Andrew Morton , Mike Rapoport , linux-mm@kvack.org, Masahiro Yamada , linux-kbuild@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH 4/6] usb: chipidea: make configs for glue drivers visible with EXPERT Date: Thu, 8 Sep 2022 12:43:35 +0200 Message-Id: <20220908104337.11940-5-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220908104337.11940-1-lukas.bulwahn@gmail.com> References: <20220908104337.11940-1-lukas.bulwahn@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662633835; a=rsa-sha256; cv=none; b=OnXF1eX1Eaw3wiM/YrqT4Q8Gii1dcTCd7bY0VX8dooDNubhs8jow1yxTw4YN/vlvqo8zxq 3ud2DEEMGcixdLf4MBJrlwlDswEoKYj3p/LY731Egy6jC+4S6LuGR1mB3VVRAEdFCeQGZd 54V5tlPMoxc3cjD5QMEpbG4Svw5S0xc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BjftNcUl; spf=pass (imf16.hostedemail.com: domain of lukas.bulwahn@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=lukas.bulwahn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662633835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=DAvW/j/5PxDjN0idhO6jbr+d99JWnLewou5/uVrgjpw=; b=ROZusLnrcRTpsdNAndxoaZxz/7gfxwyLL3CJbLBF9nX8Se7yobn1XT9pNFco+chq64xrCn p1U+bYJ+3fSR4iAjssQJEwVrRRXl8C/ZVHukFRgi5BUisTCdNKycuAX2jA/MdZKjj5XWxL BcmAYQAI0XV4h1glPIajIfeAXoIopHQ= Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BjftNcUl; spf=pass (imf16.hostedemail.com: domain of lukas.bulwahn@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=lukas.bulwahn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: yecon15356967xwjesbzqpjsrqeorjux X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7393F180078 X-HE-Tag: 1662633835-756323 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit 6a108a14fa35 ("kconfig: rename CONFIG_EMBEDDED to CONFIG_EXPERT") introduces CONFIG_EXPERT to carry the previous intent of CONFIG_EMBEDDED and just gives that intent a much better name. That has been clearly a good and long overdue renaming, and it is clearly an improvement to the kernel build configuration that has shown to help managing the kernel build configuration in the last decade. However, rather than bravely and radically just deleting CONFIG_EMBEDDED, this commit gives CONFIG_EMBEDDED a new intended semantics, but keeps it open for future contributors to implement that intended semantics: A new CONFIG_EMBEDDED option is added that automatically selects CONFIG_EXPERT when enabled and can be used in the future to isolate options that should only be considered for embedded systems (RISC architectures, SLOB, etc). Since then, this CONFIG_EMBEDDED implicitly had two purposes: - It can make even more options visible beyond what CONFIG_EXPERT makes visible. In other words, it may introduce another level of enabling the visibility of configuration options: always visible, visible with CONFIG_EXPERT and visible with CONFIG_EMBEDDED. - Set certain default values of some configurations differently, following the assumption that configuring a kernel build for an embedded system generally starts with a different set of default values compared to kernel builds for all other kind of systems. Considering the first purpose, at the point in time where CONFIG_EMBEDDED was renamed to CONFIG_EXPERT, CONFIG_EXPERT already made 130 more options become visible throughout all different menus for the kernel configuration. Over the last decade, this has gradually increased, so that currently, with CONFIG_EXPERT, roughly 170 more options become visible throughout all different menus for the kernel configuration. In comparison, currently with CONFIG_EMBEDDED enabled, just seven more options are visible, one in x86, one in arm, and five for the ChipIdea Highspeed Dual Role Controller. As the numbers suggest, these two levels of enabling the visibility of even more configuration options---beyond what CONFIG_EXPERT enables---never evolved to a good solution in the last decade. In other words, this additional level of visibility of configuration option with CONFIG_EMBEDDED compared to CONFIG_EXPERT has since its introduction never become really valuable. It requires quite some investigation to actually understand what is additionally visible and it does not differ significantly in complexity compared to just enabling CONFIG_EXPERT. This CONFIG_EMBEDDED---or any other config to show more detailed options beyond CONFIG_EXPERT---is unlikely to be valuable unless somebody puts significant effort in identifying how such visibility options can be properly split and creating clear criteria, when some config option is visible with CONFIG_EXPERT and when some config option is visible only with some further option enabled beyond CONFIG_EXPERT, such as CONFIG_EMBEDDED attempted to do. For now, it is much more reasonable to simply make those additional seven options that visible with CONFIG_EMBEDDED, visible with CONFIG_EXPERT, and then remove CONFIG_EMBEDDED. If anyone spends significant effort in structuring the visibility of config options, they may re-introduce suitable new config options simply as they see fit. Make the configs for usb chipidea glue drivers visible when CONFIG_EXPERT is enabled. Signed-off-by: Lukas Bulwahn Reviewed-by: Masahiro Yamada --- drivers/usb/chipidea/Kconfig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig index 661818e8fed6..c815824a0b2d 100644 --- a/drivers/usb/chipidea/Kconfig +++ b/drivers/usb/chipidea/Kconfig @@ -34,26 +34,26 @@ config USB_CHIPIDEA_HOST ChipIdea driver. config USB_CHIPIDEA_PCI - tristate "Enable PCI glue driver" if EMBEDDED + tristate "Enable PCI glue driver" if EXPERT depends on USB_PCI depends on NOP_USB_XCEIV default USB_CHIPIDEA config USB_CHIPIDEA_MSM - tristate "Enable MSM hsusb glue driver" if EMBEDDED + tristate "Enable MSM hsusb glue driver" if EXPERT default USB_CHIPIDEA config USB_CHIPIDEA_IMX - tristate "Enable i.MX USB glue driver" if EMBEDDED + tristate "Enable i.MX USB glue driver" if EXPERT depends on OF default USB_CHIPIDEA config USB_CHIPIDEA_GENERIC - tristate "Enable generic USB2 glue driver" if EMBEDDED + tristate "Enable generic USB2 glue driver" if EXPERT default USB_CHIPIDEA config USB_CHIPIDEA_TEGRA - tristate "Enable Tegra USB glue driver" if EMBEDDED + tristate "Enable Tegra USB glue driver" if EXPERT depends on OF default USB_CHIPIDEA