From patchwork Sun Nov 13 16:29:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13041582 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF7EC433FE for ; Sun, 13 Nov 2022 16:29:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBF608E0001; Sun, 13 Nov 2022 11:29:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B70C48000C; Sun, 13 Nov 2022 11:29:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A37998E0003; Sun, 13 Nov 2022 11:29:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 908DE8E0001 for ; Sun, 13 Nov 2022 11:29:53 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5C3901A090A for ; Sun, 13 Nov 2022 16:29:53 +0000 (UTC) X-FDA: 80128955466.05.92C0E3F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 10ECA12000C for ; Sun, 13 Nov 2022 16:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=d1VC7GrQaMZNbkdOyDmdF6TZukkUpzM8YbBGwowHmIU=; b=vR2Urw0mBBapzzTe+ueUjxIcY0 Olt8+7T4BHw+h4YYCYE28AfjUTK6KSXgjUNvFMF/cmF0x/SDDKAKBik7JeJNB3hk5Ij/4zY/sb7gp yfsEo+ErnNnXsbVrPMQhy7zKjBT9bpHmYGUFOh/sFVFF0DAOWtuD+RUHdn5B80Ft2T/6v5qm15H/7 P0+sCUGI+u4iM+v5TLUgUFyeDIh426tTZEO/p/akvkKG1E21tuVTNqVxXFnDAcvN+N7dKSZfgpHoR B4oxYYk8vVaZcWWkAfypcY4RCswZTj1zxhrBiOcPSXylEvUYj0wdK5RVg/QvdvkPtJbdunpGgS+gb b3qp9j2Q==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFrd-00CK5A-Ob; Sun, 13 Nov 2022 16:29:46 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 9/9] udf: remove ->writepage Date: Sun, 13 Nov 2022 17:29:02 +0100 Message-Id: <20221113162902.883850-10-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356993; a=rsa-sha256; cv=none; b=VD1M/qYplcA0izn90ySzrQhwVwCXW6vYbzin3377Ti7CUuG+C2Lgf43+MkPCxjB1MJS4cs QJqDfPKjvT830RQ2Df9ci3XgIg2bF9hD3GIZs5utl200YB8UaJYSJ3Eb2O+3GHrRTzvhUm fdt75Ph+IwsqjVPCd+lRVw0qzCg0ldY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vR2Urw0m; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d1VC7GrQaMZNbkdOyDmdF6TZukkUpzM8YbBGwowHmIU=; b=M1dVFLNEp81Fhn7q8uwoAt5F8hCSqvUDgfNVANHQ2O5IhkrKGG+MTSx5QlDgN61nkAyX2I A/B1AkU92MzBAqzCF8mCUpNXcyqkriUhpOPos16D6cPvS+8eP+92zep7FbD9EXh94kbkhM OCJlW0K5dNvbDVvgMpg2lpNWJyjr7YE= X-Rspamd-Queue-Id: 10ECA12000C X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vR2Urw0m; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam06 X-Stat-Signature: 6mkxbxchiyjyjgt8dde3btn4b6k9f5fp X-HE-Tag: 1668356992-752461 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation in extfat. Signed-off-by: Christoph Hellwig Acked-by: Jan Kara --- fs/udf/inode.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index dce6ae9ae306c..0246b1b86fb91 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -182,11 +182,6 @@ static void udf_write_failed(struct address_space *mapping, loff_t to) } } -static int udf_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, udf_get_block, wbc); -} - static int udf_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -239,12 +234,12 @@ const struct address_space_operations udf_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = udf_read_folio, .readahead = udf_readahead, - .writepage = udf_writepage, .writepages = udf_writepages, .write_begin = udf_write_begin, .write_end = generic_write_end, .direct_IO = udf_direct_IO, .bmap = udf_bmap, + .migrate_folio = buffer_migrate_folio, }; /*