From patchwork Sun Nov 13 16:28:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13041578 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A01C433FE for ; Sun, 13 Nov 2022 16:29:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0006F80008; Sun, 13 Nov 2022 11:29:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF17A8E0001; Sun, 13 Nov 2022 11:29:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E07F780008; Sun, 13 Nov 2022 11:29:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D191C8E0001 for ; Sun, 13 Nov 2022 11:29:34 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 72E211C5C0C for ; Sun, 13 Nov 2022 16:29:34 +0000 (UTC) X-FDA: 80128954668.22.83E61D7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 11DD320003 for ; Sun, 13 Nov 2022 16:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=MwWj9ekijv12iDbEn7vuZCjsvgidcmcKtSd/iPVo/3U=; b=sX+/TxS5zNNROlDDctzjyY/ZjS g7P6amhXAy3A8MTH2YivI6QAOzqoM4YVgs8bon154bEvl614EDxGvS2f3HDxjB7I6hMMGdMG6InpY xkKJw4QUdBwSO2h/Dq4l/Lrl9bljG5TKB1foSi9C6QjUZoA6e0u05s8pq5lAFvQU4f9MpKJqPc50q LRE4B0JVluK6OhlGeHkzpXprpb9lQag0JUEGY8odsXvbNBJuDM/Klzo6uXma3atSgB7lCPdC7eIgB j2kgdck8zIN/g0yA6fivbHDh17B+VYnKLv8frjkxP1MOvsOc+mjuES3PhtbINubHCyw4daLcEeNVz ffyH3KCg==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFrK-00CJs5-Tj; Sun, 13 Nov 2022 16:29:27 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 5/9] hfsplus: remove ->writepage Date: Sun, 13 Nov 2022 17:28:58 +0100 Message-Id: <20221113162902.883850-6-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MwWj9ekijv12iDbEn7vuZCjsvgidcmcKtSd/iPVo/3U=; b=lJWGxtldqUVgch0kaoOSTyua+QnZn5dbkeNFyX9JN3oRndrQz9WSky4pxvOi7J15Rq2Tge 1qnWWBy2DprGkf+MIaz6k5m/Joz2fIEQXqWDcXlLI6RAMJ/ZZHsOuoAwEJHQQFsRK5QsDu 8csI6XeC3xH3thAUFu8aR8s/SPQ9xXU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="sX+/TxS5"; dmarc=none; spf=none (imf03.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356974; a=rsa-sha256; cv=none; b=uZ4W/xOL6XQOCKB73bNzk4aHeT7SsDKmvkx9YLqNOP5+rOZZrUwECjR7qowS23ZIPzBZaZ vXlU1z2mJalNnlb06UhS2QxjD11XD/NBWNapRFNrjHRqGG20SuVPNcfEmULMHzmvI9FWRo VjRiuIuYJnoD/B1WigO2HEqENa4L/bQ= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 11DD320003 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="sX+/TxS5"; dmarc=none; spf=none (imf03.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org X-Stat-Signature: x75ndetepzx1izot3p66696djfgkg63k X-HE-Tag: 1668356973-358392 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and stop wiring up ->writepage for hfsplus_aops. Signed-off-by: Christoph Hellwig --- fs/hfsplus/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c index aeab83ed1c9c6..d6572ad2407a7 100644 --- a/fs/hfsplus/inode.c +++ b/fs/hfsplus/inode.c @@ -170,12 +170,12 @@ const struct address_space_operations hfsplus_aops = { .dirty_folio = block_dirty_folio, .invalidate_folio = block_invalidate_folio, .read_folio = hfsplus_read_folio, - .writepage = hfsplus_writepage, .write_begin = hfsplus_write_begin, .write_end = generic_write_end, .bmap = hfsplus_bmap, .direct_IO = hfsplus_direct_IO, .writepages = hfsplus_writepages, + .migrate_folio = buffer_migrate_folio, }; const struct dentry_operations hfsplus_dentry_operations = {