From patchwork Fri Dec 2 10:26:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13062580 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52DB0C4167B for ; Fri, 2 Dec 2022 10:27:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD8B36B0078; Fri, 2 Dec 2022 05:27:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B37ED6B007B; Fri, 2 Dec 2022 05:27:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 830506B007D; Fri, 2 Dec 2022 05:27:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 64D806B0078 for ; Fri, 2 Dec 2022 05:27:04 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 36B0A120A90 for ; Fri, 2 Dec 2022 10:27:04 +0000 (UTC) X-FDA: 80196988368.03.6ACFDA9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 8B8A8C0010 for ; Fri, 2 Dec 2022 10:27:02 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XcSze6yI; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669976823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y8Lak3cqHWQ+dnfyhXDbmC5RGlFrgzaazzdLBDYGtZQ=; b=0mK1u8GfsCiG6PYFEG7nNlC+E3wc+b+xV1utp8iKxezyiZI9xay1tstXltN8Pb8zR8j6Zj X701D1+AVjT+pM2Yfecy5nX8ONa8/3oP2iRkwIpAygruvjK1Jha+WwCTaD93YIq1nKSMjK Xb7Ednx28c2Vf4WZELPngIn1FO1m6J8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XcSze6yI; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669976823; a=rsa-sha256; cv=none; b=ApCEtttvW+UDQ7M9q+dN23YZoD92VDkoqt5/DaqGqptOmvy3d1iaGDET7vpkjrN1UZZWiX Ixc1oF/azzAIU4Ak/3vgK/PArJkJsTIX9dnNYAZNoiNldhC11NUlJ8EEp+ej0ySJ7m/a5l Mo0z81PACOSIBV7DnCyTTVrSwokhhIw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=Y8Lak3cqHWQ+dnfyhXDbmC5RGlFrgzaazzdLBDYGtZQ=; b=XcSze6yIF5L/Kmd8YUIv94LZPC WzH1nM4w+yQHudWoL9X1McNCpmKkrfOOG/ybs6VEgRXDnhtzvFFxgF2K+DRRZs4rgwFwlL1IUYb0k GD2FywGv16g5FhymEprpfNUd6SH8P47C11uUX/kneFiXVwoksI8Pewz+dE9CejlFM3PqFw+Uo/hEK EVbR8rGTHIwXSRM3s9uHqMr05/dPb9LZP1W1w7y76Odxbvyt8owe45cylBT3x2ZFd2uwXCyfeYAfU qbd/2u8s94Xp6wtw3UJdMXQdpbplxOqWjnoMs2IR9BvBIGrSlqgK8NhU9/ARmvkeJON4bYlzq2qqQ Yv6ZzMhQ==; Received: from [2001:4bb8:192:26e7:bcd3:7e81:e7de:56fd] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13Fs-00FQxO-F4; Fri, 02 Dec 2022 10:26:53 +0000 From: Christoph Hellwig To: Andrew Morton , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org, Johannes Weiner Subject: [PATCH 2/7] fat: remove ->writepage Date: Fri, 2 Dec 2022 11:26:39 +0100 Message-Id: <20221202102644.770505-3-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202102644.770505-1-hch@lst.de> References: <20221202102644.770505-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spamd-Result: default: False [0.74 / 9.00]; BAYES_HAM(-2.86)[99.41%]; R_MISSING_CHARSET(2.50)[]; MID_CONTAINS_FROM(1.00)[]; FORGED_SENDER(0.30)[hch@lst.de,BATV@bombadil.srs.infradead.org]; R_DKIM_ALLOW(-0.20)[infradead.org:s=bombadil.20210309]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[14]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[dbb76fff442e09cb8719,7040,infradead.org,hch]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[infradead.org:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[lst.de]; FROM_NEQ_ENVFROM(0.00)[hch@lst.de,BATV@bombadil.srs.infradead.org] X-Stat-Signature: 34dixazz1pczdmi6ibgqnocfpgmjmd9b X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8B8A8C0010 X-Rspam-User: X-HE-Tag: 1669976822-334772 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner --- fs/fat/inode.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 1cbcc4608dc78f..d99b8549ec8f91 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -194,11 +194,6 @@ static int fat_get_block(struct inode *inode, sector_t iblock, return 0; } -static int fat_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, fat_get_block, wbc); -} - static int fat_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -346,12 +341,12 @@ static const struct address_space_operations fat_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = fat_read_folio, .readahead = fat_readahead, - .writepage = fat_writepage, .writepages = fat_writepages, .write_begin = fat_write_begin, .write_end = fat_write_end, .direct_IO = fat_direct_IO, - .bmap = _fat_bmap + .bmap = _fat_bmap, + .migrate_folio = buffer_migrate_folio, }; /*