From patchwork Fri Dec 2 10:26:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13062578 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 631DAC4332F for ; Fri, 2 Dec 2022 10:27:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 647186B0075; Fri, 2 Dec 2022 05:27:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 608FF6B0074; Fri, 2 Dec 2022 05:27:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45C0C6B007B; Fri, 2 Dec 2022 05:27:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2E6036B0074 for ; Fri, 2 Dec 2022 05:27:04 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 00B27C076A for ; Fri, 2 Dec 2022 10:27:03 +0000 (UTC) X-FDA: 80196988326.04.DA69585 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id 6399318000D for ; Fri, 2 Dec 2022 10:27:03 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Yebwp0ce; spf=none (imf24.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669976823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yJxb4jf5H4wN5CZm7p5uEgZxeUIn0cECx2KzjI/LP/8=; b=XPHEUT2ZFBu0LrXINUhI+BxUrsnRIMLpV1Cs9sn+DPLB2O60glY6TvzVg2GH36XwX1iu9K GNhUkYPNQcFHSNxjDtMBq73rrUb9aP9laFAmJJJWp0o/lZcVFU56JPjsjbKpUIf7W2K7OC 8r/9VdrXFtL6lDeilq2t5jLicux0uBg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669976823; a=rsa-sha256; cv=none; b=6a2suAh7E4WU6kuVyWgUgd9Rbifc6SMr8cc+z8IFFZsm2wk0yGLWmAZiMEkdM71gzx6PPP 0GsANbRK0YvYKBAbnOiZhH8D9j6LLPl9NsEvNSQRSqYsLg9oZCfCwb5yp4j5yIo0sxs+94 JzxOsYid/HtvClWDkQ+VoKcKaJfeKY8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Yebwp0ce; spf=none (imf24.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=yJxb4jf5H4wN5CZm7p5uEgZxeUIn0cECx2KzjI/LP/8=; b=Yebwp0cearBPaYNKDQ0kQsacj0 WN5XnrFBFmcCGes73mk3QFiMUCa+hUsukP6klrjLDcVQa24dA4WKU35EJ1YXm2ElvIVIDXoCme8A9 icylY5Ogd4rySe2g5gdxIoK6NEfFi3FWalKeHkGTBTCid+Pfsd1hF74xRb4RXm3LJ3moR+qcZSmyd atUSuew4vVLKLbprx9fI/Bs8pFvbA8/JbQaLLkUm1G51JPgPCXFp8DId7kyIxfJXVHkZIWOzmoztl 32dL8SKJW25E5v0DSAQJYU2mIp59r0sBdNkOlH2A3PPqX+4gmJAI+PoyZmy8HkxCO29XSSddL+44L y7k2IGzQ==; Received: from [2001:4bb8:192:26e7:bcd3:7e81:e7de:56fd] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13Fv-00FQyS-Dv; Fri, 02 Dec 2022 10:26:56 +0000 From: Christoph Hellwig To: Andrew Morton , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org, Johannes Weiner Subject: [PATCH 3/7] hfs: remove ->writepage Date: Fri, 2 Dec 2022 11:26:40 +0100 Message-Id: <20221202102644.770505-4-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202102644.770505-1-hch@lst.de> References: <20221202102644.770505-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 6399318000D X-Stat-Signature: g1cxb9f68eee4i5gouqp9wxoyntb1s9n X-Rspamd-Server: rspam01 X-Spamd-Result: default: False [1.12 / 9.00]; R_MISSING_CHARSET(2.50)[]; BAYES_HAM(-2.48)[97.63%]; MID_CONTAINS_FROM(1.00)[]; FORGED_SENDER(0.30)[hch@lst.de,BATV@bombadil.srs.infradead.org]; R_DKIM_ALLOW(-0.20)[infradead.org:s=bombadil.20210309]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[14]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[dbb76fff442e09cb8719,7040,infradead.org,hch]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[infradead.org:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[lst.de]; FROM_NEQ_ENVFROM(0.00)[hch@lst.de,BATV@bombadil.srs.infradead.org] X-HE-Tag: 1669976823-946644 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and stop wiring up ->writepage for hfs_aops. Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner --- fs/hfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c index c4526f16355d54..16466a5e88b44b 100644 --- a/fs/hfs/inode.c +++ b/fs/hfs/inode.c @@ -173,12 +173,12 @@ const struct address_space_operations hfs_aops = { .dirty_folio = block_dirty_folio, .invalidate_folio = block_invalidate_folio, .read_folio = hfs_read_folio, - .writepage = hfs_writepage, .write_begin = hfs_write_begin, .write_end = generic_write_end, .bmap = hfs_bmap, .direct_IO = hfs_direct_IO, .writepages = hfs_writepages, + .migrate_folio = buffer_migrate_folio, }; /*