From patchwork Fri Dec 2 10:26:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13062592 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1370C4708D for ; Fri, 2 Dec 2022 10:27:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FCE16B0080; Fri, 2 Dec 2022 05:27:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 238936B0081; Fri, 2 Dec 2022 05:27:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DA8A6B0082; Fri, 2 Dec 2022 05:27:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E66ED6B0080 for ; Fri, 2 Dec 2022 05:27:12 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C2EF51A0E55 for ; Fri, 2 Dec 2022 10:27:12 +0000 (UTC) X-FDA: 80196988704.20.ED0000B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 773B920015 for ; Fri, 2 Dec 2022 10:27:12 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=TWvEKxe1; spf=none (imf03.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669976832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fqr9TW+rT8ValeXLVFOQSDtrNHXsSl7u56JKe2jXztI=; b=7MlWo4RAY9MFObagZWr0KUdPrFL3Vr3vbok4OqTeygprnr6lkOsj/NJtutjrMfMpLUhycJ gcD+xQNLNX/97mRbLh8qvAyWJGT3iYrCTG+UaElYja+xYZ9yShkchOfjfndMJjpZoWua5A MHgp0lmc56JpWRzYaSnF76HUwQE9cFw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669976832; a=rsa-sha256; cv=none; b=kEmGsxFKzaiRCz+Rw3Gj8SPSN7XO9vJUbtzN4HGsnzCGlILPiSNGD/pTMUy1n7UlG+InXL BqsfwlZaQ6I60dJHmWRut0yjCTTRtepvlU5evDWBAw8R5AVUpooyfJfA9q9P9qMBVlGKSs l3LT/y51y9hl63si399hhHsOBfto/Ak= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=TWvEKxe1; spf=none (imf03.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=fqr9TW+rT8ValeXLVFOQSDtrNHXsSl7u56JKe2jXztI=; b=TWvEKxe1hgaqaar0S3SdimrN6x CCDVFmRGCM1ggNXnG5FjJDcpDBjli7i4LD/ks900zzcj1gTmSm5Gec8vrJIJc0FAdbCn/oPYdx6Zt T05aBcXid3fSpkehDIgr1ssY1DY7NeoCM6NTgkF8Vti6BYts/hcAO9azLBFkGAkL3ItNAnApvXXyu BZ5KwzzO58NFGMAbVIIZUWGmHki7aOK6zFx1KMBI5NFt2H8SHg5srWFPDo3CeaHU/T3xDokLMAjJ4 ueFDVhrzFEEHXF9JZhYku8gRMyvySJf07CcRonjhN0xseuAoTI2jGFX2ZwGLSf2ZqyQh893fl2rar sG+xo6dA==; Received: from [2001:4bb8:192:26e7:bcd3:7e81:e7de:56fd] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13G4-00FR2o-7h; Fri, 02 Dec 2022 10:27:04 +0000 From: Christoph Hellwig To: Andrew Morton , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org, Dave Kleikamp , Johannes Weiner Subject: [PATCH 6/7] jfs: remove ->writepage Date: Fri, 2 Dec 2022 11:26:43 +0100 Message-Id: <20221202102644.770505-7-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202102644.770505-1-hch@lst.de> References: <20221202102644.770505-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 773B920015 X-Stat-Signature: etqmt8p3surz619e59f7pp59fyf79w8k X-Rspamd-Server: rspam01 X-Spamd-Result: default: False [0.81 / 9.00]; BAYES_HAM(-2.79)[99.11%]; R_MISSING_CHARSET(2.50)[]; MID_CONTAINS_FROM(1.00)[]; FORGED_SENDER(0.30)[hch@lst.de,BATV@bombadil.srs.infradead.org]; R_DKIM_ALLOW(-0.20)[infradead.org:s=bombadil.20210309]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[15]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[dbb76fff442e09cb8719,7040,infradead.org,hch]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[infradead.org:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[lst.de]; FROM_NEQ_ENVFROM(0.00)[hch@lst.de,BATV@bombadil.srs.infradead.org] X-HE-Tag: 1669976832-584845 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig Acked-by: Dave Kleikamp Acked-by: Johannes Weiner --- fs/jfs/inode.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c index d1ec920aa030a8..8ac10e39605081 100644 --- a/fs/jfs/inode.c +++ b/fs/jfs/inode.c @@ -264,11 +264,6 @@ int jfs_get_block(struct inode *ip, sector_t lblock, return rc; } -static int jfs_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, jfs_get_block, wbc); -} - static int jfs_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -355,12 +350,12 @@ const struct address_space_operations jfs_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = jfs_read_folio, .readahead = jfs_readahead, - .writepage = jfs_writepage, .writepages = jfs_writepages, .write_begin = jfs_write_begin, .write_end = jfs_write_end, .bmap = jfs_bmap, .direct_IO = jfs_direct_IO, + .migrate_folio = buffer_migrate_folio, }; /*