From patchwork Mon Dec 5 19:37:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13065036 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEDFCC4321E for ; Mon, 5 Dec 2022 19:37:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D2988E0002; Mon, 5 Dec 2022 14:37:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 582B78E0001; Mon, 5 Dec 2022 14:37:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 498978E0002; Mon, 5 Dec 2022 14:37:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3B1DA8E0001 for ; Mon, 5 Dec 2022 14:37:29 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 124DBA0844 for ; Mon, 5 Dec 2022 19:37:29 +0000 (UTC) X-FDA: 80209261818.10.6153738 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 6C808C0005 for ; Mon, 5 Dec 2022 19:37:28 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YZ0A0Jnp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670269048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=839Tn9IdUKD1bh/4wO2u5vVCxR5w23tzArKt5zK/zSI=; b=MgBLlCuWJ/vAOiWgGYe1KafG6ywNquBFlTwvAVa8Vx+dM3t2CZcJaYsJikeDuTqQzVS6BI 8hzikfVEIuKHwVjzneXg8US1e/A8T4r28BTJRGiH2lEjp9dgCOsalbwaLh3B6+RPthtbKN bt8Pp6NzJTeKJF6zjPO0j3hnKdv6ct0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YZ0A0Jnp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670269048; a=rsa-sha256; cv=none; b=0xrtmpSkGu3rqgGZ9itAnv22FpAh68hlQdBegi7piqswy7/xiz2kf/odzDtkTUc6EOpv85 uYsAMqH7Wi4cmeFaXKCa40CnPXGGYkZj3PcDIfgwU/t8kFu0gbTxhFCPwaDbHxpIZVl7jt 4UWFHyTeMy5ewPFz0b16E2ogCPXkBVY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670269047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=839Tn9IdUKD1bh/4wO2u5vVCxR5w23tzArKt5zK/zSI=; b=YZ0A0JnpGGAv9V+Aw2H3tVUl+qAXB/WtuKgXcGw+KXbuvXZzCAJdaZLay6O8Q73D100xOS H8wO690DirUBtFDYW5YU/mDFWeIwI4O2YCKKWo/VBnjwgd4EQc8PbEuEVqFVyl6gVUvpMm D8cMzxUBfCVDYv34mw0IPajpUakCU5M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-190-jwXJRswbMtG5Lezn7_olIw-1; Mon, 05 Dec 2022 14:37:24 -0500 X-MC-Unique: jwXJRswbMtG5Lezn7_olIw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2489686F12A; Mon, 5 Dec 2022 19:37:24 +0000 (UTC) Received: from t480s.fritz.box (unknown [10.39.193.244]) by smtp.corp.redhat.com (Postfix) with ESMTP id 475E920290A5; Mon, 5 Dec 2022 19:37:22 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, David Hildenbrand , Andrew Morton , Shuah Khan , Yang Li Subject: [PATCH mm-unstable v1 1/4] mm/gup_test: fix PIN_LONGTERM_TEST_READ with highmem Date: Mon, 5 Dec 2022 20:37:13 +0100 Message-Id: <20221205193716.276024-2-david@redhat.com> In-Reply-To: <20221205193716.276024-1-david@redhat.com> References: <20221205193716.276024-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spamd-Result: default: False [-2.39 / 9.00]; BAYES_HAM(-5.99)[99.98%]; R_MISSING_CHARSET(2.50)[]; MID_CONTAINS_FROM(1.00)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[redhat.com,none]; R_DKIM_ALLOW(-0.20)[redhat.com:s=mimecast20190719]; R_SPF_ALLOW(-0.20)[+ip4:170.10.133.0/24]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[redhat.com:+]; RCVD_COUNT_THREE(0.00)[4]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 6C808C0005 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ijyom9gxhoz37e1stzdr5nah7yiurixc X-HE-Tag: 1670269048-143954 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ... we have to kmap()/kunmap(), otherwise this won't work as expected with highmem. Fixes: c77369b437f9 ("mm/gup_test: start/stop/read functionality for PIN LONGTERM test") Signed-off-by: David Hildenbrand --- mm/gup_test.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/gup_test.c b/mm/gup_test.c index 0d76d9b4bb5a..33f431e0da60 100644 --- a/mm/gup_test.c +++ b/mm/gup_test.c @@ -4,6 +4,7 @@ #include #include #include +#include #include "gup_test.h" static void put_back_pages(unsigned int cmd, struct page **pages, @@ -297,10 +298,13 @@ static inline int pin_longterm_test_read(unsigned long arg) return -EFAULT; for (i = 0; i < pin_longterm_test_nr_pages; i++) { - void *addr = page_to_virt(pin_longterm_test_pages[i]); + void *addr = kmap_local_page(pin_longterm_test_pages[i]); + unsigned long ret; - if (copy_to_user((void __user *)(unsigned long)user_addr, addr, - PAGE_SIZE)) + ret = copy_to_user((void __user *)(unsigned long)user_addr, addr, + PAGE_SIZE); + kunmap_local(addr); + if (ret) return -EFAULT; user_addr += PAGE_SIZE; }