From patchwork Mon Dec 19 16:30:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13076857 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4465AC4332F for ; Mon, 19 Dec 2022 16:30:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5F138E0005; Mon, 19 Dec 2022 11:30:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B10108E0001; Mon, 19 Dec 2022 11:30:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D7C28E0005; Mon, 19 Dec 2022 11:30:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 919048E0001 for ; Mon, 19 Dec 2022 11:30:37 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2DAFDA0303 for ; Mon, 19 Dec 2022 16:30:37 +0000 (UTC) X-FDA: 80259594114.03.952C4D6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id EF1C312000A for ; Mon, 19 Dec 2022 16:30:34 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Li2Oknfd; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671467435; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iqzZDJr3eUwayKjs/1xitM2q4nRywOPqCiXpKwUBAdY=; b=BA6H1TjT8sxONCpPryYIgmdRLLKk0odS4H97IO5FSNglHjlrkXo/8hX6zyos0vj3jAaGUS v0YICpYoyAAHDuKR995UbeajinRriThrAGF4UX7i5ijGIBh27aQd3N+xgtCq5XeY4fVWBd 0gneBUHhcBE+L3+DW2zmT8SkvQ8cNPg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Li2Oknfd; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671467435; a=rsa-sha256; cv=none; b=b4TCUe57orXZCK0Lyt2dXgJ84fZOYfjEx2zAPdg7A7fuLo+8U413AndKhmWiribtqtsfNi VgM4U0v0cw8X+KCvvJ80jRo3rYvzmYGXidsH7FfxxzMDwg707cp2ZTQ/EuGGbMNkLomNFb G2hJYk6ajEPQDG/JJbk1/oXyxHR8K2o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671467434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iqzZDJr3eUwayKjs/1xitM2q4nRywOPqCiXpKwUBAdY=; b=Li2Oknfd0xytlZejCF6OtQthP+3L8sZzjOAmOtcQ1Mru/B1gnZHvyE2CfupoC3WuRu4ZeV A84txMFlr5rBgSNadt5CNqHMgW8fnAm6TP5iVwojor3lghxxpjhsDL0xXXTvy8tMYZ/82D cG20W1HniSPKpPaYsjlbX5PYWzmAy4I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-332-UNsY6G-3NzygpiX6OJ2yDw-1; Mon, 19 Dec 2022 11:30:29 -0500 X-MC-Unique: UNsY6G-3NzygpiX6OJ2yDw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0F8D21991C41; Mon, 19 Dec 2022 16:30:26 +0000 (UTC) Received: from t480s.redhat.com (unknown [10.39.194.120]) by smtp.corp.redhat.com (Postfix) with ESMTP id 202D340C1073; Mon, 19 Dec 2022 16:30:22 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, David Hildenbrand , Linus Torvalds , Andrew Morton , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Pitre , Jens Axboe , Pavel Begunkov Subject: [PATCH mm-stable RFC 2/2] mm/nommu: don't use VM_MAYSHARE for MAP_PRIVATE mappings Date: Mon, 19 Dec 2022 17:30:13 +0100 Message-Id: <20221219163013.259423-3-david@redhat.com> In-Reply-To: <20221219163013.259423-1-david@redhat.com> References: <20221219163013.259423-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Stat-Signature: 9wkfxh347jdbjhts6ge6cn9ck6bjnteu X-Rspam-User: X-Rspamd-Queue-Id: EF1C312000A X-Rspamd-Server: rspam06 X-HE-Tag: 1671467434-301382 X-HE-Meta: U2FsdGVkX1/xxpcUZYtbKDb1j+NnKJlsAowGR9ZLb4qWQ5o4A7vULpYFGlcX7q0EBb48WGDW0VuoiDmreABP7XP53z4G04kV8/uMVa9/MLS5hHBENcywVJhLuB52SehrAK9cCTdYKTLJLUtzT/cHrPvX6EFDAlwGF3s6tW4RLZPk1KNFVdJkngC7IDI1b2hUemXMD+2nHHqjm5Pn+1rx0eWZfzlY9nYR4tlA3/hBxy8Ft66UZFxUmuo0sREwAGCmGv4FMIPAdAO7kmmGGnLj3F5/DROjFHpaZHqePhKOyOFmTLdFwzIpshwPcK96ApDiTPZ3LOKbgRFR+nHEmZUoA8RcqQ79/ji1jba3H+8Onwf3Cd6coyNTe8zbpyBlp7E0MuZhS65+LOfVJPRs+k9Hpd/aENTsA9AahuP/Z4JizRIuXpXUUSO/wgpnZtLia7yVuzByc2r7Xh8g8QJ/mQQq44rH/HcsMLlPs5u4bkw8b6Vl2z7K2e/omWibgrYRfxtuF4VSSACfWc5ky/V51ru02U6ysGefKwO0AlFIPmXcsGb2V6JbKVOF6AZT0QkIWlYDBdVBm2dJHjQc5egm3fpbq+mdufXCxg3I1h8x+01H3kNoSluogNKovVAIQW6nwjzci5jDrHRTk0ebmiTFJkpwZMuu2qyCD8QEZUukrpdQSAvvrVzeo1Bm7WJA3XcVgvkpud76JMVaJk4+a95fk7zLw8yiYI1c3D1Yj+L/B3Rxz74UaaVbR/c4f0v9j0fVq2QJMS71Lb/qNo7Ouja4Hp98/Xerp8dIU9BsBZ0ZwXF+P5bb9aybJmHd2OZ/zdlR1ye2nt2I2NkEsLrrHc3ty4UQSIPKb7LRXc8O/SR/94KgoAcakUIBqy4imw9Ic1xAnWSPckL8cBtKNguavj+8q5lIzMgIKc5Wf2u7dcHMh1NaJmK3BLgGaXjdI2idaEdO5JofexNFghy1lD7837m4Q9M CSm1JN0j rAJpInOpAGlJXD19LTs2hLX3tlH9jkG1++LDHuleX1GAp7gDUByekszQPcuWPy6ErZinL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Let's stop using VM_MAYSHARE for MAP_PRIVATE mappings and use VM_MAYOVERLAY instead. Rewrite determine_vm_flags() to make the whole logic easier to digest, and to cleanly separate MAP_PRIVATE vs. MAP_SHARED. No functional change intended. Signed-off-by: David Hildenbrand --- include/linux/mm.h | 7 ++++++- mm/nommu.c | 51 +++++++++++++++++++++++++++------------------- 2 files changed, 36 insertions(+), 22 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 734d0bc7c7c6..c229eee6211c 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -276,7 +276,12 @@ extern unsigned int kobjsize(const void *objp); #define VM_MAYSHARE 0x00000080 #define VM_GROWSDOWN 0x00000100 /* general info on the segment */ +#ifdef CONFIG_MMU #define VM_UFFD_MISSING 0x00000200 /* missing pages tracking */ +#else /* CONFIG_MMU */ +#define VM_MAYOVERLAY 0x00000200 /* nommu: R/O MAP_PRIVATE mapping that might overlay a file mapping */ +#define VM_UFFD_MISSING 0 +#endif /* CONFIG_MMU */ #define VM_PFNMAP 0x00000400 /* Page-ranges managed without "struct page", just pure PFN */ #define VM_UFFD_WP 0x00001000 /* wrprotect pages tracking */ @@ -1374,7 +1379,7 @@ static inline bool is_nommu_shared_mapping(vm_flags_t flags) * ptrace does not apply. Note that there is no mprotect() to upgrade * write permissions later. */ - return flags & VM_MAYSHARE; + return flags & (VM_MAYSHARE | VM_MAYOVERLAY); } #endif diff --git a/mm/nommu.c b/mm/nommu.c index 6c4bdc07a776..5c628c868648 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -892,29 +892,36 @@ static unsigned long determine_vm_flags(struct file *file, unsigned long vm_flags; vm_flags = calc_vm_prot_bits(prot, 0) | calc_vm_flag_bits(flags); - /* vm_flags |= mm->def_flags; */ - if (!(capabilities & NOMMU_MAP_DIRECT)) { - /* attempt to share read-only copies of mapped file chunks */ + if (!file) { + /* + * MAP_ANONYMOUS. MAP_SHARED is mapped to MAP_PRIVATE, because + * there is no fork(). + */ vm_flags |= VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC; - if (file && !(prot & PROT_WRITE)) - vm_flags |= VM_MAYSHARE; + } else if (flags & MAP_PRIVATE) { + /* MAP_PRIVATE file mapping */ + if (capabilities & NOMMU_MAP_DIRECT) + vm_flags |= (capabilities & NOMMU_VMFLAGS); + else + vm_flags |= VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC; + + if (!(prot & PROT_WRITE) && !current->ptrace) + /* + * R/O private file mapping which cannot be used to + * modify memory, especially also not via active ptrace + * (e.g., set breakpoints) or later by upgrading + * permissions (no mprotect()). We can try overlaying + * the file mapping, which will work e.g., on chardevs, + * ramfs/tmpfs/shmfs and romfs/cramf. + */ + vm_flags |= VM_MAYOVERLAY; } else { - /* overlay a shareable mapping on the backing device or inode - * if possible - used for chardevs, ramfs/tmpfs/shmfs and - * romfs/cramfs */ - vm_flags |= VM_MAYSHARE | (capabilities & NOMMU_VMFLAGS); - if (flags & MAP_SHARED) - vm_flags |= VM_SHARED; + /* MAP_SHARED file mapping: NOMMU_MAP_DIRECT is set. */ + vm_flags |= VM_SHARED | VM_MAYSHARE | + (capabilities & NOMMU_VMFLAGS); } - /* refuse to let anyone share private mappings with this process if - * it's being traced - otherwise breakpoints set in it may interfere - * with another untraced process - */ - if ((flags & MAP_PRIVATE) && current->ptrace) - vm_flags &= ~VM_MAYSHARE; - return vm_flags; } @@ -952,9 +959,11 @@ static int do_mmap_private(struct vm_area_struct *vma, void *base; int ret, order; - /* invoke the file's mapping function so that it can keep track of - * shared mappings on devices or memory - * - VM_MAYSHARE will be set if it may attempt to share + /* + * Invoke the file's mapping function so that it can keep track of + * shared mappings on devices or memory. VM_MAYOVERLAY will be set if + * it may attempt to share, which will make is_nommu_shared_mapping() + * happy. */ if (capabilities & NOMMU_MAP_DIRECT) { ret = call_mmap(vma->vm_file, vma);