From patchwork Tue Dec 20 18:27:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 13078090 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA064C3DA7A for ; Tue, 20 Dec 2022 18:27:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B0A68E0005; Tue, 20 Dec 2022 13:27:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 19CA88E0001; Tue, 20 Dec 2022 13:27:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6D338E0005; Tue, 20 Dec 2022 13:27:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D81D18E0001 for ; Tue, 20 Dec 2022 13:27:11 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 85C73120651 for ; Tue, 20 Dec 2022 18:27:11 +0000 (UTC) X-FDA: 80263516662.11.4AFAD7E Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf11.hostedemail.com (Postfix) with ESMTP id BBEB940006 for ; Tue, 20 Dec 2022 18:27:09 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="P+POCPq/"; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671560829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+OTHapwSXF9jX+CGaarNe5ZZYPpmWxQHenWVZbs8G3o=; b=dwL012v9JdT/MBopTZzAmwEDQDcIRETSDnHBPbDH7xVj2mFxZMxi+Dauowcg8/JIdFrxlQ Dy8TA1axP2rVrg5AEqxQ9/Ds0vaJA87ZhThgcuCefoWqo+wmYj3hQsBAJpft7jxNa7lZM0 /kq1WY4DxWSxzZT5yMnWvWUWBKMHoow= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="P+POCPq/"; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671560829; a=rsa-sha256; cv=none; b=K8EvzCfEr4xNveIqE3mwF0wB7ZpPb6Rybcckge39cFDoGa0gAORUO7xeU9uFUqbk65y0Jg jOjfFAQtAkRYo0EGFJQca7fPrp62ufiFwxsnlgNbRU/5ymuB/579f8egkJp/lxPohOvgZo Dn7tnCK0QwrRGq3GCISBTtxX1cqJBfg= Received: by mail-lf1-f45.google.com with SMTP id b3so19934312lfv.2 for ; Tue, 20 Dec 2022 10:27:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+OTHapwSXF9jX+CGaarNe5ZZYPpmWxQHenWVZbs8G3o=; b=P+POCPq/xX3ozKp7CYneD0KUS2lmehapstKWeSkNpMRhLrBW1WEVQ7/tS5iJF1m4pZ KcO+9GEU7xFEbOJ06vY3cGqMHtU27p390VWaQtUTHDM/TxZl/TZg4xvcVMa5zY4urd/t 9cDLt2LQo4MI7gnkmFG1LN9cfILUe9we42b8B9ZFZDmCgPW3lNop1LmqdyjXhhssIT96 3Cv+6V+T/5FzftgtMASsly9FB/rxLmRgCMaBXVJp2X25lJGK6LyHOjydiVLh43NoMTgI Nq0FmwpUNnFi8H3SdTjDyhiFtUMqTAAP0xuI59Xf+i/KE0GUNpLIM2darvcA94yrVhZ+ x0hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+OTHapwSXF9jX+CGaarNe5ZZYPpmWxQHenWVZbs8G3o=; b=dkFEHagswRA4LZyp/wfeO/EVfzhnNa3gJkeD9ZhgVwyqG1dK5OJwfO1sRAQFuqoeoH V2xcz95fnG6/wQf2I3vSeoqBgz9eazh6AjtDthdRKhF0k+VAlhQ4ZxMnEN4VszZCkO27 jxRQLqi/zYpfDI8EaIaF8XYxXdjGbG8JBQhXjZRdaCBKGUbGpr2Milxtggco+MIsqk8N itTy3Bev+IVB2JbvE3ct1mq9zeYq3nQ+z8wmP8D+aOH1oLwn2qhFDu745CjQG0Bzbr7k eqdxpsfT9Rod4ingDFkw8q+Rk/CMnmkjzZ9n/flioMn/8+Uie2Gh34rZqTrMKdafQPjd kb+A== X-Gm-Message-State: ANoB5pl2MUa+O4YZ+WMxGyvXD60j6bS2ukEi69Oj29HpCGEHbHIYuvzI LpzQM8bSdsLUJF81M/m0M4M= X-Google-Smtp-Source: AA0mqf7SXylMWGmBiQaU3+6304aZUwaDM8HyTat6M0HTi0M/QuEGAD29hTD/lsaPdTr4lbhnBafM+w== X-Received: by 2002:a05:6512:21ca:b0:4b5:1e6c:785c with SMTP id d10-20020a05651221ca00b004b51e6c785cmr13913360lft.34.1671560828057; Tue, 20 Dec 2022 10:27:08 -0800 (PST) Received: from pc638.lan ([155.137.26.201]) by smtp.gmail.com with ESMTPSA id v17-20020a056512349100b004bc1dd05351sm1538176lfr.206.2022.12.20.10.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 10:27:07 -0800 (PST) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH 2/2] mm: vmalloc: Replace BUG_ON() by WARN_ON_ONCE() Date: Tue, 20 Dec 2022 19:27:04 +0100 Message-Id: <20221220182704.181657-2-urezki@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221220182704.181657-1-urezki@gmail.com> References: <20221220182704.181657-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BBEB940006 X-Stat-Signature: wty785jazb8haupcr8neknj5msa19dr7 X-HE-Tag: 1671560829-952965 X-HE-Meta: U2FsdGVkX19FDQKbKzuFbhm4b1C1ORjZvdYpp7Q9DR+mWiaCyFOwByaO8krG/ep6Jz1hXlc5VkFM8R++YsQc4g061tCSnxpOQx0tnyfmiNcPlSVYfVMMECo8nJuGBy5ig3fNVXN+t1IAeDP+VRIR0lKoZWHErujYjG66z66crIrPByT3wERZIUj1f6tzgSHYbTKudWzdXIfKZctt/JyIMalLoQ06oMHa/3c2jXqVdwrvkgBvVz2MNYYrL1O6dY8pAyFV5CcbWkjEgodf0OyHSayLpvUeGoUM87lKaZcFzbnWbduCst0ItFeutskYkELdMijCET2u1vQpcGoBKIO5p3TrSaCGzgAVc7fUnF41hhuxb12Crp2xJGETyNtPRipXt4UQ8JbmhRdHM7tqDSL4t6jnrt61oM58/KOqVekoakzS8OcxWAh/N+dqbrJh+QhUXGQReHADNfjsR3G3zR3BFoD0kkj7/GpOwuCdS3g7dCSZ4pZYvsMq6PNRebk3vsv5PH16qsG66Ipej1Yth9DqRobFh8AokEDJcClwwtb5OR34rQwBCrOLWzrpUQuEFMF/eqa82qei4qqiEmf2WkmL0BHImwUlAuxk0ax0ODigiMQZF+fZB1hkJislMEPLgZRWghVRAj2TTQzLA6ajkEOyF7Us3RTwMhxhJZhXwT/mSYEy2gZvnfhUk/o6ec3MKgLgUiatOOGbZSqZQG6yyU4B3A1OYKjowS9Wh0St1HJbt6v3I3Q7UXqAEuow76Cti1wyxKBcEantuXfo8ihJuEr4RQvlqu18PJIYngbNEvRfVFz6Y/5JJHTKWjy1WhQeQdEfqeJwg/no5yTdfwRwz1rlrOMzC5MzjTr5xnsBh4qHNX/PUTr1b0FmjntQ6qz8IeZu8uIQlmXDvvWBPFD5WD2e4HEw58aTy/jvorZ5KNkpOh7eCdkHgL7e+HJKj/VvQS0PsqhWDXs6DlQb17YCt3x YxgTaEC5 FHnRsrSLCCqkSdLZw8KbTQXKaOqnNB+70RsFO/mc6RtHufoWt/9yuoq2TxVs/90eNFAQPxUtxVNenhGrm2LmTr5qEfooV1guqw6LNzBHxSeg7NitkVDxihOuTXyC8gws565LQ7ZLMknJuLGzA2qbf4TNv9ANRGXJ99cua1JefzQOX75U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently a vm_unmap_ram() functions triggers a BUG() if an area is not found. Replace it by the WARN_ON_ONCE() error message and keep machine alive instead of stopping it. The worst case is a memory leaking. Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 0fc38c36e0df..e05a0dc79ac5 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2255,10 +2255,12 @@ void vm_unmap_ram(const void *mem, unsigned int count) } va = find_unlink_vmap_area(addr); - BUG_ON(!va); - debug_check_no_locks_freed((void *)va->va_start, - (va->va_end - va->va_start)); - free_unmap_vmap_area(va); + + if (!WARN_ON_ONCE(!va)) { + debug_check_no_locks_freed((void *)va->va_start, + (va->va_end - va->va_start)); + free_unmap_vmap_area(va); + } } EXPORT_SYMBOL(vm_unmap_ram);