From patchwork Wed Dec 28 19:42:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13083187 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A0AC4332F for ; Wed, 28 Dec 2022 19:42:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A3D18E0002; Wed, 28 Dec 2022 14:42:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2538D8E0001; Wed, 28 Dec 2022 14:42:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 143318E0002; Wed, 28 Dec 2022 14:42:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 059778E0001 for ; Wed, 28 Dec 2022 14:42:57 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C4B91804C2 for ; Wed, 28 Dec 2022 19:42:56 +0000 (UTC) X-FDA: 80292737952.06.4399281 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf12.hostedemail.com (Postfix) with ESMTP id 5327940005 for ; Wed, 28 Dec 2022 19:42:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZmaFVF7j; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of 3PpysYwYKCE0796t2qv33v0t.r310x29C-11zAprz.36v@flex--surenb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3PpysYwYKCE0796t2qv33v0t.r310x29C-11zAprz.36v@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672256575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=h66ZlJIW0sPnpY7cABzav3ob2j9zOJpX5LkgC0xA0/8=; b=cK2ZfBur4lxI8f7iMYCYrmiyKg9T6XmDdyLPqXbTcXd4aM6rBJWLnqNjXMwqELw0FJmyQf mTnCRA0y3zL6/O0895xYDGUpE5DvfdlMUI+GotxDfIn2ybmBnI4nDyd+VUoa+PIiPVD6F6 h8gR1TFF+wUDC0Je/lEbonu1arCl36A= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZmaFVF7j; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of 3PpysYwYKCE0796t2qv33v0t.r310x29C-11zAprz.36v@flex--surenb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3PpysYwYKCE0796t2qv33v0t.r310x29C-11zAprz.36v@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672256575; a=rsa-sha256; cv=none; b=3OVhCwkVj40RMn7/D7VvQ9alSMHHgx2k5Q/8ceFiV6yII8N9JOBdakQ6q7i9y0WKc6uTOU LgBQN3c6dytEpzNY0lzxxJcJRP7moKDr+rv4FhXGYMZKL3WTbySD/APZTjcM3CwGikYW6Y 8bNIrQ8s/JkXn2QprtyLdYplyKu4XoY= Received: by mail-yb1-f202.google.com with SMTP id a4-20020a5b0004000000b006fdc6aaec4fso18019782ybp.20 for ; Wed, 28 Dec 2022 11:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=h66ZlJIW0sPnpY7cABzav3ob2j9zOJpX5LkgC0xA0/8=; b=ZmaFVF7jonGinSfOfqJLrvexRkxJcgPqsnKMM2BWGIh/BVHh7PqXo08JdBFt3JvzDT MtFcfUdyqDiaFCLySq0/hKOSrDV1GcyYBXtmNsEtbbs0AD5T4KILU972sTh9LBVzvylG tQ34yld8u16qX7XcANjKxhlHCij158UtIOUP/9gRAC7H35s/1sJXhDZT3sMLn3/tZhV7 aWcN73j9+nlL33mr6ie5dvAYJUjVKshl6AviGRMeNglXhoCBBVDSmhZzyQClFEryL6aG E8UwArx1nYdxTy3CYrwtb/ObqUZ8XeDEoelJ/4aWBtjKXZWtTcThztS84KOf7idyfQVd fSSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=h66ZlJIW0sPnpY7cABzav3ob2j9zOJpX5LkgC0xA0/8=; b=SJa5V3AV2a96WB2XRQ802VQXHYZHiNp3LqprCOSzZvDhbi+xg4wZCghyOP6xvjZ0YX OWA/RsWKohHu3BYrxw/0eU4mh6hc8KCCkWdoBoT4y7wfc6gZ9g68NZ3y55pTej0uJA5w XkvL6piJodttUlXqdF+nWR5egirXKeaO7k5j3Xw9YvJSfU7BHoM7AUDsC7aEkgrWR6P3 bLT+T1nzsOuoSSUr+V8dLSsgoHI5C5kK1GrOj3FW3NTvaItnk8cNtVVV07YD5or5yM3f uvvOxas7wpx5O7m5huIAHyzoW8v/UNTwI058nwOi8UTD34SB+bWjkwdwKrFvl4UL1K3+ JKww== X-Gm-Message-State: AFqh2kquTdgFr2u/Kh2oeCRFu74GHIq6e2Vq8lEZmhKIz4pmzOBrxXb+ B+IYGlLgrt0CRN6sZKwOm/T2SGUkbQs= X-Google-Smtp-Source: AMrXdXvVoybg1IWCnNxBiUrrq4mqKVmvhjCYdrsqR+1uBXDBxNLu6NltWyq75pQsNEPLUw321kk56Lsqvsg= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:77b8:ecbc:954d:4461]) (user=surenb job=sendgmr) by 2002:a25:d496:0:b0:70c:4fa3:2cce with SMTP id m144-20020a25d496000000b0070c4fa32ccemr3787363ybf.539.1672256574382; Wed, 28 Dec 2022 11:42:54 -0800 (PST) Date: Wed, 28 Dec 2022 11:42:49 -0800 Mime-Version: 1.0 X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20221228194249.170354-1-surenb@google.com> Subject: [PATCH 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: hughd@google.com, hannes@cmpxchg.org, david@redhat.com, vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org, shy828301@gmail.com, pasha.tatashin@soleen.com, paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz, Liam.Howlett@Oracle.com, ccross@google.com, willy@infradead.org, arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com, bagasdotme@gmail.com, suleiman@google.com, steven@liquorix.net, heftig@archlinux.org, cuigaosheng1@huawei.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, surenb@google.com, syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5327940005 X-Stat-Signature: xddts3rdeinkcb1ja5ueznzgwg5e3wrj X-HE-Tag: 1672256575-578530 X-HE-Meta: U2FsdGVkX1/Wovun0HFqIeoUM+fS9iGqNT7/IRQp7jbeaSdOUFnuS0TEtonIyOefiSUZZvquzx/bMonVTYD1yp/Vf7J3/rfXBGgJ0pUEOSbzSherVtjm8OzbVOcNQwJBlZ9eSwFhxcpJZagPB9P4Pv5C6kM4XxwWJXZm1p50N25f0hhFMilmy0zxieICDn+47OKhvpwV8JnFW96WxIRxLsG3rJ36RoFEotcFL9/lskOdKnSI2Qsw5japvXIcthDumXgyOtjEiitEfMaCIwSm4eZK7wH+t4vIvR1mVeTyI0scxzDO2sfYl2d+WeCPF6ZqzcBEy7rbcLZxX2J15PJyDLEBuAHgPBZuTaW1sAdHjtIu2MhgBdOMP0sY0G7rj6a8QRG30W4jI4G4dc4b/UDHH6/Hkg0+PXM6ggkSTwtTUJJNtXWo+5991H9mtxgSNgjnakBmZ+y24h+CMmvyRgi6VMfB3LMDzpaJBAZ3jzq1pzFb/LhVnlg5zSN5QwNAJH8P6tA/d86XjuROfEZHUwaLz02lCkdihfsbr+JT3v3Bqc8Of5ngnZI2BGdVFKdX7nviQDTOOTyjICQ7gpmNrJS2iqT2/BLBGYOn2f3pG8FKbD/YZqcrjF5hsp73wH6ioWeEjUp6gmx1V2F7fQHHckvHQ/FCY+acW5+O5EZXEtL0uC245hIB1SrVPi96Fk11+a2Aj1P6ctRoMMd4Uqju77kNSLC4+9a4ESI0L7ON1vdH6t3g0ZHBW7YbLkATzU1xggGhV6lrNxkXgcd2U+kjOvMdQHomMDDTfMCN0tYOLaK9wULa0KswQgw8gGXJPV9HdfRipIjHqUeFxbm81yxHhOsrLdjPw+KQhk4IR/F97qB85vD54lqnWhADeRpHCU3kMQeHNmTM0YZL2873qwGaA+76AiOzS+1Uq/tYrmRlxsYt2YwV/gTPS6EiPcvBGc6S3LPZJgERBYyZYvCXNl3HmnE wsRSgMCJ k5JMsUB8IxzpbedVqBSxyGu6GhfuESyVNXUnNvbP1LXi9GV6X2dKtz5iZaliqX9WJ8pB1gQ1uZY0dTs6h4/jKw0UqvOtSFxGqMctdTQiIY76cKpohlRTLE5RV0Dt88yAxrgMpQ8LGOSsh0wkUU3vDcVUe5l4w+rEIPYWLNkqZsDufbds+LJIYTw6ZyNN1f0F6f9O/e+jY/nmsDcuwBO3WKrnxjD4b3bZHPRkRTl1AqXogppmw5QazzJvwijo4b2RbkuHcC5rRMOmlmlzOGUitFE75Sw4ckzqhanhhavWNI4PlOYJCXs3gQHke3tBlEzXpiGsLUBl9mi4rPM9mjUeTE/8L33nRjn34nq2HS3idfHG6cPIPx97dpVsHf9PmWFDfHm0Ma/EkbrbGfQhkveXQlxhTK4HfKucTCzRUUhK9jZKr7uOPpl7ZqeteJaecRn6IBEo4SI5bs3vpUNkGA+hlebC/s4uGjh2lj7YH5eUxJeBeJFVbyB+U4lZDPqB2Ua78+jOA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: free_anon_vma_name() is missing a check for anonymous shmem VMA which leads to a memory leak due to refcount not being dropped. Fix this by adding the missing check. Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming") Reported-by: syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com Signed-off-by: Suren Baghdasaryan Acked-by: David Hildenbrand --- include/linux/mm_inline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h index e8ed225d8f7c..d650ca2c5d29 100644 --- a/include/linux/mm_inline.h +++ b/include/linux/mm_inline.h @@ -413,7 +413,7 @@ static inline void free_anon_vma_name(struct vm_area_struct *vma) * Not using anon_vma_name because it generates a warning if mmap_lock * is not held, which might be the case here. */ - if (!vma->vm_file) + if (!vma->vm_file || vma_is_anon_shmem(vma)) anon_vma_name_put(vma->anon_name); }