From patchwork Thu Dec 29 16:10:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13083621 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4893BC4167B for ; Thu, 29 Dec 2022 16:11:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBDDA8E0007; Thu, 29 Dec 2022 11:10:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9644B8E0002; Thu, 29 Dec 2022 11:10:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71C478E0006; Thu, 29 Dec 2022 11:10:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 494258E0008 for ; Thu, 29 Dec 2022 11:10:59 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2360280E96 for ; Thu, 29 Dec 2022 16:10:59 +0000 (UTC) X-FDA: 80295832638.23.0EAEFD7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id A6152C0013 for ; Thu, 29 Dec 2022 16:10:57 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=t1S2jL2D; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+e05b48f8d7082ec3c215+7067+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e05b48f8d7082ec3c215+7067+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672330257; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fEUbsjBI9KXdP6pghJ78AVl7+BFXIZGKll0p9tWCLUk=; b=P1haGkTr8zPyrzIsDL5gXcW7dlWOYf6dEaMLUv2VUie/OLXm50+CxIM12QkaqnyS70Vkj4 HS9VEn7K5L9p3BDYqP3WFHAQrpFsgWkEjs61XYsHRSuXQP3IOZCwnKb9ivvfoggnmDaARi kWtbs2GsjFGgrWm2oAkzHbpLhkKw5xA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=t1S2jL2D; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+e05b48f8d7082ec3c215+7067+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e05b48f8d7082ec3c215+7067+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672330257; a=rsa-sha256; cv=none; b=bISdRc/fBt2aVRL0aOtrow0Ybnfe3V/LqQciHX7c4t36xo/crFEqRX9a1NJ6s0+Z/c7LvP 5mSAYZNNuyl44uk9vqMD755klRJM8RQUB1r3xxth3IIuO7d1WUY5ZzKhf6SaSWmA5JfOGI wgxo6qowRTpZ3uZDiBiG+KVJOCh0mRc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=fEUbsjBI9KXdP6pghJ78AVl7+BFXIZGKll0p9tWCLUk=; b=t1S2jL2DHoW16PA0jk/pbHQHDg RBs4GhrpF9YeRdVoZ5tq9A1aPdJeOjq91lfo7o5iKcunokcstvPbjfOb5C1qHOTZBoAGzMEgZ25d9 C5o7gFDbOXlZVoosJgILi0a9I3LR4lGcXGGPpDxMY8Z08Fs+hik9wVwCAUkCmR2OV7rxGJJyr2hjp Zv4kGbTY2mD5jY+OJ8lwVOyAR4ZX1bDl+ikdrDdlU07hOw7f3AsQUBG1SNmOv77SPXjK1JIImv2No Dbh0w8jo37mco9XgGK5mLl24utTvSDtaTj3J5LiN5/5CGoVanfP2Q7XBUN+yCvVYGXOsn3vy9A0Al FxMX+glA==; Received: from rrcs-67-53-201-206.west.biz.rr.com ([67.53.201.206] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pAvUK-00HKL2-18; Thu, 29 Dec 2022 16:10:36 +0000 From: Christoph Hellwig To: Andrew Morton , "Theodore Ts'o" , Jan Kara , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , "Matthew Wilcox (Oracle)" Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org Subject: [PATCH 1/6] fs: remove an outdated comment on mpage_writepages Date: Thu, 29 Dec 2022 06:10:26 -1000 Message-Id: <20221229161031.391878-2-hch@lst.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221229161031.391878-1-hch@lst.de> References: <20221229161031.391878-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A6152C0013 X-Stat-Signature: yukrskou1aiarza47oduwgbkqxh4bf7z X-HE-Tag: 1672330257-825957 X-HE-Meta: U2FsdGVkX18l7veJe4l9uyYH1r3zqmM2ukYmdeHdJrOoJs7eOVFVKP3i4e9bL6pgJ6IXUB814UxlFzboebcirj3okb1Y8hm4EN3lyKh2Z4R38DnZIVREhZsZ/RNSj8dBOMRzRr1kA8l1kqeIn1jGLsmh+AqqhBqcRe7J/GmpuxQZ/uNRA7dg4eBHdyA2QuSgIne8hspmutcmi/fBCgHIruiWBsC7pIBRRattjM47InnXpAan0vcSwmq28GQFjHq3o793CQEoPFIgbyWHupyRl26trOenQFN2Hi06NryfFyfGPRgVAXKqOLUsQHU+HlekZKoFddnjC4E0boP7rmYvRSNsq7nloXlqSysVWdBkif50LyhEOcmQeYxUgvTGeXvVVrCuiQ9G9/HjfvVFeMK0xn0smymlqJfjq/3SNjRQVyvwUwxh5kcftmTuQ1XVJt3yjp1XS5hMhQ4JqdfSqfwEz19XCcNuyDRVD5TDVwTrApr1VaxKyKKex3yV8t4M/LluEYu1loMmm9vueOGyEy7Fp8Euwq3kpzXtmAyWmnlQgvLJVb+tEgKWRVvINS3LTYitGxoevFN2S3Z6BPq0ChSexIrIdcRZk/C54r3fKRyRMBpn2UkqS+3YGAR8X/XuBSdceD9iKL6XNym6eLH4vWwNRR4TGP3kc9GDqP6OeEypQ23F7rLru3OIDvbmXSmh6F1pU4QY4bNs+BOz8PoC3kY3065rOmil3N3QzmwqLDFZ7a/4VKjTtMMsCN42F6AKtfvGIST95fCL6cpinTiyISGyyY7c5u3AYEwGY5FUEOXGfUYrVxeitVb6Q11YmO3PNDsci3tycLcAHWYGlVldGUV3VoN2MtcRgaTuowf3fyV6/h5wdNrfpy2VN2Pv0kDiOlSlDto++2deWH2j9SlzB6mukarm9MDzs1A+UtewBVuVTbm6c6WJpF4OQ6jtcN8lVtsCFHoCNAaDqDlC/00Olwv IuTvguHy dc+PIZWADwpKgAwMvBLi+lkOnymZtgeSgNrqnXzE65IEdrgsWbCqOlig0SH1VWsyslemsWB90l1wcmN8tN2eSkF/JP19Y3Z02afnXwGEdrnoYyycU+ujASw738vDY8YzvBMqy+qIMOHOqOj6ZdB1eiv9Cui19me9sDP2eeuKTGNGh+Y9Uz3CFr01GgRD+YbQG88bqcL2Ww+a4Ix007/j9XeJGBxZ+3pIha/OjSyhCf2J6EfA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: mpage_writepages doesn't do any of the page locking itself, so remove and outdated comment on the locking pattern there. Signed-off-by: Christoph Hellwig Reviewed-by: Jan Kara --- fs/mpage.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/fs/mpage.c b/fs/mpage.c index 0f8ae954a57903..910cfe8a60d2e4 100644 --- a/fs/mpage.c +++ b/fs/mpage.c @@ -641,14 +641,6 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc, * * This is a library function, which implements the writepages() * address_space_operation. - * - * If a page is already under I/O, generic_writepages() skips it, even - * if it's dirty. This is desirable behaviour for memory-cleaning writeback, - * but it is INCORRECT for data-integrity system calls such as fsync(). fsync() - * and msync() need to guarantee that all the data which was dirty at the time - * the call was made get new I/O started against them. If wbc->sync_mode is - * WB_SYNC_ALL then we were called for data integrity and we must wait for - * existing IO to complete. */ int mpage_writepages(struct address_space *mapping,