From patchwork Wed Jan 4 23:11:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nhat Pham X-Patchwork-Id: 13089188 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04F3DC54E76 for ; Wed, 4 Jan 2023 23:11:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9669A900008; Wed, 4 Jan 2023 18:11:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82A36900002; Wed, 4 Jan 2023 18:11:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60857900008; Wed, 4 Jan 2023 18:11:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4CE9E900002 for ; Wed, 4 Jan 2023 18:11:35 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1CFA7C0370 for ; Wed, 4 Jan 2023 23:11:35 +0000 (UTC) X-FDA: 80318665350.28.EED1645 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf05.hostedemail.com (Postfix) with ESMTP id 6095C10000B for ; Wed, 4 Jan 2023 23:11:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="MKKIREX/"; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672873893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FG5G46Dbq/DHdzwesOF9acAVNcEs0Ihso0tlt5RXEDY=; b=Uh/oPzRCsAUDxy2h4tVEgPPSfT4bdS55DiNxwOwuOe03NoKl87IR2qEwT0xGYrzXrQAynu 4ZuKPRykAmmnVGVFMD0efjdUTgVw2wWJbECAeGo96erkQZfSA+4mZRkQSv1w3DO8NCdXaL E/O7R1pB5lx95KPWq1JvZI0MQT+IrP4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="MKKIREX/"; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672873893; a=rsa-sha256; cv=none; b=XqGEml6NoT3GbE9cxpxIV3AhBnT42dLW3fD69COicXkic38Y15WbV1LkCMcPfznzSZR0dZ pT6OV2xWJSURklYLUJBxT8UnHeUfDdkivuZ2nMFf6VbJZCAw9ELhDXskqN8s9dBBlj32Fh QdR1KnCq2B5Gpb+ze8T3582evCXYlhQ= Received: by mail-pf1-f173.google.com with SMTP id k137so19240385pfd.8 for ; Wed, 04 Jan 2023 15:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FG5G46Dbq/DHdzwesOF9acAVNcEs0Ihso0tlt5RXEDY=; b=MKKIREX/08pI6E8vkOoofFwjY3M8sB7K04FWqTLmNuPd9Qk7lcXPgxWLqg3+XZl50o ebC7yxKLsuflJjmMtNcutEfbRM5dzNXbggfomOQS+47VXV9D34YU76vOy1tgDj2FfOsP xEDtQfaRY9jXuIqxfHT1nkQX/LdUUQwGdEa0ZzXlmlo1vTxQaENn9+OTnlmXZhz+RMtT jyYcr44TErf5ycQgSGXCxfiYBDY8P60OY9zP4GTgNqS+KUzYNYL8jRxtV+Dx82yLpEoC nrZ8RcOxTsr1VdeWApqwuS+/659pl/AqoSgpfOrWFcWdN0/alvrhk2SKnsJ65y+IMgEr Hh4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FG5G46Dbq/DHdzwesOF9acAVNcEs0Ihso0tlt5RXEDY=; b=00RX7b343K9l5OZBOQbnaskhUOWIQZGpsEAIqFmXxLTOYCwKSf26hP3Cs3TAck/Mbh 4aQxpfdppsjWd35uGS27r2n/bp3rwufPUvQJPYkzUb3zrfJzxcU1Aga+th8ktKTP4RQ4 UqG9SqQrEmpGGrlltjsg66jM3R/8nqoK5rpoP0bqDa65N8izVUUHRvARr/wK9Y0PpYfs 33dv6vHnot8naySsUuXLjFEeVSLsgihJYSQBDexA+8ezi/ZS3tzb+2En9wogmkvAROjs uz1L8bnLsvIchLSdfbgJFnDXMmxxACwhUUMAB/eNC97PQ9EoieheHz0EJ71hlb+7oWj9 aa9Q== X-Gm-Message-State: AFqh2kpf4h8g1qHfhPXWPW+IPXVBWHapsAkXd5SaGnVLe/Tc3sQEm/vT EKPEtZ3+x7MOx6rWIcR1z7Y= X-Google-Smtp-Source: AMrXdXtdeR2vM4/s95j38EzQBAXAvDd3YtVoBBZG2BgXsnWFdpgfcepFXTND04fapdK9UWKFmcMj+w== X-Received: by 2002:a05:6a00:4107:b0:582:f34a:266a with SMTP id bu7-20020a056a00410700b00582f34a266amr3750019pfb.23.1672873892298; Wed, 04 Jan 2023 15:11:32 -0800 (PST) Received: from localhost (fwdproxy-prn-000.fbsv.net. [2a03:2880:ff::face:b00c]) by smtp.gmail.com with ESMTPSA id w187-20020a627bc4000000b0058119caa82csm18389147pfc.205.2023.01.04.15.11.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 15:11:31 -0800 (PST) From: Nhat Pham To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, willy@infradead.org, kernel-team@meta.com Subject: [PATCH v5 3/3] selftests: Add selftests for cachestat Date: Wed, 4 Jan 2023 15:11:27 -0800 Message-Id: <20230104231127.2634648-4-nphamcs@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230104231127.2634648-1-nphamcs@gmail.com> References: <20230104231127.2634648-1-nphamcs@gmail.com> MIME-Version: 1.0 X-Stat-Signature: hw38du11yitrd7zydrq1oy9etyffnts8 X-Rspam-User: X-Rspamd-Queue-Id: 6095C10000B X-Rspamd-Server: rspam06 X-HE-Tag: 1672873893-722406 X-HE-Meta: U2FsdGVkX18ifr+jI0IeIVUAoKkdBrY3qUUfZjggPV4Uy0DdgoIcXcq8e9M1InhJYd1mBClI42YHrNQwi2VFyRVBJO+CNu5BKeyk7jdpMF4bTKFPy8j1fEZeid65oKhdAflhu2D89UugDfFbGWcmp+L1iPYEKKHjq4UDpuAlpXTwaWrmqWJwedjT+XyaRiDCRrU7WmxpYUD5MFFw7Hc1evph7WvobefKcKv4EgOnuCnS16kwQhVHcqpmS8JCVf3WLPuxKn6xK3Dv9QXTkN80rzAAaUubK5bjiCX9DQmiU8jozHc5a+Azc+f9vtXLxeQi00F/dcuzgZ7vToFt+f+kIP5Y6D76pMuxXnyhv4iElkqFM73hw1I1ymR+moled0Y+Hgf5qj+UNAMBLuoW2VTzoKmh0gRJYnFYmYMlAetH58iWbpg9bXdvra2Q5YoEsGaNa7ITPdvSgdNNe0DGCW0Jy3HtADuPmnjz1RSRU6EKrCFALOk5wPZtA1Z+Mni62G66+kamHeyN/qrv6HPtgGcUlpGUNWayeZnhEXtGAj46xtGW/8XS6G6eJRYjkOUmONFZKYgwv28Vz7hiKgVIcEnIXB4COFGwFguI6rk+Yi4b81XNP22MSJJJXe+Mf43SWUoL0C3yKYLaQRQo0VdImfiP+VextBFi1yGlybAdHTBpbgjvxqKZ5HLpb5VCJ8wkrrH3DJrcIxebH9UnD74gIC7GtwLilp5v/037nizzr79Q6u7NyUmbumthLjTJbS5lSfU6uSA8CU+Y3XlqcxA2k5eizs2LJAhlEtlKSdZFHMVK+KK1lOhI+QlKAQiIlZOLPtWFgZbUztqp4JDff7jqIgdRHnhKIWyzXc2QHmpBFYUyLMIczhgbl1ZWCjgXj6rHkMdW8RS8rHn482HH504SF6zcBMRB4PkGc7okkYgZztnRG330+QDDos7RCrD43gV/imqzmsJ5xl80g3cv0l8B0L7 8ZLEGfE6 bf+EV7ELm60y5DHnt8eIoL7lkLPNzS4n+q2eK539hHjXUgb1qf47vJQ0blQYbJpApWXvBV89C5H5Hd1904g/L/EPtbIRY2bZSXRd9zebc4JhnqRsjZUpY+d/CeXQGePhDM8/U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Test cachestat on a newly created file, /dev/ files, and /proc/ files. Also test on a shmem file (which can also be tested with huge pages since tmpfs supports huge pages). Signed-off-by: Nhat Pham --- MAINTAINERS | 7 + tools/testing/selftests/Makefile | 1 + tools/testing/selftests/cachestat/.gitignore | 2 + tools/testing/selftests/cachestat/Makefile | 8 + .../selftests/cachestat/test_cachestat.c | 259 ++++++++++++++++++ 5 files changed, 277 insertions(+) create mode 100644 tools/testing/selftests/cachestat/.gitignore create mode 100644 tools/testing/selftests/cachestat/Makefile create mode 100644 tools/testing/selftests/cachestat/test_cachestat.c diff --git a/MAINTAINERS b/MAINTAINERS index a198da986146..792a866353ec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4552,6 +4552,13 @@ S: Supported F: Documentation/filesystems/caching/cachefiles.rst F: fs/cachefiles/ +CACHESTAT: PAGE CACHE STATS FOR A FILE +M: Nhat Pham +M: Johannes Weiner +L: linux-mm@kvack.org +S: Maintained +F: tools/testing/selftests/cachestat/test_cachestat.c + CADENCE MIPI-CSI2 BRIDGES M: Maxime Ripard L: linux-media@vger.kernel.org diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 0464b2c6c1e4..3cad0b38c5c2 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -4,6 +4,7 @@ TARGETS += amd-pstate TARGETS += arm64 TARGETS += bpf TARGETS += breakpoints +TARGETS += cachestat TARGETS += capabilities TARGETS += cgroup TARGETS += clone3 diff --git a/tools/testing/selftests/cachestat/.gitignore b/tools/testing/selftests/cachestat/.gitignore new file mode 100644 index 000000000000..d6c30b43a4bb --- /dev/null +++ b/tools/testing/selftests/cachestat/.gitignore @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0-only +test_cachestat diff --git a/tools/testing/selftests/cachestat/Makefile b/tools/testing/selftests/cachestat/Makefile new file mode 100644 index 000000000000..fca73aaa7d14 --- /dev/null +++ b/tools/testing/selftests/cachestat/Makefile @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0 +TEST_GEN_PROGS := test_cachestat + +CFLAGS += $(KHDR_INCLUDES) +CFLAGS += -Wall +CFLAGS += -lrt + +include ../lib.mk diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c new file mode 100644 index 000000000000..3f5cd5695c51 --- /dev/null +++ b/tools/testing/selftests/cachestat/test_cachestat.c @@ -0,0 +1,259 @@ +// SPDX-License-Identifier: GPL-2.0 +#define _GNU_SOURCE + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "../kselftest.h" + +static const char * const dev_files[] = { + "/dev/zero", "/dev/null", "/dev/urandom", + "/proc/version", "/proc" +}; +static const int cachestat_nr = 451; + +void print_cachestat(struct cachestat *cs) +{ + ksft_print_msg( + "Using cachestat: Cached: %lu, Dirty: %lu, Writeback: %lu, Evicted: %lu, Recently Evicted: %lu\n", + cs->nr_cache, cs->nr_dirty, cs->nr_writeback, + cs->nr_evicted, cs->nr_recently_evicted); +} + +bool write_exactly(int fd, size_t filesize) +{ + char data[filesize]; + bool ret = true; + int random_fd = open("/dev/urandom", O_RDONLY); + + if (random_fd < 0) { + ksft_print_msg("Unable to access urandom.\n"); + ret = false; + goto out; + } else { + int remained = filesize; + char *cursor = data; + + while (remained) { + ssize_t read_len = read(random_fd, cursor, remained); + + if (read_len <= 0) { + ksft_print_msg("Unable to read from urandom.\n"); + ret = false; + goto close_random_fd; + } + + remained -= read_len; + cursor += read_len; + } + + /* write random data to fd */ + remained = filesize; + cursor = data; + while (remained) { + ssize_t write_len = write(fd, cursor, remained); + + if (write_len <= 0) { + ksft_print_msg("Unable write random data to file.\n"); + ret = false; + goto close_random_fd; + } + + remained -= write_len; + cursor += write_len; + } + } + +close_random_fd: + close(random_fd); +out: + return ret; +} + +/* + * Open/create the file at filename, (optionally) write random data to it + * (exactly num_pages), then test the cachestat syscall on this file. + * + * If test_fsync == true, fsync the file, then check the number of dirty + * pages. + */ +bool test_cachestat(const char *filename, bool write_random, bool create, + bool test_fsync, unsigned long num_pages, int open_flags, + mode_t open_mode) +{ + size_t PS = sysconf(_SC_PAGESIZE); + int filesize = num_pages * PS; + bool ret = true; + long syscall_ret; + struct cachestat cs; + + int fd = open(filename, open_flags, open_mode); + + if (fd == -1) { + ksft_print_msg("Unable to create/open file.\n"); + goto out; + } else { + ksft_print_msg("Create/open %s\n", filename); + } + + if (write_random) { + if (!write_exactly(fd, filesize)) { + ksft_print_msg("Unable to access urandom.\n"); + ret = false; + goto out1; + } + } + + syscall_ret = syscall(cachestat_nr, fd, 0, filesize, + sizeof(struct cachestat), &cs, 0); + + ksft_print_msg("Cachestat call returned %ld\n", syscall_ret); + + if (syscall_ret) { + ksft_print_msg("Cachestat returned non-zero.\n"); + ret = false; + goto out1; + + } else { + print_cachestat(&cs); + + if (write_random) { + if (cs.nr_cache + cs.nr_evicted != num_pages) { + ksft_print_msg( + "Total number of cached and evicted pages is off.\n"); + ret = false; + } + } + } + + if (test_fsync) { + if (fsync(fd)) { + ksft_print_msg("fsync fails.\n"); + ret = false; + } else { + syscall_ret = syscall(cachestat_nr, fd, 0, filesize, + sizeof(struct cachestat), &cs, 0); + + ksft_print_msg("Cachestat call (after fsync) returned %ld\n", + syscall_ret); + + if (!syscall_ret) { + print_cachestat(&cs); + + if (cs.nr_dirty) { + ret = false; + ksft_print_msg( + "Number of dirty should be zero after fsync.\n"); + } + } else { + ksft_print_msg("Cachestat (after fsync) returned non-zero.\n"); + ret = false; + goto out1; + } + } + } + +out1: + close(fd); + + if (create) + remove(filename); +out: + return ret; +} + +bool test_cachestat_shmem(void) +{ + size_t PS = sysconf(_SC_PAGESIZE); + size_t filesize = PS * 512 * 2; /* 2 2MB huge pages */ + int syscall_ret; + off_t off = PS; + size_t compute_len = PS * 512; + char *filename = "tmpshmcstat"; + struct cachestat cs; + bool ret = true; + unsigned long num_pages = compute_len / PS; + int fd = shm_open(filename, O_CREAT | O_RDWR, 0600); + + if (fd < 0) { + ksft_print_msg("Unable to create shmem file.\n"); + ret = false; + goto out; + } + + if (ftruncate(fd, filesize)) { + ksft_print_msg("Unable to trucate shmem file.\n"); + ret = false; + goto close_fd; + } + + if (!write_exactly(fd, filesize)) { + ksft_print_msg("Unable to write to shmem file.\n"); + ret = false; + goto close_fd; + } + + syscall_ret = syscall(cachestat_nr, fd, off, compute_len, + sizeof(struct cachestat), &cs, 0); + + if (syscall_ret) { + ksft_print_msg("Cachestat returned non-zero.\n"); + ret = false; + goto close_fd; + } else { + print_cachestat(&cs); + if (cs.nr_cache + cs.nr_evicted != num_pages) { + ksft_print_msg( + "Total number of cached and evicted pages is off.\n"); + ret = false; + } + } + +close_fd: + shm_unlink(filename); +out: + return ret; +} + +int main(void) +{ + int ret = 0; + + for (int i = 0; i < 5; i++) { + const char *dev_filename = dev_files[i]; + + if (test_cachestat(dev_filename, false, false, false, + 4, O_RDONLY, 0400)) + ksft_test_result_pass("cachestat works with %s\n", dev_filename); + else { + ksft_test_result_fail("cachestat fails with %s\n", dev_filename); + ret = 1; + } + } + + if (test_cachestat("tmpfilecachestat", true, true, + true, 4, O_CREAT | O_RDWR, 0400 | 0600)) + ksft_test_result_pass("cachestat works with a normal file\n"); + else { + ksft_test_result_fail("cachestat fails with normal file\n"); + ret = 1; + } + + if (test_cachestat_shmem()) + ksft_test_result_pass("cachestat works with a shmem file\n"); + else { + ksft_test_result_fail("cachestat fails with a shmem file\n"); + ret = 1; + } + + return ret; +}