From patchwork Thu Jan 5 12:52:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 13089805 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56978C3DA7D for ; Thu, 5 Jan 2023 12:56:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65FDC900004; Thu, 5 Jan 2023 07:56:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 592DD900003; Thu, 5 Jan 2023 07:56:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D5E3900006; Thu, 5 Jan 2023 07:56:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0FCE7900004 for ; Thu, 5 Jan 2023 07:56:47 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C616340C9E for ; Thu, 5 Jan 2023 12:56:46 +0000 (UTC) X-FDA: 80320744812.13.02C32DC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 28B0D40004 for ; Thu, 5 Jan 2023 12:56:45 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MJE2ZRuJ; spf=pass (imf01.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672923405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=C8n9DE0ruCcCCK7cY6ZY83QBYvGpdJ8qqUIL+bP6IWU=; b=RcbuMJ+PS7+AycecuFcxdeEAiV3cdeH/k5Chekn+0ZWdxRMhTvhVN+TqDgeK7ECzW5xux8 7YtexnPFp6L0XqAER/pH6bD1sA0u2CBTTL3AVDvRYQodP2LlVSFa5qke1VTmf+DNoCE673 QYYCGzXkbnSd8/j86MVwrQA9Lcw3PsE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MJE2ZRuJ; spf=pass (imf01.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672923405; a=rsa-sha256; cv=none; b=e2lYQwU3d8ug++h5FPQvHnn6z0+jJ3oiCh/JbI2YHAcZeLrGxxaY4l5QmtjxThmrci3wOI NT8GE9iMbTrAoHv+jLJ3ISVmWXBf6cmeBSRoW1hZDq//DL2kUTP/pJNqlCXvgK+JOhhYtb CN3+iIu+QC0biYLciDoNnMdlrVDLyuc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672923404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=C8n9DE0ruCcCCK7cY6ZY83QBYvGpdJ8qqUIL+bP6IWU=; b=MJE2ZRuJLAKEd6/4/ypjvTcV4oHeHCXYJghxQiceC/Eo8dHTen94zSh+sn+gK9JmVWsqgV F+c3VDTnXgHhgRbFeNUoyD7VBigG3ZD2CkTpnVq6kZ5SN48TAhcY9sAAnKlVt459bI+cRU DGo2WIS5le0gYMRuGtp+b1y2JIZy9lU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-120-zOn_0ctvMduyru0HaogF3g-1; Thu, 05 Jan 2023 07:56:41 -0500 X-MC-Unique: zOn_0ctvMduyru0HaogF3g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A49B8802C1C; Thu, 5 Jan 2023 12:56:40 +0000 (UTC) Received: from tpad.localdomain (ovpn-112-2.gru2.redhat.com [10.97.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3529E53A0; Thu, 5 Jan 2023 12:56:40 +0000 (UTC) Received: by tpad.localdomain (Postfix, from userid 1000) id A7E8340502F46; Thu, 5 Jan 2023 09:54:47 -0300 (-03) Message-ID: <20230105125248.971432211@redhat.com> User-Agent: quilt/0.66 Date: Thu, 05 Jan 2023 09:52:24 -0300 From: Marcelo Tosatti To: atomlin@atomlin.com, frederic@kernel.org Cc: cl@linux.com, tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org, pauld@redhat.com, neelx@redhat.com, oleksandr@natalenko.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Marcelo Tosatti Subject: [PATCH v13 6/6] mm/vmstat: avoid queueing work item if cpu stats are clean References: <20230105125218.031928326@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 28B0D40004 X-Stat-Signature: zstbqom3etzoa5casyu376ezqp1hszd1 X-Rspam-User: X-HE-Tag: 1672923405-30864 X-HE-Meta: U2FsdGVkX19uRBo8X4FFh06xKaPdHbfgcbY0NbjLNKH9szPIfgla6dUQOxqkItus0zG5MnCFfijKyaOHIiWboAA0YhEgmJJ5Fh4ZAhJuLEeJ3mLnklw57wKqXsAJQ0T+NA/46pXhcjkhlrPHWWUSEZ+xn81sDQDUFj2v8FSV3hB3wjRAn1odsoZQZufz1z3ajjsSLUdakdxbmJEigVk7BjlYwM306yZ2ivTvA5Nx7rXOVHU+wub0vziOvppnhPFhv/eAlteM0EwhnjzT5k/9ORPHiEOK3dGz8fXzZglaE1qieDxwL1Sa2B6llJNTaDphnA3PlZJ5Sr89i25ZYTAWT24oNmFx4pfVyKcqhHYvSDH/SCzKFKry45cuWTSCXmYR90BoVQMZRuIICsgntoLHfamVURxU92MwKXELk2I2Qffy3utwZh9V0+tQkD76XQGuHiK62vgK17go1Zzx/IFUGNR4L6FJ2w8pycLCfKeN4iUYYMS1EvlLymFJtrnyzNzlrsiveLbL/ObPsQ0S/Gw4RJ7qW9HXehYcsQCedYJ/QlcFXYVoI6uA+gQro0V7RsWky1/PqIZHKDY4U6pkIXkwe2mijf5hf5vEfcDlA2KDXSdNYNXrfHFNb6faiF9z3U0waOZYnySpwtW6CartmnMH/ovckYVSZuNxuvVpoDiASbfb+7Rk1UYRt4tGoDcjiw+oc+maRTF5ZvA5hjsRstPyG0K9zV0CG0vVatoE0WLVjxjWIEyMrjuKvttgcAnEepgWR+M06EPaygEE8FFrXEo1y12w0MPiy10Hh9+lIko8xodnLEPUNDrlMsKLPRXUc6qojVbiH/VJ0v/suu6If1xbeMX6Ckxv3XFZkYwAK9D8QaShXjVghJ4gYQxSyi3MPoDh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It is not necessary to queue work item to run refresh_vm_stats on a remote CPU if that CPU has no dirty stats and no per-CPU allocations for remote nodes. This fixes sosreport hang (which uses vmstat_refresh) with spinning SCHED_FIFO process. Signed-off-by: Marcelo Tosatti Index: linux-2.6/mm/vmstat.c =================================================================== --- linux-2.6.orig/mm/vmstat.c +++ linux-2.6/mm/vmstat.c @@ -1931,6 +1931,31 @@ static const struct seq_operations vmsta #ifdef CONFIG_SMP #ifdef CONFIG_PROC_FS +static bool need_drain_remote_zones(int cpu) +{ +#ifdef CONFIG_NUMA + struct zone *zone; + + for_each_populated_zone(zone) { + struct per_cpu_pages *pcp; + + pcp = per_cpu_ptr(zone->per_cpu_pageset, cpu); + if (!pcp->count) + continue; + + if (!pcp->expire) + continue; + + if (zone_to_nid(zone) == cpu_to_node(cpu)) + continue; + + return true; + } +#endif + + return false; +} + static void refresh_vm_stats(struct work_struct *work) { refresh_cpu_vm_stats(true); @@ -1940,8 +1965,12 @@ int vmstat_refresh(struct ctl_table *tab void *buffer, size_t *lenp, loff_t *ppos) { long val; - int err; - int i; + int i, cpu; + struct work_struct __percpu *works; + + works = alloc_percpu(struct work_struct); + if (!works) + return -ENOMEM; /* * The regular update, every sysctl_stat_interval, may come later @@ -1955,9 +1984,21 @@ int vmstat_refresh(struct ctl_table *tab * transiently negative values, report an error here if any of * the stats is negative, so we know to go looking for imbalance. */ - err = schedule_on_each_cpu(refresh_vm_stats); - if (err) - return err; + cpus_read_lock(); + for_each_online_cpu(cpu) { + struct work_struct *work = per_cpu_ptr(works, cpu); + struct vmstat_dirty *vms = per_cpu_ptr(&vmstat_dirty_pcpu, cpu); + + INIT_WORK(work, refresh_vm_stats); + + if (vms->dirty || need_drain_remote_zones(cpu)) + schedule_work_on(cpu, work); + } + for_each_online_cpu(cpu) + flush_work(per_cpu_ptr(works, cpu)); + cpus_read_unlock(); + free_percpu(works); + for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++) { /* * Skip checking stats known to go negative occasionally.